test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk
@ 2021-06-02  8:01 Xiang An
  2021-06-02  8:01 ` [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: " Xiang An
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Xiang An @ 2021-06-02  8:01 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Xiang An

v1:
- According to dpdk commit 81db321daeccec0c78bbe8bf4492f18f084ba30f,
    remove command "set_hash_input_set <port_id> <flowtype_id> udp-key
    add" to adapt dpdk, contain testplan and testsuite.

*** BLURB HERE ***

Xiang An (2):
  test_plans/dynamic_flowtype: remove a cmd to adapt dpdk
  tests/dynamic_flowtype: remove a cmd to adapt dpdk

 test_plans/dynamic_flowtype_test_plan.rst | 48 +++++++++++--------------------
 tests/TestSuite_dynamic_flowtype.py       |  2 --
 2 files changed, 16 insertions(+), 34 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: remove a cmd to adapt dpdk
  2021-06-02  8:01 [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk Xiang An
@ 2021-06-02  8:01 ` Xiang An
  2021-06-07  8:53   ` Lin, Xueqin
  2021-06-02  8:01 ` [dts] [PATCH V1 2/2] tests/dynamic_flowtype: " Xiang An
  2021-06-09  7:12 ` [dts] [PATCH V1 0/2] dynamic_flowtype: " Tu, Lijuan
  2 siblings, 1 reply; 6+ messages in thread
From: Xiang An @ 2021-06-02  8:01 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Xiang An

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 test_plans/dynamic_flowtype_test_plan.rst | 48 +++++++++++--------------------
 1 file changed, 16 insertions(+), 32 deletions(-)

diff --git a/test_plans/dynamic_flowtype_test_plan.rst b/test_plans/dynamic_flowtype_test_plan.rst
index 83ed5eb..ad68536 100644
--- a/test_plans/dynamic_flowtype_test_plan.rst
+++ b/test_plans/dynamic_flowtype_test_plan.rst
@@ -176,22 +176,18 @@ Test Case: Update flow type to GTP-U IPv4 pctype mapping item
 
     testpmd> show port 0 pctype mapping
 	
-4. Add udp key to hash input set for flow type id 26 on port 0::
-
-    testpmd> set_hash_input_set 0 26 udp-key add
-
-5. Enable flow type id 26's RSS::
+4. Enable flow type id 26's RSS::
 
     testpmd> port config all rss 26
 
-6. Start testpmd
+5. Start testpmd
 
-7. Send GTP-U IPv4 packets, check RSS could work, print PKT_RX_RSS_HASH::
+6. Send GTP-U IPv4 packets, check RSS could work, print PKT_RX_RSS_HASH::
 
     >>> p=Ether()/IP()/UDP(dport=2152)/GTP_U_Header()/IP()/Raw('x'*20)
     >>> p=Ether()/IPv6()/UDP(dport=2152)/GTP_U_Header()/IP()/Raw('x'*20)
 
-8. Send GTP-U IPv6, GTP-U PAY4 and GTP-C PAY4 packets, check receive packets 
+7. Send GTP-U IPv6, GTP-U PAY4 and GTP-C PAY4 packets, check receive packets 
    from queue 0 and don't have PKT_RX_RSS_HASH print.
   
 
@@ -209,22 +205,18 @@ Test Case: Update flow type to GTP-U IPv6 pctype mapping item
 
     testpmd> show port 0 pctype mapping
 	
-4. Add udp key to hash input set for flow type id 23 on port 0::
-
-    testpmd> set_hash_input_set 0 23 udp-key add
-
-5. Enable flow type id 23's RSS::
+4. Enable flow type id 23's RSS::
 
     testpmd> port config all rss 23
 
-6. Start testpmd
+5. Start testpmd
 
-7. Send GTP-U IPv6 packets, check RSS could work, print PKT_RX_RSS_HASH::
+6. Send GTP-U IPv6 packets, check RSS could work, print PKT_RX_RSS_HASH::
 
     >>> p=Ether()/IP()/UDP(dport=2152)/GTP_U_Header()/IPv6()/Raw('x'*20)
     >>> p=Ether()/IPv6()/UDP(dport=2152)/GTP_U_Header()/IPv6()/Raw('x'*20)
 
-8. Send GTP-U IPv4, GTP-U PAY4 and GTP-C PAY4 packets, check receive 
+7. Send GTP-U IPv4, GTP-U PAY4 and GTP-C PAY4 packets, check receive 
    packets from queue 0 and don't have PKT_RX_RSS_HASH print
   
 
@@ -243,22 +235,18 @@ Test Case: Update flow type to GTP-U PAY4 pctype mapping item
 
     testpmd> show port 0 pctype mapping
 	
-4. Add udp key to hash input set for flow type id 24 on port 0::
-
-    testpmd> set_hash_input_set 0 24 udp-key add
-
-5. Enable flow type id 24's RSS::
+4. Enable flow type id 24's RSS::
 
     testpmd> port config all rss 24
 
-6. Start testpmd
+5. Start testpmd
 
-7. Send GTP-U, PAY4 packets, check RSS could work, print PKT_RX_RSS_HASH::
+6. Send GTP-U, PAY4 packets, check RSS could work, print PKT_RX_RSS_HASH::
 
     >>> p=Ether()/IP()/UDP(dport=2152)/GTP_U_Header()/Raw('x'*20)
     >>> p=Ether()/IPv6()/UDP(dport=2152)/GTP_U_Header()/Raw('x'*20)
 
-8. Send GTP-U IPv4, GTP-U IPv6 and GTP-C PAY4 packets, check receive 
+7. Send GTP-U IPv4, GTP-U IPv6 and GTP-C PAY4 packets, check receive 
    packets from queue 0 and don't have PKT_RX_RSS_HASH print.
  
 	  
@@ -274,22 +262,18 @@ Test Case: Update flow type to GTP-C PAY4 pctype mapping item
 	
 3. Check flow ptype to pctype mapping adds 25 this mapping 
 	
-4. Add udp key to hash input set for flow type id 25 on port 0::
-
-    testpmd> set_hash_input_set 0 25 udp-key add
-
-5. Enable flow type id 25's RSS::
+4. Enable flow type id 25's RSS::
 
     testpmd> port config all rss 25
 
-6. Start testpmd
+5. Start testpmd
 
-7. Send GTP-C PAY4 packets, check RSS could work, print PKT_RX_RSS_HASH::
+6. Send GTP-C PAY4 packets, check RSS could work, print PKT_RX_RSS_HASH::
 
     >>> p=Ether()/IP()/UDP(dport=2123)/GTP_U_Header()/Raw('x'*20)
     >>> p=Ether()/IPv6()/UDP(dport=2123)/GTP_U_Header()/Raw('x'*20)
 
-8. Send GTP-U IPv4, GTP-U IPv6 and GTP-U PAY4 packets, check receive packets
+7. Send GTP-U IPv4, GTP-U IPv6 and GTP-U PAY4 packets, check receive packets
    from queue 0 and don't have PKT_RX_RSS_HASH print.
 
    
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 2/2] tests/dynamic_flowtype: remove a cmd to adapt dpdk
  2021-06-02  8:01 [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk Xiang An
  2021-06-02  8:01 ` [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: " Xiang An
@ 2021-06-02  8:01 ` Xiang An
  2021-06-07  8:53   ` Lin, Xueqin
  2021-06-09  7:12 ` [dts] [PATCH V1 0/2] dynamic_flowtype: " Tu, Lijuan
  2 siblings, 1 reply; 6+ messages in thread
From: Xiang An @ 2021-06-02  8:01 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Xiang An

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_dynamic_flowtype.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/TestSuite_dynamic_flowtype.py b/tests/TestSuite_dynamic_flowtype.py
index 3f47d59..d60a582 100644
--- a/tests/TestSuite_dynamic_flowtype.py
+++ b/tests/TestSuite_dynamic_flowtype.py
@@ -235,8 +235,6 @@ class TestDynamicFlowtype(TestCase):
                     % (pctype, flowtype) in out,
                     "Failed update flow type to pctype mapping!!!")
         if reset is False:
-            self.dut_testpmd.execute_cmd(
-                'set_hash_input_set 0 %s udp-key add' % flowtype)
             self.dut_testpmd.execute_cmd('port config all rss %s' % flowtype)
         else:
             self.dut_testpmd.execute_cmd('port config 0 pctype mapping reset')
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: remove a cmd to adapt dpdk
  2021-06-02  8:01 ` [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: " Xiang An
@ 2021-06-07  8:53   ` Lin, Xueqin
  0 siblings, 0 replies; 6+ messages in thread
From: Lin, Xueqin @ 2021-06-07  8:53 UTC (permalink / raw)
  To: An, XiangX, dts

> -----Original Message-----
> From: An, XiangX <xiangx.an@intel.com>
> Sent: Wednesday, June 2, 2021 4:02 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; An, XiangX <xiangx.an@intel.com>
> Subject: [dts][PATCH V1 1/2] test_plans/dynamic_flowtype: remove a cmd to
> adapt dpdk
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
Acked-by: Xueqin Lin <Xueqin.lin@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 2/2] tests/dynamic_flowtype: remove a cmd to adapt dpdk
  2021-06-02  8:01 ` [dts] [PATCH V1 2/2] tests/dynamic_flowtype: " Xiang An
@ 2021-06-07  8:53   ` Lin, Xueqin
  0 siblings, 0 replies; 6+ messages in thread
From: Lin, Xueqin @ 2021-06-07  8:53 UTC (permalink / raw)
  To: An, XiangX, dts

> -----Original Message-----
> From: An, XiangX <xiangx.an@intel.com>
> Sent: Wednesday, June 2, 2021 4:02 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; An, XiangX <xiangx.an@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/dynamic_flowtype: remove a cmd to adapt
> dpdk
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
Acked-by: Xueqin Lin <Xueqin.lin@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk
  2021-06-02  8:01 [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk Xiang An
  2021-06-02  8:01 ` [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: " Xiang An
  2021-06-02  8:01 ` [dts] [PATCH V1 2/2] tests/dynamic_flowtype: " Xiang An
@ 2021-06-09  7:12 ` Tu, Lijuan
  2 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2021-06-09  7:12 UTC (permalink / raw)
  To: An, XiangX, dts; +Cc: Lin, Xueqin, An, XiangX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年6月2日 16:02
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk
> 
> v1:
> - According to dpdk commit 81db321daeccec0c78bbe8bf4492f18f084ba30f,
>     remove command "set_hash_input_set <port_id> <flowtype_id> udp-key
>     add" to adapt dpdk, contain testplan and testsuite.
> 
> *** BLURB HERE ***
> 
> Xiang An (2):
>   test_plans/dynamic_flowtype: remove a cmd to adapt dpdk
>   tests/dynamic_flowtype: remove a cmd to adapt dpdk
> 
>  test_plans/dynamic_flowtype_test_plan.rst | 48 +++++++++++--------------------
>  tests/TestSuite_dynamic_flowtype.py       |  2 --
>  2 files changed, 16 insertions(+), 34 deletions(-)
> 

Applied the series.
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-09  7:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02  8:01 [dts] [PATCH V1 0/2] dynamic_flowtype: remove a cmd to adapt dpdk Xiang An
2021-06-02  8:01 ` [dts] [PATCH V1 1/2] test_plans/dynamic_flowtype: " Xiang An
2021-06-07  8:53   ` Lin, Xueqin
2021-06-02  8:01 ` [dts] [PATCH V1 2/2] tests/dynamic_flowtype: " Xiang An
2021-06-07  8:53   ` Lin, Xueqin
2021-06-09  7:12 ` [dts] [PATCH V1 0/2] dynamic_flowtype: " Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git