From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 023E9A04B1; Wed, 9 Sep 2020 07:32:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7E7A1BE0C; Wed, 9 Sep 2020 07:32:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 553D51B9B7 for ; Wed, 9 Sep 2020 07:32:45 +0200 (CEST) IronPort-SDR: hiBZq1Ti74HPg/lyfrezOiWH1iaLdbyH8+zgunt2pW52WPHfAgoukh8hqaGJo74XfmX382Mo4i FVVwjbOL6BfA== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="176332414" X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="176332414" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 22:32:44 -0700 IronPort-SDR: kpnbY6rNWp+ldLlFHWvYBTNk8GIqw/wxDgW4yvaDk+fOwKgNM3dimFFlYdgGERSC++3Hg2VDXt s7g9myDLaWug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="377755872" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 08 Sep 2020 22:32:44 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 22:32:43 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 22:32:43 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 22:32:43 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 22:32:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOWa7wQlD+BjCKX6gLU81hKlYT05vRENpynfHGxI9w8xx/FjET/bOskZe5s03jqX/Y/zEKhXSe834/oaAKvJtyz1UoRk/8rkrIaP0h+8nG/+2HksC0Sr0KLssSVb7oCiPf2DGSrTB0MpdQpASu10gVkD8/F55IYoVqix/V6iyfwuJ+u6xu9GRmqM44HQGo05nsceQnntiQE6MqXf5A6dkc/bMiUYR+jtmLP75X6m8jNaREl8bhkJeTi41+Gs8zjdTH8Bpn/iN7Jsw9KGCzsZQQ9J+WZ85uuO82aJ3ywwfZRr80e2+TNhUgwtEGsVHRLx/ybI6dF2d+coBkLA6/OulA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N5GS23qoH+1Viv9+KV9PWYyCumjR5QzyvyyQ8eDjZGU=; b=khnP6PknGuNzH17DRIP7YyMzXZeeGhtvNsHrsB8f7nTd9jnoYwAJw12vUNdnBmH5zDsm7u2NOUlVZpuzUQukq8kEH4QXMgg7Gicpbx3v9HJKeR3TzT7L9aKpr4YMVQMH/s+cHrNTxX/4eHNE1wSHnnZ4qNFlv6bvSBBW3mIViOozqzRJZU7r8x3t6YctsCcl/naA8qxy4fhxBipshECfiG6sL7jstkS/Jn7KON0DGlSc9B9MUIefUtTUhzgGjtCmVT33JdAz0mRt4842OOqovhQn0LQSYPiag9rUVyC2g5y+4WO/rpV6BbKKP+kmvOkQaveqG4fVDwhBUqpdWAXnfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N5GS23qoH+1Viv9+KV9PWYyCumjR5QzyvyyQ8eDjZGU=; b=rjOcL+R9TuoF4Ylnqa1FYtxwC2qejoBMFSnxA14rqxsPQe+Pza+Huv+hLrqvJspeRJKAqUnxohgVDxF51inJQMrprhRvkA9N7duB8l7zsDO12lB6Qn7j1yEFmZvFWswJ7A5Pfaos+8AfaHOuyZA96AzXa+Ks6EMS/fgP78SOiLE= Received: from BN8PR11MB3715.namprd11.prod.outlook.com (2603:10b6:408:85::13) by BN6PR1101MB2194.namprd11.prod.outlook.com (2603:10b6:405:55::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Wed, 9 Sep 2020 05:32:39 +0000 Received: from BN8PR11MB3715.namprd11.prod.outlook.com ([fe80::45c2:fb36:838e:6d28]) by BN8PR11MB3715.namprd11.prod.outlook.com ([fe80::45c2:fb36:838e:6d28%7]) with mapi id 15.20.3348.019; Wed, 9 Sep 2020 05:32:38 +0000 From: "Ma, LihongX" To: Owen Hilyard , "dts@dpdk.org" CC: "Zhang, XiX" , "Zhang, XuemingX" Thread-Topic: [dts][PATCH V1] tests/checksum_offload: Bugfix for bug 529 Thread-Index: AQHWgu+USm+32uX91kKI/Y0xfzuANalfzerQ Date: Wed, 9 Sep 2020 05:32:38 +0000 Message-ID: References: <20200904071321.26617-1-ohilyard@iol.unh.edu> In-Reply-To: <20200904071321.26617-1-ohilyard@iol.unh.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: iol.unh.edu; dkim=none (message not signed) header.d=none;iol.unh.edu; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d6b043e-3b65-4be6-efde-08d85481c3fd x-ms-traffictypediagnostic: BN6PR1101MB2194: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yvNRIQ0U1f/Kbd67Z7M4D09Cv1gZL/G8oEmBbHybYjbrnPhT7TBbqInWFnJaY/a373jGlUZQ2UcIxkTEKHe/74qrwlNnDhvw0SO77kyaVSe1Te0Z9LgD1Kj7mJ8oQUi63cbVGycXYagn4RmECGzosEG9G4CVWC4qnRU4C8Y2QaMORUMbwEo0eoUnVomHT0BD+K6KTfB4XVA2MXTROh4Hvrg/Qm4+wyifkblLZg9N+53YaCsFzhEwXTGpauo1a7U5wge1K565+Di7BKA4x3ZjRmJmzIH/EGyGaBLjgv2TEW0Sbgx0lhsQC8qmKytJMxRK2CwwwsnZS+rkrSYC0UQqBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3715.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(2906002)(86362001)(110136005)(316002)(8936002)(33656002)(8676002)(4326008)(9686003)(54906003)(71200400001)(7696005)(478600001)(66946007)(76116006)(52536014)(66446008)(66556008)(64756008)(66476007)(55016002)(6506007)(5660300002)(107886003)(186003)(26005)(53546011)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: yDIMjAcUh2HLrV7nRoEDc+FuuGqzU5f+xLIgehXg5SeSDKjFNgyTY52oub4u1QOjwWL10XPjmjnOzECctdaPDXb5FOQ87Jq8uFF2avetf8/aIMRLPtl09UK4I7SuRzBrjBmAxouPV895OCTHk42G5dXBJovrMZcAAA4rBTcNv+grpiAGl3LGdpiHOu1hBJ6dNkLjSlj6gY1RHu0OmPf7eze8K6BV2GpSoMhl20S2A6LP7XVC0FOqw8kcgr2pZxSfBXnZTzIofRbrJ/VLHouX6Irfjiowjk0hmBzIQfee7KIuF2f0NabvXFi+Ey7CLDZKGzK2L9tZrjG8PKQLqMTE6eBMKWjFx4xifjaKMuJxQ7uou+UW0M/+clfEqSlG1JFdgUlPl0WmnrB9zD7p7GzPto9xJbh/fUwuLRlofX9vTzHOIzFVA0Owdcqv5+ykWyBC8ck6Ho56Fsdyod7loaQHYV3l6gumalv2Kgkk2EBjvgcfHIAVXbIpo5sS7UXGHFzfNIBnrwHTESeSoalcsUXxUAIiPfmstpnQqMZziiS16a+Tu0MM+pJqwx3WNaUEM+B/2fCCHwSdrcehy+/SoK2jXoEosDiNUYvuIJtfj2EEOKl0/lI/YiGn9x6ZL6BiN0vo3pNzdoAMSKKmjBKLnSU8iQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3715.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6b043e-3b65-4be6-efde-08d85481c3fd X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2020 05:32:38.6819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mYCGYm8h0Klx7KOdAqCQ2lkUEAOOJDd8hF2nRdergCSL3I1JLpTzCsZ/KIl/RE4+Ztxlv5HcMJA20taV/SmnHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2194 X-OriginatorOrg: intel.com Subject: Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, owen Can you send a tested-by of this patch base on self-test and the result is = pass, It is best to upload the test log at same time. Regards, Ma,lihong > -----Original Message----- > From: Owen Hilyard > Sent: Friday, September 4, 2020 3:13 PM > To: dts@dpdk.org; Ma, LihongX > Cc: Zhang, XiX ; Zhang, XuemingX > ; ohilyard@iol.unh.edu > Subject: [dts][PATCH V1] tests/checksum_offload: Bugfix for bug 529 >=20 > added missing quote in template for scapy packets. >=20 > Signed-off-by: Owen Hilyard > --- > tests/TestSuite_checksum_offload.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index c4a877d..ef7a9de 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): > def replay_pcap_file_on_tester(self, iface, packet_file_path): > self.tester.send_expect("scapy", ">>>") > self.scapy_exec(f"packets =3D rdpcap('{packet_file_path}')") > - self.scapy_exec(f"sendp(packets, iface=3D{iface})") > + self.scapy_exec(f"sendp(packets, iface=3D'{iface}')") > self.tester.send_expect("quit()", "# ") >=20 > def validate_packet_list_checksums(self, packets): > @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): > for l4 in l4_protos: > for chksum in "", "chksum=3D0xf": > vf =3D > self.send_pkt_expect_good_bad_from_flag_catch_failure( > - f"eth/IP({chksum})/{l4}()/(X'*50)", > + f"eth/IP({chksum})/{l4}()/('X'*50)", > "PKT_RX_IP_CKSUM_", f"{l4}", > should_pass=3D(chksum =3D=3D "")) > if vf is not None: > -- > 2.25.1