From: "Ma, LihongX" <lihongx.ma@intel.com>
To: Thinh Tran <thinhtr@linux.vnet.ibm.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework/tester closing scapy session raise exception
Date: Thu, 22 Oct 2020 08:12:08 +0000 [thread overview]
Message-ID: <BN8PR11MB37158D597FC7F90223C38DF09E1D0@BN8PR11MB3715.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201021181146.125603-1-thinhtr@linux.vnet.ibm.com>
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Thinh Tran
> Sent: Thursday, October 22, 2020 2:12 AM
> To: dts@dpdk.org
> Cc: thinhtr@linux.vnet.ibm.com
> Subject: [dts] [PATCH] framework/tester closing scapy session raise
> exception
>
> Sending control "^c" during closing the scapy sessions raised the time-
> out exception for expecting scapy prompt ">>> " return causing the
> failure
> during setup.
> Simply sending "quit" to exit scapy gratefully instead.
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> framework/tester.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/framework/tester.py b/framework/tester.py index
> ca179b2..a7a68b5 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -868,8 +868,7 @@ class Tester(Crb):
> if self.scapy_sessions_li:
> for i in self.scapy_sessions_li:
> if i.session.isalive():
> - i.session.send_expect("^c", ">>> ", timeout=2)
> - i.session.send_expect("^d", "#", timeout=2)
> + i.session.send_expect("quit", "# ", timeout=2)
> i.session.close()
> self.scapy_sessions_li.clear()
>
> --
> 2.17.0
The session is scapy session that start the scapy, so can not use the command quit, should use "quit()"
Regards,
Ma,lihong
prev parent reply other threads:[~2020-10-22 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:11 Thinh Tran
2020-10-22 8:12 ` Ma, LihongX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37158D597FC7F90223C38DF09E1D0@BN8PR11MB3715.namprd11.prod.outlook.com \
--to=lihongx.ma@intel.com \
--cc=dts@dpdk.org \
--cc=thinhtr@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).