Re: [dts] [PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio create vf and add no_vec_eal_params

["Ma, LihongX" <lihongx.ma@intel.com>]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> Sent: Tuesday, October 27, 2020 3:40 PM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts] [PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio create
> vf and add no_vec_eal_params
> 
> v1:insmod igb_uio create vf and add no_vec_eal_params v2:update EAL
> parameter force-max-simd-bitwidth=64  notes
> 
> Signed-off-by: xizhan4x <xix.zhang@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py
> b/tests/TestSuite_qinq_filter.py index 91a2d7a..0d90627 100644
> -
> -        self.dut.send_expect(r'%s -c %s -n 4 -- -i \
> +        #add a EAL parameter --force-max-simd-bitwidth=64,it disable all
> vector code paths.
> +        no_vec_eal_params='--force-max-simd-bitwidth=64'
> +        self.dut.send_expect(r'%s -c %s -n 4 %s -- -i \
>                                 --portmask=%s --port-topology=loop \
> -                               --rxq=4 --txq=4  --disable-rss' %
> (self.path, self.coreMask, self.portMask),
> +                               --rxq=4 --txq=4  --disable-rss' %
> + (self.path, self.coreMask, no_vec_eal_params, self.portMask),
>                                 "testpmd> ", 30)

I think all the cases in the suite will tested on no-vector path, but there is only one case add this parameter, could you check it?

>          """
>          qinq filter packet received by assign VF queues
>          """
> +        self.dut.setup_modules(self.target,'igb_uio',None)
>          self.config_vfs(dutRxPortId, 2)
>          vf_list = self.dut.ports_info[dutRxPortId]['sriov_vfs_pci']

If it is needed setup module of igb_uio, it is better add to the place where need it.
Eg: before self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')

Regards,
Ma,lihong