Re: [dts] [PATCH V1] test/dual_vlan: Code optimization

["Peng, Yuan" <yuan.peng@intel.com>]

Acked by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Chen, BoX C
Sent: Tuesday, June 30, 2020 3:08 PM
To: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] test/dual_vlan: Code optimization

Tested-by:  Chen, BoX C <BoX.C.Chen@intel.com>

Regards,
Chen Bo

> -----Original Message-----
> From: Chen, BoX C <box.c.chen@intel.com>
> Sent: June 30, 2020 14:59
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V1] test/dual_vlan: Code optimization
> 
> Delete code that will not be executed
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  tests/TestSuite_dual_vlan.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/TestSuite_dual_vlan.py 
> b/tests/TestSuite_dual_vlan.py index daa23d3..73d3156 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -348,8 +348,6 @@ class TestDualVlan(TestCase):
>          self.mode_config(extend="off")
>          self.mode_config(strip="off")
>          self.mode_config(stripq="off")
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]:
> -            self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue 
> disable error : " +
> out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase):
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue 
> disable error: " +
> out)
> -        if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single", "fortville_25g", 
> "fortpark_TLV","fortpark_BASE-T" "carlsville"]:
> -            self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
> 
>      def test_vlan_insert_config(self):
>          """
> --
> 2.17.1