Re: [dts] [dpdk-dts] [PATCH v2] tests: disable VLAN filter for cavium nics

[Radoslaw Biernacki <radoslaw.biernacki@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 2904 bytes --]

Sorry for late response, I spot this one just now.
Liu already merge it so please take this just as note for consideration.

Since the NIC is the same in ThunderX and OcteonTX, it in fact apply to
both.
So V1 was better in my opinion.

On 1 December 2017 at 12:08, Jogarao Nartu <njogarao@caviumnetworks.com>
wrote:

> Testpmd must be run with hardware VLAN filter disabled as OcteonTx driver
> does not support this feature.
>
> Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
> ---
>
>  v2 changes:
>    Made NIC name specific to Cavium OcteonTx
>
>  tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index e36fa64..f7985f2 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase):
>          """
>          Run history log dump test case.
>          """
> -        self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> +        cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> +        if "cavium_a034" in self.dut.nic_type:
> +            cmd += " --disable-hw-vlan-filter"
> +
> +        self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
>          out = self.dut.send_expect("dump_ring", "testpmd>",
> self.run_cmd_time)
>          self.dut.send_expect("quit", "# ")
>          match_regex = "ring <(.*?)>"
> @@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase):
>          """
>          Run mempool dump test case.
>          """
> -        self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> +        cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> +        if "cavium_a034" in self.dut.nic_type:
> +            cmd += " --disable-hw-vlan-filter"
> +
> +        self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
>          out = self.dut.send_expect("dump_mempool", "testpmd>",
> self.run_cmd_time * 2)
>          self.dut.send_expect("quit", "# ")
>          match_regex = "mempool <(.*?)>@0x(.*?)\r\n"
> @@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase):
>          """
>          Run memzone dump test case.
>          """
> -        self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> +        cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> +        if "cavium_a034" in self.dut.nic_type:
> +            cmd += " --disable-hw-vlan-filter"
> +
> +        self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
>          out = self.dut.send_expect("dump_memzone", "testpmd>",
> self.run_cmd_time * 2)
>          self.dut.send_expect("quit", "# ")
>
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 4225 bytes --]