From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 586EB293B for ; Tue, 12 Dec 2017 21:00:19 +0100 (CET) Received: by mail-wr0-f178.google.com with SMTP id o2so50157wro.5 for ; Tue, 12 Dec 2017 12:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sglOx5ELRpaNbUzvOsCxKiAcfX+3mfQ1HeWI0S4mA0I=; b=KQGfbiJAD09wOyRrVXuRClqm7JfRc7eJVC7ByMFj3dHxWGrLLa4PsTjv0aqkFl0hN0 tNsZ8l9OxJGvDc1O/zMxi4Ri3JpmyY52qs/zp6KIqjChrIl9b35nyLQmatvq+fT9mT6d 4PJDUvZId8Sun3Qfw1EFwhNX2SWUbxytmLFOw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sglOx5ELRpaNbUzvOsCxKiAcfX+3mfQ1HeWI0S4mA0I=; b=afB2ZNe6AaylI6AyZKK5Iy5byO/9QVR5vLMPLQcoD/Zgi1WaxF/Ftn7wOQOpzy1lFY FCLRQt2z+qkF3mrsUBFLFtey0rRy8oN2D7KYj6faEqzFxoO4AlER9e+RihhtuFwp+Ptq eSVez5RnYj5lxEJ+Ca65G2ozi1HJNOGD/qb+Ch17fBWX5FSyGATaAlR9NZjD+VsErU9B FHQHKPlw78hvPV0LmUTeoFCIi6IGjnzXttjf7lTz1OK41tGmwOy8DdKG3QnUeQpEsvr4 3lc1/d40ZCLXX+d6STa0YTCt1x0Vgqpz4ud/9nOuOCZS3TbDdFYIhQSVQupBsY/eX7T1 RURQ== X-Gm-Message-State: AKGB3mLDHhECtkRAdQfd/AgyIEEOGYWJ3cF6ryHJnZzfHz4dA6CJY8C8 /skzLbuzA/NNTs/HKZ+vcwS/uYIdgk2NXoqa1vAKFw== X-Google-Smtp-Source: ACJfBovTsMjxIXe/ZsoLJ1lc/lcXyxhbK1rxDFQPsJP0e1hMTxz/vIc7nUnQ9x5iZvp0Fre8LxFyZvppj9oJjzcIMj8= X-Received: by 10.223.133.250 with SMTP id 55mr22558wru.23.1513108818867; Tue, 12 Dec 2017 12:00:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.163.25 with HTTP; Tue, 12 Dec 2017 11:59:58 -0800 (PST) In-Reply-To: <1512126519-14522-1-git-send-email-njogarao@caviumnetworks.com> References: <1511964077-3338-1-git-send-email-njogarao@caviumnetworks.com> <1512126519-14522-1-git-send-email-njogarao@caviumnetworks.com> From: Radoslaw Biernacki Date: Tue, 12 Dec 2017 20:59:58 +0100 Message-ID: To: Jogarao Nartu Cc: "Liu, Yong" , dts@dpdk.org, jerin.jacob@caviumnetworks.com Content-Type: multipart/alternative; boundary="001a11497cb4a7f31205602a198c" Subject: Re: [dts] [dpdk-dts] [PATCH v2] tests: disable VLAN filter for cavium nics X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 20:00:19 -0000 --001a11497cb4a7f31205602a198c Content-Type: text/plain; charset="UTF-8" Sorry for late response, I spot this one just now. Liu already merge it so please take this just as note for consideration. Since the NIC is the same in ThunderX and OcteonTX, it in fact apply to both. So V1 was better in my opinion. On 1 December 2017 at 12:08, Jogarao Nartu wrote: > Testpmd must be run with hardware VLAN filter disabled as OcteonTx driver > does not support this feature. > > Signed-off-by: Jogarao Nartu > --- > > v2 changes: > Made NIC name specific to Cavium OcteonTx > > tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/tests/TestSuite_unit_tests_dump.py > b/tests/TestSuite_unit_tests_dump.py > index e36fa64..f7985f2 100644 > --- a/tests/TestSuite_unit_tests_dump.py > +++ b/tests/TestSuite_unit_tests_dump.py > @@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase): > """ > Run history log dump test case. > """ > - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % > (self.target), "testpmd>", self.start_test_time) > + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target > + > + if "cavium_a034" in self.dut.nic_type: > + cmd += " --disable-hw-vlan-filter" > + > + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) > out = self.dut.send_expect("dump_ring", "testpmd>", > self.run_cmd_time) > self.dut.send_expect("quit", "# ") > match_regex = "ring <(.*?)>" > @@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase): > """ > Run mempool dump test case. > """ > - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % > (self.target), "testpmd>", self.start_test_time) > + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target > + > + if "cavium_a034" in self.dut.nic_type: > + cmd += " --disable-hw-vlan-filter" > + > + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) > out = self.dut.send_expect("dump_mempool", "testpmd>", > self.run_cmd_time * 2) > self.dut.send_expect("quit", "# ") > match_regex = "mempool <(.*?)>@0x(.*?)\r\n" > @@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase): > """ > Run memzone dump test case. > """ > - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % > (self.target), "testpmd>", self.start_test_time) > + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target > + > + if "cavium_a034" in self.dut.nic_type: > + cmd += " --disable-hw-vlan-filter" > + > + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) > out = self.dut.send_expect("dump_memzone", "testpmd>", > self.run_cmd_time * 2) > self.dut.send_expect("quit", "# ") > > -- > 2.7.4 > > --001a11497cb4a7f31205602a198c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry for late response, I spot this one just now.
Liu= already merge it so please take this just as note for consideration.
=

Since the NIC is the same in ThunderX and OcteonTX, it = in fact apply to both.
So V1 was better in my opinion.

On 1 December 20= 17 at 12:08, Jogarao Nartu <njogarao@caviumnetworks.com><= /span> wrote:
Testpmd must be run with ha= rdware VLAN filter disabled as OcteonTx driver
does not support this feature.

Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
---

=C2=A0v2 changes:
=C2=A0 =C2=A0Made NIC name specific to Cavium OcteonTx

=C2=A0tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++--- =C2=A01 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit= _tests_dump.py
index e36fa64..f7985f2 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run history log dump test case.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("./%s/app/testp= md -n 1 -c f -- -i" % (self.target), "testpmd>", self.sta= rt_test_time)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd =3D "./%s/app/testpmd -n 1 -c f -- -i= " % self.target
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if "cavium_a034" in self.dut.nic_typ= e:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd +=3D " --disable-hw-vla= n-filter"
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("%s" % cmd, &qu= ot;testpmd>", self.start_test_time)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0out =3D self.dut.send_expect("dump_<= wbr>ring", "testpmd>", self.run_cmd_time)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.send_expect("quit", &q= uot;# ")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0match_regex =3D "ring <(.*?)>&= quot;
@@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run mempool dump test case.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("./%s/app/testp= md -n 1 -c f -- -i" % (self.target), "testpmd>", self.sta= rt_test_time)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd =3D "./%s/app/testpmd -n 1 -c f -- -i= " % self.target
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if "cavium_a034" in self.dut.nic_typ= e:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd +=3D " --disable-hw-vla= n-filter"
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("%s" % cmd, &qu= ot;testpmd>", self.start_test_time)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0out =3D self.dut.send_expect("dump_<= wbr>mempool", "testpmd>", self.run_cmd_time * 2)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.send_expect("quit", &q= uot;# ")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0match_regex =3D "mempool <(.*?)&g= t;@0x(.*?)\r\n"
@@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run memzone dump test case.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("./%s/app/testp= md -n 1 -c f -- -i" % (self.target), "testpmd>", self.sta= rt_test_time)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd =3D "./%s/app/testpmd -n 1 -c f -- -i= " % self.target
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if "cavium_a034" in self.dut.nic_typ= e:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cmd +=3D " --disable-hw-vla= n-filter"
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("%s" % cmd, &qu= ot;testpmd>", self.start_test_time)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0out =3D self.dut.send_expect("dump_<= wbr>memzone", "testpmd>", self.run_cmd_time * 2)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.send_expect("quit", &q= uot;# ")

--
2.7.4


--001a11497cb4a7f31205602a198c--