* [dts] [dpdk-dts] [PATCH] tests/dump: disable VLAN filter for cavium nics
@ 2017-11-29 14:01 Jogarao Nartu
2017-12-01 11:08 ` [dts] [dpdk-dts] [PATCH v2] tests: " Jogarao Nartu
0 siblings, 1 reply; 4+ messages in thread
From: Jogarao Nartu @ 2017-11-29 14:01 UTC (permalink / raw)
To: yong.liu; +Cc: dts, jerin.jacob, Jogarao Nartu
Testpmd must be run with hardware VLAN filter disabled as OcteonTx
driver does not support this feature.
Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
---
tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index e36fa64..b04f775 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase):
"""
Run history log dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_ring", "testpmd>", self.run_cmd_time)
self.dut.send_expect("quit", "# ")
match_regex = "ring <(.*?)>"
@@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase):
"""
Run mempool dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_mempool", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
match_regex = "mempool <(.*?)>@0x(.*?)\r\n"
@@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase):
"""
Run memzone dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_memzone", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [dts] [dpdk-dts] [PATCH v2] tests: disable VLAN filter for cavium nics
2017-11-29 14:01 [dts] [dpdk-dts] [PATCH] tests/dump: disable VLAN filter for cavium nics Jogarao Nartu
@ 2017-12-01 11:08 ` Jogarao Nartu
2017-12-04 9:16 ` Liu, Yong
2017-12-12 19:59 ` Radoslaw Biernacki
0 siblings, 2 replies; 4+ messages in thread
From: Jogarao Nartu @ 2017-12-01 11:08 UTC (permalink / raw)
To: yong.liu; +Cc: dts, jerin.jacob, Jogarao Nartu
Testpmd must be run with hardware VLAN filter disabled as OcteonTx driver
does not support this feature.
Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
---
v2 changes:
Made NIC name specific to Cavium OcteonTx
tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index e36fa64..f7985f2 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase):
"""
Run history log dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium_a034" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_ring", "testpmd>", self.run_cmd_time)
self.dut.send_expect("quit", "# ")
match_regex = "ring <(.*?)>"
@@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase):
"""
Run mempool dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium_a034" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_mempool", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
match_regex = "mempool <(.*?)>@0x(.*?)\r\n"
@@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase):
"""
Run memzone dump test case.
"""
- self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % (self.target), "testpmd>", self.start_test_time)
+ cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
+
+ if "cavium_a034" in self.dut.nic_type:
+ cmd += " --disable-hw-vlan-filter"
+
+ self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_memzone", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dts] [dpdk-dts] [PATCH v2] tests: disable VLAN filter for cavium nics
2017-12-01 11:08 ` [dts] [dpdk-dts] [PATCH v2] tests: " Jogarao Nartu
@ 2017-12-04 9:16 ` Liu, Yong
2017-12-12 19:59 ` Radoslaw Biernacki
1 sibling, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2017-12-04 9:16 UTC (permalink / raw)
To: Jogarao Nartu; +Cc: dts, jerin.jacob
Thanks Nartu. Applied.
On 12/01/2017 07:08 PM, Jogarao Nartu wrote:
> Testpmd must be run with hardware VLAN filter disabled as OcteonTx driver
> does not support this feature.
>
> Signed-off-by: Jogarao Nartu<njogarao@caviumnetworks.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [dpdk-dts] [PATCH v2] tests: disable VLAN filter for cavium nics
2017-12-01 11:08 ` [dts] [dpdk-dts] [PATCH v2] tests: " Jogarao Nartu
2017-12-04 9:16 ` Liu, Yong
@ 2017-12-12 19:59 ` Radoslaw Biernacki
1 sibling, 0 replies; 4+ messages in thread
From: Radoslaw Biernacki @ 2017-12-12 19:59 UTC (permalink / raw)
To: Jogarao Nartu; +Cc: Liu, Yong, dts, jerin.jacob
[-- Attachment #1: Type: text/plain, Size: 2904 bytes --]
Sorry for late response, I spot this one just now.
Liu already merge it so please take this just as note for consideration.
Since the NIC is the same in ThunderX and OcteonTX, it in fact apply to
both.
So V1 was better in my opinion.
On 1 December 2017 at 12:08, Jogarao Nartu <njogarao@caviumnetworks.com>
wrote:
> Testpmd must be run with hardware VLAN filter disabled as OcteonTx driver
> does not support this feature.
>
> Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
> ---
>
> v2 changes:
> Made NIC name specific to Cavium OcteonTx
>
> tests/TestSuite_unit_tests_dump.py | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index e36fa64..f7985f2 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -85,7 +85,12 @@ class TestUnitTestsDump(TestCase):
> """
> Run history log dump test case.
> """
> - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> + if "cavium_a034" in self.dut.nic_type:
> + cmd += " --disable-hw-vlan-filter"
> +
> + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
> out = self.dut.send_expect("dump_ring", "testpmd>",
> self.run_cmd_time)
> self.dut.send_expect("quit", "# ")
> match_regex = "ring <(.*?)>"
> @@ -100,7 +105,12 @@ class TestUnitTestsDump(TestCase):
> """
> Run mempool dump test case.
> """
> - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> + if "cavium_a034" in self.dut.nic_type:
> + cmd += " --disable-hw-vlan-filter"
> +
> + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
> out = self.dut.send_expect("dump_mempool", "testpmd>",
> self.run_cmd_time * 2)
> self.dut.send_expect("quit", "# ")
> match_regex = "mempool <(.*?)>@0x(.*?)\r\n"
> @@ -133,7 +143,12 @@ class TestUnitTestsDump(TestCase):
> """
> Run memzone dump test case.
> """
> - self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
> + cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
> +
> + if "cavium_a034" in self.dut.nic_type:
> + cmd += " --disable-hw-vlan-filter"
> +
> + self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
> out = self.dut.send_expect("dump_memzone", "testpmd>",
> self.run_cmd_time * 2)
> self.dut.send_expect("quit", "# ")
>
> --
> 2.7.4
>
>
[-- Attachment #2: Type: text/html, Size: 4225 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-12 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 14:01 [dts] [dpdk-dts] [PATCH] tests/dump: disable VLAN filter for cavium nics Jogarao Nartu
2017-12-01 11:08 ` [dts] [dpdk-dts] [PATCH v2] tests: " Jogarao Nartu
2017-12-04 9:16 ` Liu, Yong
2017-12-12 19:59 ` Radoslaw Biernacki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).