From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D2B84A0096 for ; Fri, 12 Apr 2019 19:25:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99D161B39D; Fri, 12 Apr 2019 19:25:00 +0200 (CEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by dpdk.org (Postfix) with ESMTP id 2AC121B29A for ; Fri, 12 Apr 2019 19:25:00 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id x61so8978289edc.9 for ; Fri, 12 Apr 2019 10:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q56oKQIlFqay3/gBXrYU9JaUlhBnkHCG9yPUJ9tV1xk=; b=LLp9eD18uAmlzSQOc7x+ipevrT+oz/xQz+0uYiZSuOlJHLUlLLUNlGaXWFPT1TVMDm JiSO1XC3q5O0XoNWkSIL9JWfhE/AUdsEdWFkLZHdfk1JlvpNv21LX4dXKO9nW56CO9Fu EjmS3wqV8HOLVzRZwatfLIUSwSFFF7VGWH5y4Ahi9SpxNf0QIV79uVViyoL2i2qRRGrx RosNzM89KW9qdtM+LtbuO4yU5U+E7USo2UTu4MnBdUOgCzm/OgP1S3e6PJtzKsidZiKg okiky8C+Ky5AmWkXLZVGBU30wLuYaecdkBasijOdBNve+tDfsnpOFqmmd5i1n8A+0ZxB g0vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q56oKQIlFqay3/gBXrYU9JaUlhBnkHCG9yPUJ9tV1xk=; b=UMBj9BJAjFA2Zpz3rVcUHPt/dpk51rz82xISo5HmtR6Zk0r9m7tXPFnL3qFbwB2QB/ 6sDJlPW0ad1fTHHfpSGbwcLAndcuQNcoBhscAqHgPyH+tcrRjLa3i+l7pUL/HXUI9E8/ UgtL5heE7uDFfqPJCS4cvYx9s3nrurpbbaRkILjliyZ8+M3vNz2JwnvmEO+haWZ4CVtS IOok3Zv9fYxd4ewqOCVwNQlKdzkWKvJn7qMTAKPu4SVX2a2q1RfDeYP6evR7Xue9ZNxS 1cNa095M+JhYgfPrNRq+tK8K6F9awFck6fOkXJmLds7sm4yDXyOHdt675LZnqxp/3Kui iHqg== X-Gm-Message-State: APjAAAWBo8qF+ldudf1K+Z7bps5rFojwKuFTWFrIPj4JQwTQavT3c54U 3xz/PrvogXF3/t+SE/sLpaT5LuGUeUW0jE9ud28= X-Google-Smtp-Source: APXvYqxXJ8IvaqLHKCXSAPjgAJBPNQ3wC+gYG1IUxzt5+mPuUKyrm9QyVH+uBo0A3iY0iiCdpklWvDWPcfEQLi/BBik= X-Received: by 2002:a50:fe15:: with SMTP id f21mr27426925edt.135.1555089899709; Fri, 12 Apr 2019 10:24:59 -0700 (PDT) MIME-Version: 1.0 References: <20190412073845.3506-1-ramirose@gmail.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA60C22@SHSMSX101.ccr.corp.intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA60C70@SHSMSX101.ccr.corp.intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA60CA4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA60CA4@SHSMSX101.ccr.corp.intel.com> From: Rami Rosen Date: Fri, 12 Apr 2019 20:24:52 +0300 Message-ID: To: "Tu, Lijuan" Cc: dts@dpdk.org Content-Type: multipart/alternative; boundary="00000000000010ec4e05865895ef" Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --00000000000010ec4e05865895ef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Lijuan, I see now what you mean now. Well, i do not know all nuances of grammer, and sometimes there is more than one rule. I think "creating a RSS rule" is not wrong, but I remember I encountered in the past "creating an RSS rule", for example: https://patches.dpdk.org/patch/47790/ http://patchwork.dpdk.org/patch/34609/ Maybe i even used something like this in my book, can't remember :) But this is really minor. I will send v2 with "a RSS rule". Regards, Rami Rosen =D7=91=D7=AA=D7=90=D7=A8=D7=99=D7=9A =D7=99=D7=95=D7=9D =D7=95=D7=B3, 12 = =D7=91=D7=90=D7=A4=D7=A8=D7=B3 2019, 19:55, =D7=9E=D7=90=D7=AA Tu, Lijuan = =E2=80=8F: > Mess up again. > > I think r is consonant, so we take an =E2=80=9Ca=E2=80=9D before it , not= an =E2=80=9Can=E2=80=9D, so > =E2=80=9CCreate a rss rult with=E2=80=9D should be =E2=80=9CCreate a rss = rule with=E2=80=9D > > > > > > *From:* dts [mailto:dts-bounces@dpdk.org] *On Behalf Of *Tu, Lijuan > *Sent:* Friday, April 12, 2019 9:50 AM > *To:* Rami Rosen > *Cc:* dts@dpdk.org > *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo > > > > I think r is consonant, so we take an =E2=80=9Can=E2=80=9D before it , no= t an =E2=80=9Ca=E2=80=9D, so > =E2=80=9CCreate a rss rult with=E2=80=9D should be =E2=80=9CCreate a rss = rule with=E2=80=9D > > > > *From:* Rami Rosen [mailto:ramirose@gmail.com ] > *Sent:* Friday, April 12, 2019 9:45 AM > *To:* Tu, Lijuan > *Cc:* dts@dpdk.org > *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo > > > > Hi Lijuan, > > > > In the code we have: > > >> Create a rss rult with > > > > >I think it is a rss rule > > > > Not sure what you mean by this. Is "rult" an rss rule ? This seems more > like a typo (that the patch fixes) > > > > Regards, > > Rami Rosen > > > --00000000000010ec4e05865895ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Lijuan,

= I see=C2=A0 now what you mean now. Well, i do not know all nuances
=C2=A0of grammer, and sometimes there is more than one rule.= =C2=A0
I think "creating a RSS rule" is no= t wrong, but
I remember I encountered in the past &q= uot;creating an RSS rule", for example:

Maybe i even used som= ething like this in my book, can't remember :)
<= br>
But this is really minor.
I will send v2 with "a RSS rule".

Regards,
Rami Rosen




=D7=91=D7=AA=D7=90=D7=A8=D7=99=D7=9A =D7=99=D7=95=D7=9D =D7=95=D7= =B3, 12 =D7=91=D7=90=D7=A4=D7=A8=D7=B3 2019, 19:55, =D7=9E=D7=90=D7=AA Tu, = Lijuan =E2=80=8F<lijuan.tu@intel.= com>:

Mess up again.

I think r is consonant, so we take an= =E2=80=9Ca=E2=80=9D before it , not an =E2=80=9Can=E2=80=9D, so =E2=80=9CC= reate a rss rult with=E2=80=9D should be =E2=80=9CCreate a rss rule with=E2= =80=9D

=C2=A0

=C2=A0

From: dts [mailto:dts-bounces@dp= dk.org] On Behalf Of Tu, Lijuan
Sent: Friday, April 12, 2019 9:50 AM
To: Rami Rosen <ramirose@gmail.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo<= u>

=C2=A0

I think r is consonant, so we take an= =E2=80=9Can=E2=80=9D before it , not an =E2=80=9Ca=E2=80=9D, so =E2=80=9CC= reate a rss rult with=E2=80=9D should be =E2=80=9CCreate a rss rule with=E2= =80=9D

=C2=A0

From: Rami Rosen [mailto:ramirose@gm= ail.com]
Sent: Friday, April 12, 2019 9:45 AM
To: Tu, Lijuan <lijuan.tu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo<= u>

=C2=A0

Hi Lijuan,

=C2=A0

In the code we have:=C2=A0

=C2=A0 =C2=A0>>=C2=A0Create a rss rult with=

=C2=A0

>I think it is a rss rule

=C2=A0

Not sure what you mean by this. Is "rult" an rss rule ? This= seems more like a typo (that the patch fixes)

=C2=A0

Regards,

Rami Rosen

=C2=A0

--00000000000010ec4e05865895ef--