From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C54EDA0096 for ; Fri, 15 Mar 2019 08:30:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87B4E2C17; Fri, 15 Mar 2019 08:30:33 +0100 (CET) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 336E511A4 for ; Fri, 15 Mar 2019 08:30:32 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id j89so6743406edb.9 for ; Fri, 15 Mar 2019 00:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pZq6/tAsSHHSNmoz3hqxHt84QBrwAmT0xNJiVhTVCLU=; b=PSjRWkGWpLBqqsPI6fEKbS/pSLKL1qj7YdlN4fi2ZnJJ3u5dKYucid+OFoNjOvFtV4 sHN2pMl69zXcwCbNId8hkkdTUlX757Uz1DAzwiHIZts1qIw4T4yscy2WV6nV7jhjuRav Cz9/1hn7it1V1mrxd0BWYVtxyDDh12PypRd1SRI35JBuoD06Pdn6qwPgzaTh8zPpkDc6 kHVbFkcJl38kdD1ZZp0EpS2Y20mqScc4zNvUgmHafv54tN4lPvooS1vUUpcVvvv/SVTw ZL1j2nBvp8eV9szrgAfw7xUjheVR6Hga0X2FnKW5kEY5SE2eC4MkI33WsSKZlXSCo84E huxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pZq6/tAsSHHSNmoz3hqxHt84QBrwAmT0xNJiVhTVCLU=; b=Es8RpeU9LrGpsJk+JpJGu6cnjsejCUpZA18ybKrd1yXbvPAlv0ulMygWZshpiBM6Om sazzjxkdJyE3G4f5pHsOxNWaEVkwN7cUWuVUgq9siullaT2lOe31h1rm3eg6TJCmfXJS CQKkGsBvYed37BjSw5howLREU4lxAGBDVWtQy4ovdgNXYr45Ftg0XzWQMAJhIdwA0c7P KrxIf5fB4zG1rl6fQruv7kEoxjyMW27yt0zGeK4Dcc544H3miC6FYTZ20SiQl33BJeQY BhVlsGCt76c3JSYNPA1Y8PXHc+DGssEh7h+3k9+H/4r/EIT2GzjAcJ6SiUNeXVJXE04w zf9Q== X-Gm-Message-State: APjAAAWZ6RoQqzHKSVmigtAhpf6/zV7Za5nB7j1eT+0QLTQI2a9kdgGs hZwZHl06j3ZJNOvEbaYfLGviMXRnBXepSu3KiVU= X-Google-Smtp-Source: APXvYqxkkHR1Vuxr6T+Hld4oAoM2OthKbf/9jr8srZtPtO9RM9iIMKkLzLXrjDxX3KARjr1c28J/H64hQvod1qcpE3w= X-Received: by 2002:a50:9863:: with SMTP id h32mr1760878edb.291.1552635031722; Fri, 15 Mar 2019 00:30:31 -0700 (PDT) MIME-Version: 1.0 References: <1552367414-29273-1-git-send-email-bingx.y.yao@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA432C6@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA432C6@SHSMSX101.ccr.corp.intel.com> From: Rami Rosen Date: Fri, 15 Mar 2019 09:30:19 +0200 Message-ID: To: "Tu, Lijuan" Cc: "Yao, BingX Y" , "dts@dpdk.org" Content-Type: multipart/alternative; boundary="00000000000088204a05841d0334" Subject: Re: [dts] [PATCH V1] tests/pmdrss_hash:change hard code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --00000000000088204a05841d0334 Content-Type: text/plain; charset="UTF-8" > - self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target, > "testpmd> ", 120) > + self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i" % > + (self.target, self.coremask), "testpmd> ", 120) [Lijuan] Do you forget to change hardcode of memory channel? > out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30) > bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip()) Hi all, Good point. Actually, the number of channels is a non mandatory EAL parameter, and in DTS it defaults to 1. http://git.dpdk.org/tools/dts/tree/framework/dut.py#n565 In this module, the other invocations of testpmd were indeed with get_memory_channels(). In this occurrence it is hardcoded to 4. The number of memory channels is merely an optimization, as you can see in the following thread: https://dev.dpdk.narkive.com/78gtSXha/dpdk-dev-patch-eal-default-to-one-memory-channel-if-not-specified According to it, ... Obtaining the correct value of memory channels, especially from a running system, can be anything from difficult to plain impossible. ... Not sure what was the reason for hard coding it to 4 in this test case, but anyhow on this occasion maybe it is better to replace it with get_memory_channels() as with the rest of the module, for the sake of consistency. Regards, Rami Rosen > > --00000000000088204a05841d0334 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % se= lf.target,
> "testpmd> ", 120)
> +=C2=A0 = =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i" %
> += (self.target, self.coremask), "testpmd> ", 120)
<= div dir=3D"auto">
[Lijuan] Do you forget to change hardcode of memory chann= el?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 out =3D self.dut.send_exp= ect("create bonded device 3 0", "testpmd> ", 30)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bond_device_id =3D int(re.search= ("port \d+", out).group().split(" ")[-1].strip())

Hi all,=C2=A0

Good poi= nt.=C2=A0
Actually, the number of channels is a non = mandatory EAL parameter, and in DTS it defaults to 1.

In this module, the other invocations of testpmd were indeed with = get_memory_channels().
In this occurrence it is hard= coded to 4.

The number of memory channels is merely an optimization, as = you can see in the following thread:
According to it,=
...
Obtaining the correct value of memory channels, especially from a
running sys= tem, can be anything from difficult to plain impossible.
...

Not sure w= hat was the reason for hard coding it to 4 in this test case, but anyhow on= this occasion maybe it is better to replace it with get_memory_channels() = as with the rest of the module, for the sake of consistency.

Regards,
Rami = Rosen






--00000000000088204a05841d0334--