test suite reviews and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <ramirose@gmail.com>
To: changqingxwu <changqingx.wu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests:add test suite about l2fwd jobstats
Date: Fri, 19 Apr 2019 16:42:12 +0300	[thread overview]
Message-ID: <CAHLOa7Tcf4usqbWn9oYnjkvmH92Oj3xq3Fd7c=R9xcn4y9jbaQ@mail.gmail.com> (raw)
In-Reply-To: <1555664336-14060-1-git-send-email-changqingx.wu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi, Chang,

> +class TestKeepAlive(TestCase):

There is no reason to use TestKeepAlive as the name of this class.
Moreover, it is used in another
DTS Test Suite:

http://git.dpdk.org/tools/dts/tree/tests/TestSuite_keep_alive.py#n43

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 1512 bytes --]

      reply	other threads:[~2019-04-19 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  8:58 changqingxwu
2019-04-19 13:42 ` Rami Rosen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLOa7Tcf4usqbWn9oYnjkvmH92Oj3xq3Fd7c=R9xcn4y9jbaQ@mail.gmail.com' \
    --to=ramirose@gmail.com \
    --cc=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).