From: Rami Rosen <ramirose@gmail.com>
To: han yingya <yingyax.han@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1]test_plan/vf_l3fwd: add vf l3fwd performance test plan
Date: Tue, 7 May 2019 21:27:44 +0300 [thread overview]
Message-ID: <CAHLOa7TgvYYNqTZfG5T1XZV_ocEXeT1PezSLCQVcRPse6gP9_g@mail.gmail.com> (raw)
In-Reply-To: <20190507160010.26505-1-yingyax.han@intel.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
Hi Han,
Thanks for this patch.
Minor comments are following:
performace -> Should be performance:
> +Test Case 1: Measure performace with kernel PF & dpdk VF
traffic configuration meet LPM=> should be: traffic configuration meets LPM
>+make sure your traffic configuration meet LPM rules, and will go to all
queues, all ports.
Again also here: performace -> Should be performance:
>+Test Case 2: Measure performace with dpdk PF & dpdk VF
Again also here: traffic configuration meet LPM=> should be: traffic
configuration meets LPM
>+make sure your traffic configuration meet LPM rules, and will go to all
queues, all ports.
Reviewed-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: Type: text/html, Size: 1014 bytes --]
next prev parent reply other threads:[~2019-05-07 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:00 han yingya
2019-05-07 18:27 ` Rami Rosen [this message]
2019-05-08 1:38 ` Han, YingyaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLOa7TgvYYNqTZfG5T1XZV_ocEXeT1PezSLCQVcRPse6gP9_g@mail.gmail.com \
--to=ramirose@gmail.com \
--cc=dts@dpdk.org \
--cc=yingyax.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).