From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 159A4A0096 for ; Tue, 7 May 2019 20:27:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0B71343C; Tue, 7 May 2019 20:27:57 +0200 (CEST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by dpdk.org (Postfix) with ESMTP id D5EC0293B for ; Tue, 7 May 2019 20:27:55 +0200 (CEST) Received: by mail-wm1-f45.google.com with SMTP id b10so21783652wmj.4 for ; Tue, 07 May 2019 11:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vJzZ02131Ie2aYcOsAU49qReRwOnKKFiccunvGRDdqM=; b=j0JS7OUdkQUomQGtV/JoOlOirhLQcOrtErylyNsgsYRxBZNjr4sJeX1abD6LfLddLX hmjiBLA7TXQjbkyg0Jz12evx8HkmWgBjT6ShwJ3eiHljwxi5tlH+K2ffH2fjJ1JoyYhd 3Yah+J7GX9drtd38+ch80cbBUJdEmikRkdGiJqn3quqavFFrHV5V7OXmFInsYzRDmKyD v9CoRErPRCMYoEyl2WrBZMafPRIqyTU6qwIpBf6v8hySX2alyzSKR0wPKu9v4VH3seD4 QX8KFCsZ4Nt4kInZvx9kSlgic2HvLBLCTIdbfb9krEOKEcu1ZF4UScSx4YdnOCyywO5+ xlRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vJzZ02131Ie2aYcOsAU49qReRwOnKKFiccunvGRDdqM=; b=KViRR7EHzg5/JS3ypnZIqhzTSJ5jJ2pVC8MYjO1fn3quKPdjikT6YEr8nYPGPsZepi CYkd0WXEfSdahIWzXpyRU27Pi9CyejO3qclZqS1i+fUQUD0fuPiwRsXlU88fWdgvC4Sy +tpyVnYjEYJISvDQKdsQ8Bfs4KKnhS05JkxYCxJmtHFuOPH1qtSu5SObBwwhD5YohOJZ gxGAk8yOeIpjz4EBqMRe5Wdq/0sexzTTRrWid8Sx4Tg8F7Wy881gxxKjCgi/nEZnYsXm xpfFsC3rLzIauiSYqTgpx02/1MYk5D2+Hts7dTPLShwmry4dWSQt99d8dpaVI9hYyPJS HZRw== X-Gm-Message-State: APjAAAWdohKANfou2gzvfcq/rEWeU2TaU4rV1miIOgMdCXd24d2azUSW LpSKoqAlcozd5iD8/DnWOD3rJEeN5M9XEd3soF0= X-Google-Smtp-Source: APXvYqz6qdptS8Jj+QKF5V01vchb4mro5L6vze7poK3wglJQ9FT7VTKTAiYB7y/cqA9pWmzmdDOhqkN20ye23Y+q14o= X-Received: by 2002:a1c:acc8:: with SMTP id v191mr23231815wme.72.1557253675458; Tue, 07 May 2019 11:27:55 -0700 (PDT) MIME-Version: 1.0 References: <20190507160010.26505-1-yingyax.han@intel.com> In-Reply-To: <20190507160010.26505-1-yingyax.han@intel.com> From: Rami Rosen Date: Tue, 7 May 2019 21:27:44 +0300 Message-ID: To: han yingya Cc: dts@dpdk.org Content-Type: multipart/alternative; boundary="00000000000026a66a05885060ca" Subject: Re: [dts] [PATCH V1]test_plan/vf_l3fwd: add vf l3fwd performance test plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --00000000000026a66a05885060ca Content-Type: text/plain; charset="UTF-8" Hi Han, Thanks for this patch. Minor comments are following: performace -> Should be performance: > +Test Case 1: Measure performace with kernel PF & dpdk VF traffic configuration meet LPM=> should be: traffic configuration meets LPM >+make sure your traffic configuration meet LPM rules, and will go to all queues, all ports. Again also here: performace -> Should be performance: >+Test Case 2: Measure performace with dpdk PF & dpdk VF Again also here: traffic configuration meet LPM=> should be: traffic configuration meets LPM >+make sure your traffic configuration meet LPM rules, and will go to all queues, all ports. Reviewed-by: Rami Rosen --00000000000026a66a05885060ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Han,
Thanks for this patch.
<= div>
Minor comments are following:

p= erformace -> Should be performance:
> +Test Case 1: Measur= e performace with kernel PF & dpdk VF

traffic config= uration meet LPM=3D> should be: traffic configuration meets LPM
>+make sure your traffic configuration meet LPM rules, and will go= to all queues, all ports.

Again also here: perfor= mace -> Should be performance:
>+Test Case 2: Measure p= erformace with dpdk PF & dpdk VF

Again als= o here: traffic configuration meet LPM=3D> should be: traffic configurat= ion meets LPM
>+make sure your traffic configuration meet = LPM rules, and will go to all queues, all ports.

Reviewed-by: Rami Rosen <ramiro= se@gmail.com>

--00000000000026a66a05885060ca--