test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: dts@dpdk.org
Subject: Re: [dts] [PATCH] ci/pylama: Added pylama config file
Date: Thu, 12 Aug 2021 12:29:16 -0400	[thread overview]
Message-ID: <CAHx6DYADnzD0sMok+Lv4c7RRZizfWWWyg4NBdWh-UjTVR4WSXw@mail.gmail.com> (raw)
In-Reply-To: <20210812162255.80127-1-ohilyard@iol.unh.edu>

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

This depends on the requirements file that I added when adding the other ci
script. I want to make it as easy as possible to install everything needed
for CI, which means all of it should go in one requirements file. Even with
my removing many issues, this still has a lot of issues with the DTS
codebase, 35126 issues to be exact. We may want to bring this back to the
working group and discuss more, after fixing just the errors, since there
is a manageable amount of those.

On Thu, Aug 12, 2021 at 12:23 PM <ohilyard@iol.unh.edu> wrote:

> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> I ended up turning off most of the formatting-releated checks due to
> some minor conflicts with black (black allows lines > 80 characters for
> instance). This produces a very substantial list of errors, some of
> which may need to be simply disabled instead of being fixed due to
> architectural reasons.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  ci/requirements.txt | 5 ++++-
>  pylama.ini          | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>  create mode 100644 pylama.ini
>
> diff --git a/ci/requirements.txt b/ci/requirements.txt
> index 0abd6716..e19e540e 100644
> --- a/ci/requirements.txt
> +++ b/ci/requirements.txt
> @@ -29,4 +29,7 @@
>  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>  # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> -argparse==1.4.0
> \ No newline at end of file
> +argparse==1.4.0
> +pylama
> +pylama_pylint
> +black
> \ No newline at end of file
> diff --git a/pylama.ini b/pylama.ini
> new file mode 100644
> index 00000000..aef408c0
> --- /dev/null
> +++ b/pylama.ini
> @@ -0,0 +1,5 @@
> +[pylama]
> +format = pylint
> +linters = pep8,pycodestyle,pylint
> +ignore = F0401,C0111,E731,E266,E501,E203
> +
> --
> 2.30.2
>
>

[-- Attachment #2: Type: text/html, Size: 2398 bytes --]

  reply	other threads:[~2021-08-12 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 16:22 ohilyard
2021-08-12 16:29 ` Owen Hilyard [this message]
2022-04-06 13:08 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHx6DYADnzD0sMok+Lv4c7RRZizfWWWyg4NBdWh-UjTVR4WSXw@mail.gmail.com \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).