Re: [dts] [PATCH] mac_filter: Add multicast filtering test case

[Owen Hilyard <ohilyard@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]

I'll add that into a patch with any other suggestions I see. I also added
that to my linter so it shouldn't happen again.

On Thu, Jul 16, 2020 at 3:49 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Thu, 16 Jul 2020 15:42:36 -0400
> Owen Hilyard <ohilyard@iol.unh.edu> wrote:
>
> > Sorry about sending this twice, I noticed after todays meeting that this
> was caught in the moderator queue and I want to get it out to the mailing
> list at large asap.
> >
> > add multicast filtering test case
> > add multicast test case test plan
> >
> > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> > ---
> >  test_plans/mac_filter_test_plan.rst | 27 ++++++++++++++++++++
> >  tests/TestSuite_mac_filter.py       | 39 ++++++++++++++++++++++++++---
> >  2 files changed, 62 insertions(+), 4 deletions(-)
> >
> > diff --git a/test_plans/mac_filter_test_plan.rst
> b/test_plans/mac_filter_test_plan.rst
> > index 1335e9f..e8a4f66 100644
> > --- a/test_plans/mac_filter_test_plan.rst
> > +++ b/test_plans/mac_filter_test_plan.rst
> > @@ -172,3 +172,30 @@ Add one more different address::
> >     testpmd> mac_addr add 0 <A+n+1>
> >
> >  Verify that the response is "No space left on device" (-ENOSPC)
> > +
> > +Test Case: Multicast Filter
> > +===========================
> > +
> > +Initialize first port without ``promiscuous mode``::
> > +
> > +  testpmd> set promisc 0 off
> > +
> > +
> > +Add the multicast MAC address to the multicast filter::
> > +
> > +   testpmd> mcast_addr add 0 01:00:5E:00:00:00
> > +
> > +Send a packet with multicast destination MAC address to port 0::
> > +
> > +   port 0/queue 0: received 1 packets
> > +     src=52:00:00:00:00:00 - dst=01:00:5E:00:00:00 - type=0x0800 -
> length=60 - nb_segs=1 - hw    ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP  -
> sw ptype: L2_ETHER L3_IPV4 L4_UDP  - l2_len=14 - l3_len=20 - l4_len=8 -
> Receive queue=0x0
> > +     ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD
> PKT_RX_OUTER_L4_CKSUM_UNKNOWN
> > +
> > +
> > +Remove the multicast MAC address from the multicast filter::
> > +
> > +   testpmd> mcast_addr remove 0 01:00:5E:00:00:00
> > +
> > +Send a packet with multicast destination MAC address to port 0
> > +
> > +Verify that the packet was not received (Check for "received" in the
> output). There will be no output if the nic responds properly.
> > \ No newline at end of file
>
> Ok, but you must fix this.
>
> Please set your editor so it generates text files that always have a
> newline at the end.
> Although git supports files without ending newline, it is not something we
> want in this project.
>

[-- Attachment #2: Type: text/html, Size: 3381 bytes --]