From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FC5CA04C9; Wed, 2 Sep 2020 20:42:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55BC0137D; Wed, 2 Sep 2020 20:42:52 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id B1F17DE0 for ; Wed, 2 Sep 2020 20:42:50 +0200 (CEST) Received: by mail-ot1-f67.google.com with SMTP id g96so154417otb.12 for ; Wed, 02 Sep 2020 11:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v59LGS6IEXTWYjbxmndid4m6ALirE2iz7TGjJPaab/E=; b=L5/P/0yd5EMBbpKyjQPhGZjxYBe4sx6+szAwC6JZv16Fd4R2+uBnALhfMd1zJg7EQV 9U0SMHQANVObUobY9PBdG9G32+L8LgJVfEpPn0a5OG6OTd+U3oo2H0C0IAF0Ac/nvidJ by8FdotGbIJiM7t8bhNwUxC/vMc/t7qUB6ivs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v59LGS6IEXTWYjbxmndid4m6ALirE2iz7TGjJPaab/E=; b=LLx0gPboMYCCdBBOZBrjNWcNQ3fCfoyblzxFqVBplfD2z2gPz1jxCt8BiV55+VbIyL mvhayzJZWVbcVN8Q+R+AbUh994DfppbBU98mSR0/2hrXyPK6GuQgmiKjanOqVyRm2JZj no/Fap+lUyR5cZBAn5xOJllZKuFohq6YhwhJ/LUKNByHZ886CAblBxHSUwrwx4dGoLmY 05fq2ugrR4K27Md7czmntFA5W/jiqxYekcldATEsmI9yHRqmU1ovZGkBP6ySSe+O66no lc8kiF/bc6k5e8w8KG6JruwHPnoDMfu/VGCrwlTUB1PWCxVT4joHtZwf4LokxXcWrUpL 59cw== X-Gm-Message-State: AOAM533O6znTYeJbUeEtzQeGfbfiYH1ji97qdufa9ttvQesNekpKi+4V MMwt8QBVvhSriG3UbFetzBWi36qzTfrpzCh4IJdWWA== X-Google-Smtp-Source: ABdhPJz+LxsqTqOEwI2T63sn4l6YL3bj9WqlpdmqKtVgB6btAdhEOkDG2jNwt0kZZRYZGFF7RRaf2tNDVCDMCnAHw9M= X-Received: by 2002:a9d:70cb:: with SMTP id w11mr6162170otj.222.1599072169975; Wed, 02 Sep 2020 11:42:49 -0700 (PDT) MIME-Version: 1.0 References: <20200826150429.278284-1-ohilyard@iol.unh.edu> In-Reply-To: From: Owen Hilyard Date: Wed, 2 Sep 2020 14:42:14 -0400 Message-ID: To: "Ma, LihongX" Cc: "dts@dpdk.org" , "Zhang, Yuwei1" , "changqingx.wu@intel.com" , "Xiao, QimaiX" , "Hunt, David" , "lylavoie@iol.unh.edu" Content-Type: multipart/alternative; boundary="000000000000a987df05ae590061" Subject: Re: [dts] [PATCH] rx interrupt: Fixed test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --000000000000a987df05ae590061 Content-Type: text/plain; charset="UTF-8" Hello I'm able to see a material difference between what I've suggested and what the prior test case did. I was attempting to reduce the number of invocations of a pmd during the test, since those invocations are time consuming and, from what I measured, made up the majority of the runtime of the test. Is there a reason why all queues and port's can't be opened at the same time and then ignored until they are needed? The way I re-did the configs was designed to create all possible combinations of settings in the format that was originally there. Are all 3 invocations of the pmd needed or is it possible to merge those and throw out my other changes? Most of my changes were done because I was already planning on submitting a patch to remove the extra invocations and aren't as important. Thanks for your help Owen On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX wrote: > Hi, Owen > I think the change of the plan is not make sense, the case ' PF interrupt > pmd with different queue' is want to test the interrupt on different queue, > The original case will test the queue on min number, max number and normal > number(between minimum and maximum), but your patch will only test one > situation. > > > Regards, > Ma,lihong > > > -----Original Message----- > > From: dts On Behalf Of Owen Hilyard > > Sent: Wednesday, August 26, 2020 11:04 PM > > To: dts@dpdk.org > > Cc: Zhang, Yuwei1 ; changqingx.wu@intel.com; > Xiao, > > QimaiX ; Hunt, David ; > > lylavoie@iol.unh.edu; Owen Hilyard > > Subject: [dts] [PATCH] rx interrupt: Fixed test case > > > > fixed test case issues with eal params > > removed extra instances of l3fwd-power > > > > Signed-off-by: Owen Hilyard > > --- > > test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++----------- > > tests/TestSuite_interrupt_pmd.py | 73 ++++++++++++++------------ > > 2 files changed, 64 insertions(+), 67 deletions(-) > > > > diff --git a/test_plans/interrupt_pmd_test_plan.rst > > b/test_plans/interrupt_pmd_test_plan.rst > > index cb8b2f1..1f8816d 100644 > > --- a/test_plans/interrupt_pmd_test_plan.rst > > +++ b/test_plans/interrupt_pmd_test_plan.rst > > --000000000000a987df05ae590061 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello

I'm able to see a material differenc= e between what I've suggested and what the prior test case did. I was a= ttempting to reduce the number of invocations of a pmd during the test, sin= ce those invocations are time consuming and, from what I measured, made up = the majority of the runtime of the test. Is there a reason why all queues a= nd port's can't be opened at the same time and then ignored until t= hey are needed? The way I re-did the configs was designed to create all pos= sible combinations of settings in the format that was originally=C2=A0there= . Are all 3 invocations of the pmd needed or is it possible to merge those = and throw out my other changes? Most of my changes were done because I was = already planning on submitting=C2=A0a patch to remove the extra invocations= and aren't as important.=C2=A0

Thanks for your help
O= wen

On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX <lihongx.ma@intel.com> wrote:
Hi, Owen
I think the change of the plan is not make sense, the case ' PF interru= pt pmd with different queue' is want to test the interrupt on different= queue,
The original case will test the queue on min number, max number and normal = number(between minimum and maximum), but your patch will only test one situ= ation.


Regards,
Ma,lihong

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> Sent: Wednesday, August 26, 2020 11:04 PM
> To: dts@dpdk.org=
> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@intel.com; Xiao,
> QimaiX <= qimaix.xiao@intel.com>; Hunt, David <david.hunt@intel.com>;
> lylavoie@iol= .unh.edu; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [dts] [PATCH] rx interrupt: Fixed test case
>
> fixed test case issues with eal params
> removed extra instances of l3fwd-power
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>=C2=A0 test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++-----------=
>=C2=A0 tests/TestSuite_interrupt_pmd.py=C2=A0 =C2=A0 =C2=A0 =C2=A0| 73 = ++++++++++++++------------
>=C2=A0 2 files changed, 64 insertions(+), 67 deletions(-)
>
> diff --git a/test_plans/interrupt_pmd_test_plan.rst
> b/test_plans/interrupt_pmd_test_plan.rst
> index cb8b2f1..1f8816d 100644
> --- a/test_plans/interrupt_pmd_test_plan.rst
> +++ b/test_plans/interrupt_pmd_test_plan.rst

--000000000000a987df05ae590061--