From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADFF7A04BC; Fri, 11 Sep 2020 20:34:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 685291C0CD; Fri, 11 Sep 2020 20:34:20 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id AA52A1B9B7 for ; Fri, 11 Sep 2020 20:34:18 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id x19so10374383oix.3 for ; Fri, 11 Sep 2020 11:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UZdRDBYzoPO1EJhN0s3o5SSF66RliTG25IQOWrGGToE=; b=b1imH4IMWExIZrymwe+NL5dRlsxvYdVNnWoLHUg4F15xk5nfkEVmvAYQScL93I5eGx RyXMYMVUzWrvvV8JXP9dmL35uQXQ9vjPazIMhwlQaxSPRUyXfRplvWol8D02TQDpOsZc C1Oca3zQr7hYcrqyFZpyzTblotkWZotoksMY0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UZdRDBYzoPO1EJhN0s3o5SSF66RliTG25IQOWrGGToE=; b=gRcxVtKK3awhu20Pp3FcwwwqfjjlqSaXzsAtpFzYpORYNi5vRKji95NNF/5uVlNmN0 RUhV6+WXo42bTkW17X3YzHeOPRuPAVArsed2yDGcamvV7Mry8oaQ2NxKvopILp0610g4 6VYTcTJ6Y4vzhxBX1v7Dqv02dCHl6Wp4CLeMgP7FmyQ5LEV4V4q/0LAobWSIktRkEwDG BERt0C0fjOvB+rfjuTJ9YGav2RqCKzJ8sBYFfXCIg9XpXwywTWUH0EuLyc2M2XAFrwov sDOsTNeFLbg2a0szTR2yy7EAp+v0SH92Lqzmtkf7A328CWNizJf/W+OCkZp9kT02lhSV i+4Q== X-Gm-Message-State: AOAM5302qQOSFPHm3IZ4vzOyy22xOL8LMSoPJ4pCe2XyUH+5y0YLsHXX SmZCPDTHaUKpip9uAhRDDiHE4qtg70q6m0cTQjCmjw== X-Google-Smtp-Source: ABdhPJzjVOsq8JOxtCnyFWPWWdnd0AEHEbyxv9FKIoJ3wq89EgQOQOu4Z9mUmNJMSiRWJoyt3Aj1bBAbKE3X+FnYULk= X-Received: by 2002:aca:1a17:: with SMTP id a23mr2019946oia.69.1599849257855; Fri, 11 Sep 2020 11:34:17 -0700 (PDT) MIME-Version: 1.0 References: <20200909210807.55311-1-ohilyard@iol.unh.edu> In-Reply-To: From: Owen Hilyard Date: Fri, 11 Sep 2020 14:33:34 -0400 Message-ID: To: "Ma, LihongX" Cc: "dts@dpdk.org" , Lincoln Lavoie Content-Type: multipart/alternative; boundary="000000000000b582b305af0deed1" Subject: Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --000000000000b582b305af0deed1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable With regards to the failed test cases, that is expected behavior for the machine I was running it on. The NIC in the dev machine the IOL team is using is running i40e and the support is P in the compatibility table, and I'm fairly sure our NIC doesn't support inner checksum offloads but does support outer checksum offloads. I'll try to remember to increment the version number if I need more than 1 patch again. Thanks, Owen Hilyard On Wed, Sep 9, 2020 at 9:51 PM Ma, LihongX wrote: > BTW, it is better increase the version number when we submit a new versio= n > of the patch, it will easy to know the latest version of the patch. eg: V= 1 > ,V2, V3 =E2=80=A6. > > > > Regards, > > Ma,lihong > > > > *From:* Ma, LihongX > *Sent:* Thursday, September 10, 2020 9:46 AM > *To:* Owen Hilyard ; dts@dpdk.org > *Cc:* Lincoln Lavoie > *Subject:* RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 > > > > Thanks response of that, in the log file, I find the result of new cases > test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx > are failed, > > Is it expected result of now or there is bug of it ? > > > > Regards, > > Ma,lihong > > > > *From:* Owen Hilyard > *Sent:* Thursday, September 10, 2020 5:14 AM > *To:* dts@dpdk.org; Ma, LihongX > *Cc:* Lincoln Lavoie > *Subject:* Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 > > > > Hello Ma,lihong, > > > > While I was re-testing the entire suite to get the test log file for you, > I found a few more issues that occur when running the entire test suite a= t > once. I've included fixes for these but apparently checkpatch doesn't lik= e > something about the patch, so I'll resubmit. Sorry about that. I've > included the log file after stripping some of the output. Due to how the > test was constructed, I wasn't able to use the normal method to run scapy > and had to do it through send_expect, which means that all of the colorin= gs > in the shell were logged. I've done my best to remove all of the lines wi= th > color symbols in them since they aren't needed to understand the output. > > > > Sorry about messing up the submission again, > > Owen > > > > On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard wrote: > > added missing quote in template for scapy packets. > rearraged closing down scapy and testpmd to avoid issues with other test > cases. > > Signed-off-by: Owen Hilyard > --- > tests/TestSuite_checksum_offload.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index c4a877d..f2e9878 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): > def replay_pcap_file_on_tester(self, iface, packet_file_path): > self.tester.send_expect("scapy", ">>>") > self.scapy_exec(f"packets =3D rdpcap('{packet_file_path}')") > - self.scapy_exec(f"sendp(packets, iface=3D{iface})") > + self.scapy_exec(f"sendp(packets, iface=3D'{iface}')") > self.tester.send_expect("quit()", "# ") > > def validate_packet_list_checksums(self, packets): > @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): > for l4 in l4_protos: > for chksum in "", "chksum=3D0xf": > vf =3D > self.send_pkt_expect_good_bad_from_flag_catch_failure( > - f"eth/IP({chksum})/{l4}()/(X'*50)", > + f"eth/IP({chksum})/{l4}()/('X'*50)", > "PKT_RX_IP_CKSUM_", f"{l4}", > should_pass=3D(chksum =3D=3D "")) > if vf is not None: > @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): > # if vf is not None: > # verification_errors.append(vf) > > - # tunneled inner > + self.tester.send_expect("quit", "#") > + self.dut.send_expect("stop", "testpmd>") > > for err in verification_errors: > self.logger.error(str(err)) > self.verify(len(verification_errors) =3D=3D 0, "See previous out= put") > > - self.tester.send_expect("quit", "#") > - self.dut.send_expect("stop", "testpmd>") > > def test_hardware_checksum_check_l4_tx(self): > self.checksum_enablehw(self.dut_ports[0]) > @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): > > error_messages =3D > self.validate_packet_list_checksums(captured_packets) > > + self.tester.send_expect("quit", "#") > self.dut.send_expect("stop", "testpmd>") > + > if len(error_messages) !=3D 0: > for error_msg in error_messages: > self.logger.error(error_msg) > -- > 2.25.1 > > --000000000000b582b305af0deed1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
With regards to the failed test cases, that is expected be= havior for the machine I was running it on. The NIC in the dev machine the = IOL team is using is running i40e and the support is P in the compatibility= table, and I'm fairly sure our NIC doesn't support inner checksum = offloads but does support outer checksum offloads. I'll try to remember= to increment=C2=A0the version number if I need more than 1 patch again.=C2= =A0

Thanks,
Owen Hilyard

On Wed, Sep 9, 2020 at 9:51 PM Ma,= LihongX <lihongx.ma@intel.com> wrote:

= BTW, it is better increase the version number when we submit a new version = of the patch, it will easy to know the latest version of the patch. eg: V1 = ,V2, V3 =E2=80=A6.

= =C2=A0

= Regards,

= Ma,lihong=

= =C2=A0

From: Ma, LihongX
Sent: Thursday, September 10, 2020 9:46 AM
To: Owen Hilyard <ohilyard@iol.unh.edu>; dts@dpdk.org
Cc: Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529

=C2=A0

= Thanks response of that, in the log file, I find the result of new cases te= st_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are= failed,

= Is it expected result of now or there is bug of it ?

= =C2=A0

= Regards,

= Ma,lihong

= =C2=A0

From: Owen Hilyard <ohilyard@iol.unh.edu>
Sent: Thursday, September 10, 2020 5:14 AM
To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
Cc: Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529

=C2=A0

Hello Ma,lihong,

=C2=A0

While I was re-testing the entire suite to get the t= est log file for you, I found a few more issues that occur when running the= entire test suite at once. I've included fixes for these but apparentl= y checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the l= og file after stripping some of the output. Due to how the test was constru= cted, I wasn't able to use the normal method to run scapy and had to do= it through=C2=A0send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove= all of the lines with color symbols in them since they aren't needed t= o understand the output.=C2=A0

=C2=A0

Sorry about messing up the submission again,<= u>

Owen

=C2=A0

On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu<= /a>> wrote:

added missing quote in = template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test cases.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
=C2=A0tests/TestSuite_checksum_offload.py | 11 ++++++-----
=C2=A01 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum= _offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
=C2=A0 =C2=A0 =C2=A0def replay_pcap_file_on_tester(self, iface, packet_file= _path):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.tester.send_expect("scapy"= , ">>>")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.scapy_exec(f"packets =3D rdpcap= ('{packet_file_path}')")
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.scapy_exec(f"sendp(packets, iface=3D= {iface})")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.scapy_exec(f"sendp(packets, iface=3D= '{iface}')")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.tester.send_expect("quit()"= ;, "# ")

=C2=A0 =C2=A0 =C2=A0def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for l4 in l4_protos:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for chksum in "",= "chksum=3D0xf":
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vf =3D self.s= end_pkt_expect_good_bad_from_flag_catch_failure(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f&qu= ot;eth/IP({chksum})/{l4}()/(X'*50)",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f&qu= ot;eth/IP({chksum})/{l4}()/('X'*50)",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0"PKT_RX_IP_CKSUM_", f"{l4}",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0should_pass=3D(chksum =3D=3D ""))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if vf is not = None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if vf is = not None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0verification_errors.append(vf)

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 # tunneled inner
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.tester.send_expect("quit", &quo= t;#")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("stop", "t= estpmd>")

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for err in verification_errors:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.logger.error(str(err))=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.verify(len(verification_errors) =3D= =3D 0, "See previous output")

=C2=A0 =C2=A0 =C2=A0 =C2=A0 -=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.tester.send_e= xpect("quit", "#")
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expect("stop", "t= estpmd>")

=C2=A0 =C2=A0 =C2=A0def test_hardware_checksum_check_l4_tx(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.checksum_enablehw(self.dut_ports[0])=
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error_messages =3D self.validate_packet_l= ist_checksums(captured_packets)

+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.tester.send_expect("quit", &quo= t;#")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.send_expect("stop", &q= uot;testpmd>")
+
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if len(error_messages) !=3D 0:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for error_msg in error_mess= ages:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.logger.e= rror(error_msg)
--
2.25.1

--000000000000b582b305af0deed1--