Re: [DTS][V2 1/2] framework/*: Add function to support ASan test

[Owen Hilyard <ohilyard@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

>
> sys.path.insert(0, DTS_PATH)
>

Please use python modules to handle this behavior. Directly modifying the
interpreter path causes issues with static analysis tools and IDEs.

Also, this seems to be designed to be entirely outside of the normal flow
for DTS. To me, it seems like you could do much the same thing by using
setting some variable (DTS_USE_ASAN) to true, and then in
the DPDKdut::build_install_dpdk_*_meson, add "-Db_sanitize=address" to the
arguments for meson. After all test suites are run, but before we output
results, add a check for that variable (DTS_USE_ASAN) and if it's true then
check the logs from all the test suites that were run for any ASAN failure
messages. If there is some reason why that isn't feasible, please let me
know. Currently, this seems like an alternative entry point to DTS that
will introduce an additional maintenance burden, and I think that making it
instead act as a few small behavioral changes in the existing DTS framework
would be easier to integrate with CI.

Owen

[-- Attachment #2: Type: text/html, Size: 1275 bytes --]