Am I missing where this is disabled for performance tests? Both ASAN and LSAN have a large performance impact, especially in any code that allocates a lot of memory. I have no objections to using this in functional testing, since performance doesn't matter that much there.

I also can't tell if this changes the json output for a test suite. If an asan failure does not cause a test case/suite to fail, (which I think it should), then we need to have that information available in test_results.json, probably as a new key under the per-crb output. If an asan failure does cause the test case/suite to fail, then I don't think we need extra output.

Finally, I think the config file needs to describe all of the options and what their valid values are, nic_single_core_perf.cfg is a good example of this. Also, I would prefer to avoid embedding json in the config files if possible, and I think that we might be able to have the start and end values for each of the sanitizers be stored as a pair, so we would have something like this:

lsan_bounds=LeakSanitizer, SUMMARY

asan_bounds=AddressSanitizer, SUMMARY

That would avoid needing to use json parsing and you could just access by index.

Owen Hilyard