From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F9FA04C1; Fri, 11 Sep 2020 22:17:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF56A1C126; Fri, 11 Sep 2020 22:17:53 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 32E1E1C124 for ; Fri, 11 Sep 2020 22:17:52 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id c13so10637341oiy.6 for ; Fri, 11 Sep 2020 13:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PnFZat/Xa89Y+9/D7dubb2bCjlRlXIj4x49Lc6H02KI=; b=fAmRmaFSbhZY2laHt6W0faz2d22VAHpLWbIUSYHikQcE5ZHDkZvJNzsQyZOMVP4M4T FFoyqbQF71e53G8sNKUgNNbrIyBai22kBmZtYNGkfcpKNX0e8sBWFhZGV0xLVE7rfxgJ U4M9qVL2CTAeD8td67Y2AtaYkm767/IM2G2ik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PnFZat/Xa89Y+9/D7dubb2bCjlRlXIj4x49Lc6H02KI=; b=a8AJjSC4HBHW6pr7CmlzfZq/GR0hzHa3fAAe3yzH3LP/EZWKEOmRETr2xgYIzH5u5P 7pjtZS7itGrfDp7eOV7uPn+RtRioEfKcxkFV/CVB3+EC5cufwC+/7VGF5VBmu6LGJgkz RC6er5rWg9aMSTxebuRMDZnJUfXFmaIqdedBN9+THaKRarBxnjcUy7kYCM1muSWLXIH1 5qNd1dsrmpbSdpuISfxfMnDGKLGfE9YE6vv4/PCGwDmijVgH1ib62o1pLNCHJsafGfUt abd5wOLaiz0Q/bK/chKAZ3+MMQ2X04/idTzE7DIQDZgCTf5rlEqjTqBPb64o6lV0bddo shYA== X-Gm-Message-State: AOAM530N8JXMAYvU+9nks776zcFiLJbzI3bhfuX024H5tPJ8Y0TNHHTS ZtKr5WK09pImsnZuCiASxN7+bpyw/iyn8t9FP9Aymw== X-Google-Smtp-Source: ABdhPJyEhwJNWKSmViR8w8Sy9st3MOteldnk+obqEFVU4M2J6hCV7H0UtSpqfFuPC3xA3I8Zibq+wKgmejMcILGCQQM= X-Received: by 2002:aca:1a17:: with SMTP id a23mr2294022oia.69.1599855471557; Fri, 11 Sep 2020 13:17:51 -0700 (PDT) MIME-Version: 1.0 References: <20200826150429.278284-1-ohilyard@iol.unh.edu> <0a2e634c71be4012ad463dadb47a3ac9@intel.com> In-Reply-To: <0a2e634c71be4012ad463dadb47a3ac9@intel.com> From: Owen Hilyard Date: Fri, 11 Sep 2020 16:17:07 -0400 Message-ID: To: "Tu, Lijuan" Cc: "Ma, LihongX" , "dts@dpdk.org" , "Zhang, Yuwei1" , "changqingx.wu@intel.com" , "Xiao, QimaiX" , "Hunt, David" , "lylavoie@iol.unh.edu" Content-Type: multipart/alternative; boundary="00000000000013159805af0f61c0" Subject: Re: [dts] [PATCH] rx interrupt: Fixed test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --00000000000013159805af0f61c0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable After looking into it, the l3fwd-power tool does not have the capability to change queue numbers or mappings without restarting. Testpmd currently lacks the ability (as far as I know) to bind a queue to an lcore. Is this a feature that would be reasonable to add to testpmd or should I drop work on this test case? This is turning into quite a time sink and I'm beginning to think that it would be more beneficial to DTS if I focused on creating the Flow API test suite rather than trying to make marginal improvements to this test case. Owen Hilyard On Wed, Sep 9, 2020 at 1:58 AM Tu, Lijuan wrote: > Hi Owen, > > > > Reduce the number of invocations is a good idea, and your design is more > perfect for a common case. But we still need to consider the boundary, th= e > minimum and the maximum queue number. I really suggest we might get a > random number from the minimum, maximum, and normal queue number, if then > invocation is reduced, besides boundary checking is covered. Definitely w= e > will run test for a long time not only once. > > > > thanks > > > > *From:* dts *On Behalf Of * Owen Hilyard > *Sent:* 2020=E5=B9=B49=E6=9C=883=E6=97=A5 2:42 > *To:* Ma, LihongX > *Cc:* dts@dpdk.org; Zhang, Yuwei1 ; > changqingx.wu@intel.com; Xiao, QimaiX ; Hunt, > David ; lylavoie@iol.unh.edu > *Subject:* Re: [dts] [PATCH] rx interrupt: Fixed test case > > > > Hello > > I'm able to see a material difference between what I've suggested and wha= t > the prior test case did. I was attempting to reduce the number of > invocations of a pmd during the test, since those invocations are time > consuming and, from what I measured, made up the majority of the runtime = of > the test. Is there a reason why all queues and port's can't be opened at > the same time and then ignored until they are needed? The way I re-did th= e > configs was designed to create all possible combinations of settings in t= he > format that was originally there. Are all 3 invocations of the pmd needed > or is it possible to merge those and throw out my other changes? Most of = my > changes were done because I was already planning on submitting a patch to > remove the extra invocations and aren't as important. > > Thanks for your help > > Owen > > > > On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX wrote: > > Hi, Owen > I think the change of the plan is not make sense, the case ' PF interrupt > pmd with different queue' is want to test the interrupt on different queu= e, > The original case will test the queue on min number, max number and norma= l > number(between minimum and maximum), but your patch will only test one > situation. > > > Regards, > Ma,lihong > > > -----Original Message----- > > From: dts On Behalf Of Owen Hilyard > > Sent: Wednesday, August 26, 2020 11:04 PM > > To: dts@dpdk.org > > Cc: Zhang, Yuwei1 ; changqingx.wu@intel.com; > Xiao, > > QimaiX ; Hunt, David ; > > lylavoie@iol.unh.edu; Owen Hilyard > > Subject: [dts] [PATCH] rx interrupt: Fixed test case > > > > fixed test case issues with eal params > > removed extra instances of l3fwd-power > > > > Signed-off-by: Owen Hilyard > > --- > > test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++----------- > > tests/TestSuite_interrupt_pmd.py | 73 ++++++++++++++------------ > > 2 files changed, 64 insertions(+), 67 deletions(-) > > > > diff --git a/test_plans/interrupt_pmd_test_plan.rst > > b/test_plans/interrupt_pmd_test_plan.rst > > index cb8b2f1..1f8816d 100644 > > --- a/test_plans/interrupt_pmd_test_plan.rst > > +++ b/test_plans/interrupt_pmd_test_plan.rst > > --00000000000013159805af0f61c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
After looking into it, the l3fwd-power tool does not have = the capability to change queue numbers or mappings without restarting. Test= pmd currently lacks the ability (as far as I know) to bind a queue to an lc= ore. Is this a feature that would be reasonable to add to testpmd or should= I drop work on this test case? This is turning into quite a time sink and = I'm beginning=C2=A0to think that it would be more beneficial=C2=A0to DT= S if I focused on creating the Flow API test suite rather than trying to ma= ke marginal improvements to this test case.=C2=A0

Owen Hilyard
=
On Wed= , Sep 9, 2020 at 1:58 AM Tu, Lijuan <lijuan.tu@intel.com> wrote:

Hi Owen,

=C2=A0

Reduce the number of invocations is a good idea, and= your design is more perfect for a common case. But we still need to consid= er the boundary, the minimum and the maximum queue number. I really suggest= we might get a random number from the minimum, maximum, and normal queue number, if then invocation is reduc= ed, besides boundary checking is covered. Definitely we will run test for a= long time not only once.

=C2=A0

thanks

=C2=A0

From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
Sent: 2020=E5=B9=B49=E6=9C=883=E6= =97=A5 2:42
To: Ma, LihongX <lihongx.ma@intel.com>
Cc: dts@dpdk.org; Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@intel.com; Xiao, QimaiX <qimaix.xiao@intel.co= m>; Hunt, David <david.hunt@intel.com>; lylavoie@iol.unh.edu
Subject: Re: [dts] [PATCH] rx interrupt: Fixed test case

=C2=A0

Hello

I'm able to see a material difference between wh= at I've suggested and what the prior test case did. I was attempting to= reduce the number of invocations of a pmd during the test, since those inv= ocations are time consuming and, from what I measured, made up the majority of the runtime of the test. Is there a re= ason why all queues and port's can't be opened at the same time and= then ignored until they are needed? The way I re-did the configs was desig= ned to create all possible combinations of settings in the format that was originally=C2=A0there. Are all 3 invoca= tions of the pmd needed or is it possible to merge those and throw out my o= ther changes? Most of my changes were done because I was already planning o= n submitting=C2=A0a patch to remove the extra invocations and aren't as important.=C2=A0

Thanks for your help

Owen

=C2=A0

On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX <lihongx.ma@intel.com<= /a>> wrote:

Hi, Owen
I think the change of the plan is not make sense, the case ' PF interru= pt pmd with different queue' is want to test the interrupt on different= queue,
The original case will test the queue on min number, max number and normal = number(between minimum and maximum), but your patch will only test one situ= ation.


Regards,
Ma,lihong

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> Sent: Wednesday, August 26, 2020 11:04 PM
> To: dts@dpdk.org=
> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@= intel.com; Xiao,
> QimaiX <= qimaix.xiao@intel.com>; Hunt, David <david.hunt@intel.com>;
> lylavoie@iol= .unh.edu; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [dts] [PATCH] rx interrupt: Fixed test case
>
> fixed test case issues with eal params
> removed extra instances of l3fwd-power
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>=C2=A0 test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++-----------=
>=C2=A0 tests/TestSuite_interrupt_pmd.py=C2=A0 =C2=A0 =C2=A0 =C2=A0| 73 = ++++++++++++++------------
>=C2=A0 2 files changed, 64 insertions(+), 67 deletions(-)
>
> diff --git a/test_plans/interrupt_pmd_test_plan.rst
> b/test_plans/interrupt_pmd_test_plan.rst
> index cb8b2f1..1f8816d 100644
> --- a/test_plans/interrupt_pmd_test_plan.rst
> +++ b/test_plans/interrupt_pmd_test_plan.rst

--00000000000013159805af0f61c0--