test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: "Xu, HailinX" <hailinx.xu@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>, "Fu, Qi" <qi.fu@intel.com>
Subject: Re: [dts][PATCH 2/2] tests/cvl_rss_configure: modify the code
Date: Fri, 19 Nov 2021 10:44:47 -0500	[thread overview]
Message-ID: <CAHx6DYChrZPP0RXGbWCBfXcWcd=c7Fa1PVPP9aZ8RA3LU6=2Kw@mail.gmail.com> (raw)
In-Reply-To: <MW4PR11MB5912784AA18F11D570AB52469F9C9@MW4PR11MB5912.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hello Hailin,

I noticed this failed a lot of the checks in DTS CI, so since you are
already going to need to submit a V2, could you please add a short summary
of the changes and provide a reason for them in your V2 commit? This is a
lot of changes to make without a commit message body.

Owen Hilyard

[-- Attachment #2: Type: text/html, Size: 377 bytes --]

      reply	other threads:[~2021-11-19 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:10 [dts][PATCH 0/2] change test plan and test suite Hailin Xu
2021-11-19  5:01 ` Fu, Qi
2021-11-19  9:10 ` [dts][PATCH 1/2] test_plans/cvl_rss_configure: modify test plan Hailin Xu
2021-11-19  9:10 ` [dts][PATCH 2/2] tests/cvl_rss_configure: modify the code Hailin Xu
2021-11-19  2:56   ` Xu, HailinX
2021-11-19 15:44     ` Owen Hilyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHx6DYChrZPP0RXGbWCBfXcWcd=c7Fa1PVPP9aZ8RA3LU6=2Kw@mail.gmail.com' \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=hailinx.xu@intel.com \
    --cc=qi.fu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).