From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3C19A052B; Wed, 29 Jul 2020 13:31:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BE4937B7; Wed, 29 Jul 2020 13:31:24 +0200 (CEST) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by dpdk.org (Postfix) with ESMTP id 4008110A3 for ; Wed, 29 Jul 2020 13:31:22 +0200 (CEST) Received: by mail-ot1-f48.google.com with SMTP id q9so1577876oth.5 for ; Wed, 29 Jul 2020 04:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:from:date:message-id:subject:to:cc; bh=SuPWVOfAHgBvoiVGJlS2wHAKUDVm4as5GYCFNgbNfAI=; b=F08YTKS2b97PSwlQ0xQPZ4NyU13vMdFv/HY+gb2jAyxMbVm56q1kSoifS3RN92SnG0 gH4w5mGN2utKhIOB8q7rfK44STmTvwDPRaP7DSmyUotWoqRiloPZ18BL8bPY8Kz8l9pL n6no+sLA+3y3M0J8xQ8xFlfYI7E7oWyV2J6ps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=SuPWVOfAHgBvoiVGJlS2wHAKUDVm4as5GYCFNgbNfAI=; b=ScGWuLBoEB0CO060bOycpT4lYrHf/8tfKHaSS17f4RWTIechpWbrnkAPcEq9I/jjz0 forlWn9vXEwZncrJbG1ArXMOoYtNLKPe8/MIm9Q13QvZO+CG28sutrlYkmF9Djt4UEtE pv6ZDxEq97f17Hl4f5/EPR26azjXw/dcuQ3D0l5sFSLlD0KwtK74EPs1ZT8MXYvLzepy fq1jLfhpM0OYZDPXkthPlnGT67TA91XbnXxlzWRsBQ8y+awEM6wIQtgpVMcNY/viZC7q yz0KXCDRLLBTnGsH2Ux3kZMIULL6cV4YQEEaCDHSr6wkYorz5SDYWis9vQTe+CbXrkxM qkOA== X-Gm-Message-State: AOAM532mdgl+jIHKI0oqO3JUQKZjzwZcGo5OI2eHJWJLMjmJP/iYQ1Hr B8ciwSdESJYxRQ5xq9Meh3UNWk1Tya8Qjhcw3ZJBJUNX8DM= X-Google-Smtp-Source: ABdhPJy9W6iE+7I820mIjsxQTa2OW90FyTZIebNsuYv8plNfnrbpK0/DLHD/M7uzEpvlSJVo2hBcQScGZsTJ1jLGAaQ= X-Received: by 2002:a05:6830:1456:: with SMTP id w22mr27346490otp.117.1596022281307; Wed, 29 Jul 2020 04:31:21 -0700 (PDT) MIME-Version: 1.0 From: Owen Hilyard Date: Wed, 29 Jul 2020 07:30:44 -0400 Message-ID: To: dts@dpdk.org Cc: Lincoln Lavoie , David Liu , Daniel Kirichok , david.marchand@redhat.com Content-Type: multipart/alternative; boundary="00000000000021b62605ab92e52e" Subject: [dts] Question about the skip setup flag and a possible addition to bug 515 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --00000000000021b62605ab92e52e Content-Type: text/plain; charset="UTF-8" Hello all, During a recent internal meeting, we (the IOL team) were discussing bringing new test cases into the CI environment. We found that many of the test cases which recompile DPDK seem to break testpmd for all of the tests after them. As far as we can tell, this is because some of these tests leave testpmd in a location different than the default once they are compiled, resulting in the executable not being able to be found. We wanted to reach out and ask if the skip setup flag ('-s', '--skip-setup') was intended to stop recompilation of dpdk during the time that test cases are running. If it is, then it seems many of the tests which recompile dpdk do not follow this convention, and if it is not then those test cases might need to be fixed. It is also possible that there is a misconfiguration or misunderstanding of the root cause on our side. If it is not one of those cases and this is both behavior that is expected given proper configuration but not behavior which is desired, then I think I have a relatively painless solution. This solution would be to add a check for the flag in the build_install_dpdk function and, if it is present, assumes that everything is compiled correctly and exits the function early. This would only involve adding a few lines for the check and then whatever is required to access the flags deeper into dts. Where this becomes a possible addition to bug 515 , is that doing this could break many of the tests which edit dpdk source directly, since the compilation they expect would not occur. As such, this would either need to be its own bug to be fixed after 515, or tacked on to 515. --00000000000021b62605ab92e52e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,

During a recent internal mee= ting, we (the IOL team) were discussing bringing new test cases into the CI= environment. We found that many of the test cases which recompile DPDK see= m to break testpmd for all of the tests after them. As far as we can tell, = this is because some of these tests leave testpmd in a location different t= han the default once they are compiled, resulting in the executable not bei= ng able to be found. We wanted to reach out and ask if the skip setup flag = ('-s', '--skip-setup') was intended to stop recompilation o= f dpdk during the time that test cases are running. If it is, then it seems= many of the tests which recompile dpdk do not follow this convention, and = if it is not then those test cases might need to be fixed. It is also possi= ble that there is a misconfiguration or misunderstanding of the root cause = on our side. If it is not one of those cases and this is both behavior that= is expected given proper configuration but not behavior which is desired, = then I think I have a relatively painless solution. This=C2=A0solution woul= d be to add a check for the flag in the build_install_dpdk function and, if= it is present, assumes that everything is compiled correctly and exits the= function early. This would only involve adding a few lines for the check a= nd then whatever is required to access the flags deeper into dts.

W= here this becomes a possible addition to=C2=A0bug 515, is that doing this could break many= of the tests which edit dpdk source directly, since the compilation they e= xpect would not occur. As such, this would either need to be its own bug to= be fixed after 515, or tacked on to 515.=C2=A0
--00000000000021b62605ab92e52e--