test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bo Chen <BoX.C.Chen@intel.com>
Cc: dts@dpdk.org, techboard@dpdk.org, dev <dev@dpdk.org>,
	"Qi Zhang" <qi.z.zhang@intel.com>,
	"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
	"Aaron Conole" <aconole@redhat.com>
Subject: Re: [dts] [PATCH V1] tests/generic_filter: use flow api replace legancy
Date: Wed, 26 May 2021 13:17:22 +0200	[thread overview]
Message-ID: <CAJFAV8wnqZtDTcf7MASPNd-EUQ5ghB57WFR0-LweoSGW=PBmtg@mail.gmail.com> (raw)
In-Reply-To: <20210506151015.418101-1-BoX.C.Chen@intel.com>

On Thu, May 6, 2021 at 9:08 AM Bo Chen <BoX.C.Chen@intel.com> wrote:
>
> use flow api replace legancy filter command
>
> Signed-off-by: Bo Chen <BoX.C.Chen@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 41 ++++++++++++++++++-------------
>  1 file changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
> index d4ea8926..f3ea9774 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -119,6 +119,12 @@ class TestGeneric_filter(TestCase):
>          """
>          Run before each test case.
>          """
> +        if self._suite_result.test_case == "test_128_queues":
> +            print('will rebuild dpdk')
> +            self.dut.send_expect(
> +                "sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h",

Patching dpdk to pass a test means there is something wrong either in
dpdk or in the test.


-- 
David Marchand


  parent reply	other threads:[~2021-05-26 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 15:10 Bo Chen
2021-05-06  7:14 ` Chen, BoX C
2021-05-26  6:13 ` Tu, Lijuan
2021-05-26 11:17 ` David Marchand [this message]
2021-05-27  2:14   ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wnqZtDTcf7MASPNd-EUQ5ghB57WFR0-LweoSGW=PBmtg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=BoX.C.Chen@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dts@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=qi.z.zhang@intel.com \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).