test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Patrick Robb <probb@iol.unh.edu>, Manit Mahajan <mmahajan@iol.unh.edu>
Cc: dts@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common
Date: Tue, 15 Jul 2025 09:42:16 +0200	[thread overview]
Message-ID: <CAJFAV8xM12ZxFSsrRa3Ve=momUN64m+knTnqOwtfmXugqNzaYw@mail.gmail.com> (raw)
In-Reply-To: <CAJvnSUA0zLhrWuFeTM+5X6xEs4oDCibDq+CUyshQcCVxRsR2rg@mail.gmail.com>

Hello,

On Fri, Jul 11, 2025 at 11:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> This seems fine in principle.
>
> Did you ever figure out why the compressdev_autotest was failing with coremask used in the first place? I haven't looked at the coremask deprecation patch that you had found, but David said on slack that it didn't remove the option to use the coremask EAL arg, it just discourages it with a warning.
>
> On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
>>
>> The compress_common.py script previously used the --coremask parameter,
>> which has been removed from DPDK. As a result, zlib_pmd test cases
>> fail when invoking this script. This patch updates the script to

There is no --coremask EAL option.
And the option -c was not removed.

Please refine the rca.

>> use the --corelist parameter instead, which is the more common
>> way to specify core assignment in DPDK.

There is no --corelist EAL option.

Only -c, -l and --lcores exist atm.


-- 
David Marchand


      reply	other threads:[~2025-07-15  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250711203030.10147-1-mmahajan@iol.unh.edu>
2025-07-11 21:30 ` Patrick Robb
2025-07-15  7:42   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xM12ZxFSsrRa3Ve=momUN64m+knTnqOwtfmXugqNzaYw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=mmahajan@iol.unh.edu \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).