Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

This seems fine in principle.

Did you ever figure out why the compressdev_autotest was failing with
coremask used in the first place? I haven't looked at the coremask
deprecation patch that you had found, but David said on slack that it
didn't remove the option to use the coremask EAL arg, it just discourages
it with a warning.

On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:

> The compress_common.py script previously used the --coremask parameter,
> which has been removed from DPDK. As a result, zlib_pmd test cases
> fail when invoking this script. This patch updates the script to
> use the --corelist parameter instead, which is the more common
> way to specify core assignment in DPDK.
>
> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
> ---
>  tests/compress_common.py | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/compress_common.py b/tests/compress_common.py
> index aa591270..22ce4b74 100644
> --- a/tests/compress_common.py
> +++ b/tests/compress_common.py
> @@ -94,12 +94,14 @@ def get_input_file(test_case):
>
>  def run_unit(test_case, eal={}):
>      cores = test_case.dut.get_core_list("1S/3C/1T")
> -    core_mask = utils.create_mask(cores)
> +    core_list = []
> +    for core in cores:
> +        core_list.append(str(core))
> +    core_str = ",".join(core_list)
>      mem_channels = test_case.dut.get_memory_channels()
>
>      default = default_eals.copy()
> -    default["l"] = None
> -    default["c"] = core_mask
> +    default["l"] = core_str
>      default["n"] = mem_channels
>
>      eal_str = get_opt_str(test_case, default, eal)
> --
> 2.41.0
>
>

[-- Attachment #2: Type: text/html, Size: 2273 bytes --]

Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[David Marchand]

Hello,

On Fri, Jul 11, 2025 at 11:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> This seems fine in principle.
>
> Did you ever figure out why the compressdev_autotest was failing with coremask used in the first place? I haven't looked at the coremask deprecation patch that you had found, but David said on slack that it didn't remove the option to use the coremask EAL arg, it just discourages it with a warning.
>
> On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
>>
>> The compress_common.py script previously used the --coremask parameter,
>> which has been removed from DPDK. As a result, zlib_pmd test cases
>> fail when invoking this script. This patch updates the script to

There is no --coremask EAL option.
And the option -c was not removed.

Please refine the rca.

>> use the --corelist parameter instead, which is the more common
>> way to specify core assignment in DPDK.

There is no --corelist EAL option.

Only -c, -l and --lcores exist atm.


-- 
David Marchand