test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: dts@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf.py Improving lscpu parsing
Date: Mon, 16 Sep 2024 09:16:50 +0200	[thread overview]
Message-ID: <CAJFAV8yZxrB0=tu-Lu3XJw+R12odBXVXa=yi3XUrrVLjoTuhaA@mail.gmail.com> (raw)
In-Reply-To: <20240916042631.186816-1-probb@iol.unh.edu>

On Mon, Sep 16, 2024 at 6:27 AM Patrick Robb <probb@iol.unh.edu> wrote:
>
> This testsuite fails to parse lscpu output on some systems because
> it expects that there be no leading whitespace, which is not
> true on all systems.

The leading whitespace is a generic issue, not really related to "some" systems.
The issue is that keys of interest for the rest of the code ('Core(s)
per socket', 'Socket(s)', 'CPU(s)') may have leading whitespace on
some systems.

Could you detail which systems have such issue?

In any case, this fix makes sense to me and it seems limited and safe
enough to merge the patch in the "legacy" repository for dts.


>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2024-09-16  7:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  4:26 Patrick Robb
2024-09-16  7:16 ` David Marchand [this message]
2024-09-17  3:36   ` Patrick Robb
2024-09-18  7:01     ` David Marchand
2024-09-18  7:16   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8yZxrB0=tu-Lu3XJw+R12odBXVXa=yi3XUrrVLjoTuhaA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=dts@dpdk.org \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).