test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing
@ 2024-09-16  9:25 David Marchand
  2024-09-17 21:19 ` Patrick Robb
  2024-09-18  7:17 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: David Marchand @ 2024-09-16  9:25 UTC (permalink / raw)
  To: dts; +Cc: probb

The parsing of the test results was considering too many lines.

It was not an issue as the extra inspected line was an empty line.
Following fixes on the qat driver logs, this triggers a parsing error.

Fixes: a3c915c1a3b9 ("tests/crypto_perf_cryptodev_perf: optimize parse output")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tests/TestSuite_crypto_perf_cryptodev_perf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py b/tests/TestSuite_crypto_perf_cryptodev_perf.py
index 0531b9c6..633dd637 100644
--- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
+++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
@@ -252,7 +252,7 @@ class TestCryptoPerfCryptodevPerf(TestCase):
                 if lines[line_index].startswith("    lcore id"):
                     self.logger.debug("data output line from: " + str(line_index))
                     break
-            data_line = line_index - 2
+            data_line = line_index - 1
 
             results = []
             pattern = re.compile(r"\s+")
-- 
2.46.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing
  2024-09-16  9:25 [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing David Marchand
@ 2024-09-17 21:19 ` Patrick Robb
  2024-09-18  7:17 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick Robb @ 2024-09-17 21:19 UTC (permalink / raw)
  To: David Marchand; +Cc: dts

Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Tested-by: Patrick Robb <probb@iol.unh.edu>

Did a non-regression test against origin/main, and tested with
https://patchwork.dpdk.org/project/dpdk/list/?series=33005, which is
the series which prompted this DTS patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing
  2024-09-16  9:25 [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing David Marchand
  2024-09-17 21:19 ` Patrick Robb
@ 2024-09-18  7:17 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-09-18  7:17 UTC (permalink / raw)
  To: David Marchand; +Cc: dts, probb, Thomas Monjalon, Aaron Conole

On Mon, Sep 16, 2024 at 11:25 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> The parsing of the test results was considering too many lines.
>
> It was not an issue as the extra inspected line was an empty line.
> Following fixes on the qat driver logs, this triggers a parsing error.
>
> Fixes: a3c915c1a3b9 ("tests/crypto_perf_cryptodev_perf: optimize parse output")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Tested-by: Patrick Robb <probb@iol.unh.edu>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-18  7:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-16  9:25 [PATCH] tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing David Marchand
2024-09-17 21:19 ` Patrick Robb
2024-09-18  7:17 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).