From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA42945C28; Thu, 31 Oct 2024 23:17:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EC094028A; Thu, 31 Oct 2024 23:17:26 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 2550840264 for ; Thu, 31 Oct 2024 23:17:24 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7edb6879196so1041158a12.3 for ; Thu, 31 Oct 2024 15:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730413043; x=1731017843; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=11GGXq95cVGWwejb1JhxfynQcQMWlCktqD7e+tik5ww=; b=Xe1+rNhaKaVXhqaUkPbQWevlJHujOZABcwd7M8KkMFpLnB5nlIK0F12ORiP5NTSX7w 7LM8kkaJhpNhKDDfDpkx/igEg745tpPTTRdH/rhVsymtDsskd6BSKCa+8L1UtHaSVajI SRvFfmtmVs40zBZOSHoXAOcI+6DJPMUhbf64U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730413043; x=1731017843; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=11GGXq95cVGWwejb1JhxfynQcQMWlCktqD7e+tik5ww=; b=cCbq9kpOLa66wjc6fDofhTxn9bK2iUPnvCIQWAuY1UMNGhBt0X/IPwujy0nDMznB35 odWCUzohGUNCPnIyqcZ4uZ5rQH7RVlD+RXagC27h/KQZu5FHGAFtve8be2oS+yRufljQ HNgBT15ZNCewHpZO0XW3hN2fcvxzKA3upUGM0CzyTyLRqfQ7T944/1AWEMZYeafRN5yJ WUMIPfL14qm33AJtzxVA25rj2gVdHkLIJ2D8/rilDhFOBB1XTb84xWakoZVQx5tCkDgT FEBkLO3mAoj5xokd+1oJeH4kvffpB/Pbmcfas8m9DZ2N8UokdYnUjtK05UJJDqcwcqLI 6wiw== X-Gm-Message-State: AOJu0YxTFayArc+QTyoF/BEG810ClLPIHBhcWJRNXtq6fz86YZ8zBIdO S50e+/kQtIQznRe4h/vr9UDu9rooWuAvTtMFDN+TtvZ0wN+eorOVE8HlDNPlHtmC3xnolW2M396 whAkoh+vh1ahhU9Q0KiCc3ct8Okc5OcJswopFgw== X-Google-Smtp-Source: AGHT+IFYM07lCstgAj4TqbPy19wzQVTEBjz2MxR2JZWfKxLzTPUUoSYX6HnUKc9QOE3dxc7iyIH5mJiHrVhueX9GE4w= X-Received: by 2002:a17:90b:3848:b0:2e0:5748:6ea1 with SMTP id 98e67ed59e1d1-2e8f11dcec5mr22857303a91.37.1730413042911; Thu, 31 Oct 2024 15:17:22 -0700 (PDT) MIME-Version: 1.0 References: <20241030164419.3164992-1-gpalanethra@marvell.com> In-Reply-To: <20241030164419.3164992-1-gpalanethra@marvell.com> From: Patrick Robb Date: Thu, 31 Oct 2024 18:15:40 -0400 Message-ID: Subject: Re: [PATCH 1/1] Cn10K crypto Tests: Added Marvell Cn10K specific crypto Tests to TestCryptoPerfCryptodevPerf To: Gnanesh Cc: dts@dpdk.org, njogarao@marvell.com, brajendra@marvell.com, Cody Cheng , Hiral Shah , Jerin Jacob Kollanukkaran Content-Type: multipart/alternative; boundary="000000000000bce4530625cd2e92" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --000000000000bce4530625cd2e92 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gnanesh, thanks for sending this. My name is Patrick Robb, and I'm a CI Testing Lab manager at the DPDK Community Lab hosted at UNH, and a maintainer for the "new" DTS framework which exists within the DPDK repo and should be replacing the legacy DTS project in the long term(what this patch is for). We do have a Marvell CN10K board at the lab, and I would love to begin running some crypto testing from that if possible (so, thanks again for this series). So, most likely we will want to provide a review from UNH and test this, so that it can be merged to DTS (technically I was granted the authority to apply patches to the legacy repo). I am adding Cody to this thread as I think he can assist me on this. Cody I am going to provide some comments inline as an initial review for this series, and then we should apply this series locally on the traffic generator/test engine for the CN10K (Intel-1 in our lab), dry run the test which Gnanesh has added, and report back to him. If all goes well, it should be possible to merge. Long term, we will want to circle back and add this test to the new DTS framework, but it is not ready for this test yet, as currently new DTS is testpmd only - there is not cryptodev support. Although, adding such support to new DTS is something I would love to work with you on in the next year if you have time available for development towards DPDK testing! Anyways, comments inline: On Wed, Oct 30, 2024 at 12:44=E2=80=AFPM Gnanesh = wrote: > Changes included in this patch: > -- New TestCases are added for Cn10K CPT Hardware crypto accelerator. > -- when Testing newly added Testcases it is found Necessary to make > Below Changes > 1> tests/cryptodev_common.py > --> bind_qat_device function is updated to generate VFs fo= r > the given crypto_dev_id > --> added New function bind_mrvl_devices to accept list of > PCI Ids and bind it to vfio_pci driver. > 2> framework/crb.py > --> updated pci_devices_information_uncached_linux Method > to handle additional Nic Speeds for Cavium, > as it was restricting only to 1 GIG NIC speed > Thanks, I also made this change on our local DTS project for cn10k, but the patch was not submitted to the "legacy DTS" mailing list here as it was unmaintained (and still is, to David's point). But, if we can do a review it is good to get these things into mainline. Maybe I can rebase our local patch on yours if there were any other changes, and get feedback for cn10k specific questions. I have a hard time understanding how this 10G NIC speed requirement got added in the first place as it was quite peculiar and confused me for a time as it was dropping the ports list! I'm sure you had a similar experience... :) > 3> framework/settings.py > --> Changed the default Cavium NIC driver to rvu_nicpf. > Thanks, we are also running from this change at the Community Lab. But, I thought you said above you are creating VFs from the bind_qat_device function. So, does rvu_nicvf need to be added as well? > 4> nics/net_device.py > --> added Missing expect object > 5> conf/crypto_perf_cryptodev_perf.cfg > --> added Marvell Cn10K configs for > crypto_perf_cryptodev_perf > 6> framework/ssh_pexpect.py > --> output.replace command's output is not set before > returning from get_output_all method > hence Unnecessarily returning Prompt along with the > output > 7> tests/TestSuite_crypto_perf_cryptodev_perf.py > --> added Marvell CN10K Testcases > Again we will apply these, give them a run, and report back. > Updated Below Private functions > 6.1> _run_crypto_perf() --> receives additional KW > arguments > 6.2> _parse_output() ---> Updated to handle Marvell Cn10= K > app command output > 6.3> _run_crypto_perf_throughput() --> receives additiona= l > KW arguments > I don't see any modifications for the build process. Is there a need to include "-Dplatform=3Dcn10k" when setting up the build from meson, or is th= e default build fine? > > > Signed-off-by: Gnanesh > --- > conf/crypto_perf_cryptodev_perf.cfg | 849 ++++++++++++++++++ > framework/crb.py | 6 +- > framework/settings.py | 4 +- > framework/ssh_pexpect.py | 2 +- > nics/net_device.py | 3 + > tests/TestSuite_crypto_perf_cryptodev_perf.py | 322 ++++++- > tests/cryptodev_common.py | 11 +- > 7 files changed, 1172 insertions(+), 25 deletions(-) > > diff --git a/framework/crb.py b/framework/crb.py > index 9e3b0a58..2fe9d147 100644 > --- a/framework/crb.py > +++ b/framework/crb.py > @@ -374,15 +374,15 @@ class Crb(object): > pass > > for i in range(len(match)): > - # check if device is cavium and check its linkspeed, append > only if it is 10G > + # for cavium supported link speed specfied under linkspeeds > if "177d:" in match[i][1]: > - linkspeed =3D "10000" > + linkspeeds =3D ["40000", "10000", "25000", "50000", > "100000"] > Honestly I don't understand why we have this condition at all. Other devices in DTS do not have this check where the portlinks can be dropped in crbs.py. What do you think about updating the accepted linkspeeds vs just removing this step entirely? Can we expect additional linkspeeds to be added for 177d in the future, and have this problem crop up again for a new linkspeed, or is this list of speeds "final" for 177d? > nic_linkspeed =3D self.send_expect( > "cat /sys/bus/pci/devices/%s/net/*/speed" % > match[i][0], > "# ", > alt_session=3DTrue, > ) > - if nic_linkspeed.split()[0] =3D=3D linkspeed: > + if nic_linkspeed.split()[0] in linkspeeds: > self.pci_devices_info.append((match[i][0], > match[i][1])) > else: > self.pci_devices_info.append((match[i][0], match[i][1])) > diff --git a/framework/settings.py b/framework/settings.py > index 1a561dda..b2c371f8 100644 > --- a/framework/settings.py > +++ b/framework/settings.py > @@ -166,8 +166,8 @@ DRIVERS =3D { > "cavium_a034": "thunder-nicvf", > "cavium_0011": "thunder-nicvf", > "IXGBE_10G-X550EM_X_SFP": "ixgbe", > - "cavium_a063": "octeontx2-nicpf", > - "cavium_a064": "octeontx2-nicvf", > + "cavium_a063": "rvu_nicpf", > + "cavium_a064": "rvu_nicvf", > Okay disregard my comment from above about nicvf, I see you've added it. Please do update the commit message to reflect that this is included. And, while you're at it, you can update the commit message to accord with the style guidelines for submitting DPDK patches as seen here on sections 9.6 and 9.7 https://doc.dpdk.org/guides/contributing/patches.html :) "ICE_100G-E810C_QSFP": "ice", > "ICE_25G-E810C_SFP": "ice", > "ICE_25G-E823C_QSFP": "ice", > diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py > index 2132c066..a96087d2 100644 > --- a/framework/ssh_pexpect.py > +++ b/framework/ssh_pexpect.py > @@ -186,7 +186,7 @@ class SSHPexpect: > > def get_output_all(self): > output =3D self.session.before > - output.replace("[PEXPECT]", "") > + output =3D output.replace("[PEXPECT]#", "") > So, this is just removing the leading "#" from the output? I'm not sure we should be making styling changes for a "deprecated" repository. If I look at this example output, from one of the CI runs of this testsuite on a quickassist card: # Device 1 on lcore 40 # total operations: 30000000 # Buffer size: 1024 # Burst size: 32 # Number of bursts: 937500 # # Total Average Maximum Minimum # enqueued 30000000 32 32 32 # dequeued 30000000 32 32 1 # cycles 91892876610 3063 304625 485 # time [us] 3675715064 122.520 12185.000 19.400 I imagine the DTS maintainers were aware of this and thought it was the most clear way to print the logs. I don't think we need to override that decision now. > return output > > def close(self, force=3DFalse): > diff --git a/nics/net_device.py b/nics/net_device.py > index 0f9c1af4..dd0d0e92 100644 > --- a/nics/net_device.py > +++ b/nics/net_device.py > @@ -43,6 +43,7 @@ class NetDevice(object): > if not isinstance(crb, Crb): > raise Exception(" Please input the instance of Crb!!!") > self.crb =3D crb > + self.__send_expect =3D self.crb.send_expect > self.domain_id =3D domain_id > self.bus_id =3D bus_id > self.devfun_id =3D devfun_id > @@ -727,6 +728,8 @@ class NetDevice(object): > "/sys/bus/pci/devices/%s:%s:%s" % (domain_id, bus_id, > devfun_id), > vf_reg_file, > ) > + self.__send_expect("echo 0 > %s" % > + (vf_reg_path), "# ") > So, the pre-existing VFs need to be destroyed before a new set of VFs can be created? Do you know if this is Marvell specific, or a universal behavior? > self.__send_expect("echo %d > %s" % (int(vf_num), vf_reg_path), > "# ") > > def generate_sriov_vfs_linux_igb_uio(self, domain_id, bus_id, > devfun_id, vf_num): > diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py > b/tests/TestSuite_crypto_perf_cryptodev_perf.py > index a3f48eee..b435cefa 100644 > --- a/tests/TestSuite_crypto_perf_cryptodev_perf.py > +++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py > @@ -59,14 +59,74 @@ class TestCryptoPerfCryptodevPerf(TestCase): > "# ", > 5, > ) > - > - cc.bind_qat_device(self, "vfio-pci") > + if self.nic =3D=3D "cavium_a063": > + count =3D len(self.get_suite_cfg().get('l').split(",")) - 1 > + cc.bind_qat_device(self, "vfio-pci", generate_vfs=3DTrue, > vf_count=3Dcount) > + else: > + cc.bind_qat_device(self, "vfio-pci") > If we are going to use this function for non-QAT devices, can we please update the function name to prevent confusion? It looks like it's a short list: probb@d121003:~/repos/dts> grep -r "bind_qat_d" . ./tests/TestSuite_compressdev_qat_pmd.py: cc.bind_qat_device(self, self.drivername) ./tests/TestSuite_crypto_perf_cryptodev_perf.py: cc.bind_qat_device(self, "vfio-pci") ./tests/TestSuite_fips_cryptodev.py: cc.bind_qat_device(self, "vfio-pci") ./tests/TestSuite_ipsec_gw_cryptodev_func.py: cc.bind_qat_device(self, self.drivername) ./tests/TestSuite_l2fwd_cryptodev_func.py: cc.bind_qat_device(self, self.drivername) ./tests/TestSuite_virtio_ipsec_cryptodev_func.py: cc.bind_qat_device(self, self.drivername) ./tests/TestSuite_virtio_perf_cryptodev_func.py: cc.bind_qat_device(self, self.drivername) ./tests/TestSuite_virtio_unit_cryptodev_func.py: cc.bind_qat_device(self, self.drivername) ./tests/compress_common.py:def bind_qat_device(test_case, driver=3D"igb_uio= "): ./tests/cryptodev_common.py:def bind_qat_device(test_case, driver=3D"igb_uio"): > src_files =3D ["dep/test_aes_cbc.data", "dep/test_aes_gcm.data"] > self.dut_file_dir =3D "/tmp" > for file in src_files: > self.dut.session.copy_file_to(file, self.dut_file_dir) > > def tear_down_all(self): > + if self.nic =3D=3D "cavium_a063": > + cc.bind_qat_device(self, "vfio-pci", generate_vfs=3DTrue, > + vf_count=3D2) > + import pandas as pd > I don't have a problem with this, but I'm just wondering why this is imported here as opposed to the top of the file? > + tuples =3D [('TestCase',), ('performance', 'failed_enq'), > + ('performance', 'failed_deq'), > + ('performance', 'throughput_mops'), > + ('performance', 'cycle_buf'), > + ('performance', 'throughput', 'value'), > + ('performance', 'throughput', 'delta'), > + ('parameters', 'core_num/thread_num'), > + ('parameters', 'frame_size'), > + ('parameters', 'burst_size'), > + ('parameters', 'total_ops'), ('status',)] > + mindex =3D pd.MultiIndex.from_tuples(tuples) > + index =3D 0 > + df =3D pd.DataFrame([], columns=3Dmindex) > + for tname, data in self._perf_result.items(): > + for dt in data: > + for key, value in dt.items(): > + df.loc[index, 'TestCase'] =3D tname > + if key =3D=3D 'status': > + df.loc[index, (key)] =3D value > + continue > + for item in value: > + if item['name'] =3D=3D 'throughput': > + df.loc[index, (key, item['name'], > 'value')] =3D item['value'] > + df.loc[index, (key, item['name'], > 'delta')] =3D item['delta'] > + else: > + df.loc[index, (key, item['name'])] =3D > item['value'] > + index +=3D 1 > + perf_xl =3D self.logger.log_path + "/" + > "perf_cryptodev_result.xls" > + writer =3D pd.ExcelWriter(perf_xl, engine=3D'xlsxwriter') > + wb =3D writer.book > + df.to_excel(writer, sheet_name=3D'Sheet1') > + ws =3D writer.sheets["Sheet1"] > + merge_format =3D wb.add_format({"bold": 1,"border": 1,"align= ": > "center", > + "valign": "vcenter"}) > + ws.merge_range('B1:B3', "TestCase", merge_format) > + ws.merge_range('C2:C3', "failed_enq", merge_format) > + ws.merge_range('D2:D3', "failed_deq", merge_format) > + ws.merge_range('E2:E3', "throughput_mops", merge_format) > + ws.merge_range('F2:F3', "throughput_mops", merge_format) > + ws.merge_range('I2:I3', "core_num/thread_num", merge_format) > + ws.merge_range('J2:J3', "frame_size", merge_format) > + ws.merge_range('K2:K3', "burst_size", merge_format) > + ws.merge_range('L2:L3', "total_ops", merge_format) > + ws.merge_range('M1:M3', "status", merge_format) > + > + format1 =3D wb.add_format({"bg_color": "#C6EFCE", "font_colo= r": > "#006100", "border": 1}) > + format2 =3D wb.add_format({"bg_color": "#FFC7CE", "font_colo= r": > "#9C0006"}) > + ws.conditional_format("B1:M3", {"type": "cell", "criteria": > ">=3D", "value": 0 , 'format': format2}) > + condition =3D 'B5:M%s'%(5+len(df)-1) > + ws.conditional_format(condition, {'type': 'no_blanks', > 'format':format1}) > + ws.autofit() > + > + wb.close() > if self._perf_result: > with open( > self.logger.log_path + "/" + > "perf_cryptodev_result.json", "a" > @@ -175,12 +235,197 @@ class TestCryptoPerfCryptodevPerf(TestCase): > def test_scheduler_zuc(self): > self._run_crypto_perf_throughput() > > + # Marvell CN10K Testcases > + def _crypto_func_cn10k(self): > + """Functional tests Helper > + Returns: > + None > + """ > + self._run_crypto_func() > + > + def _crypto_perf_cn10k(self): > + """Perf tests Helper function > + Returns: > + None > + """ > + self._run_crypto_perf_throughput(expected=3D"# ", > + trim_whitespace=3DFalse) > + def test_perf_mrvl_aes_cbc(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_gcm_encrypt(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_cbc_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_sha2_256_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_zuc_eea3_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_zuc_eia3_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_gmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_null_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_snow3g_uea2_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_kasumi_f8_cipher_only(self): > + self._crypto_perf_cn10k() #F > + > + def test_perf_mrvl_snow3g_uia2_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_kasumi_f9_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha1_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha1_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_snow_3g_uia2_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_cmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_3des_cbc_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha1_hmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_224_hmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_256_hmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_384_hmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_snow_3g_uia2_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_zuc_eia3_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_aes_cmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_zuc_eea3_snow3g_uia2_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_zuc_eea3_zuc_eia3_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_zuc_eea3_aes_cmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_snow3g_uea2_snow3g_uia2_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_snow3g_uea2_zuc_eia3_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_snow3g_uea2_aes_cmac_cipher_then_auth(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_md5_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_ctr_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_3des_cbc_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_224_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_256_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_384_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_512_hmac_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_aes_xts__cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_des_cbc_cipher_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_md5_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha512_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha384_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha256_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha224_auth_only(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_snow3g_uea2_snow3g_uia2(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha1_hmac_armv8(self): > + self._crypto_perf_cn10k() > + > + def test_perf_mrvl_sha2_hmac_armv8(self): > + self._crypto_perf_cn10k() > + > + def test_mrvl_ptest(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_burst(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_devtype(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_crypto_sha1_hmac_armv8(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_chacha20_poly1305_aead(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_crypto_sha2_hmac_armv8(self): > + self._crypto_func_cn10k() > + > + def test_mrvl_buffer(self): > + self._crypto_func_cn10k() > + > # Private functions > def _run_crypto_func(self): > + """ Runs Crypto functional test. > + Returns: > + None > + """ > + > if cc.is_test_skip(self): > return > - > - cores =3D ",".join(self.dut.get_core_list("1S/2C/1T")) > + core_list =3D self.get_suite_cfg().get('core_list',"1S/2C/1T") > + cores =3D ",".join(self.dut.get_core_list(core_list)) > config =3D {"l": cores} > devices =3D self._get_crypto_device(1) > if not devices: > @@ -206,12 +451,22 @@ class TestCryptoPerfCryptodevPerf(TestCase): > > out =3D self.dut.send_command( > "cat %s/%s.txt" % (self.dut_file_dir, self.running_case), 30 > - ) > - > + ).strip() > self.verify("Error" not in out, "Test function failed") > self.verify("failed" not in out, "Test function failed") > - > - def _run_crypto_perf(self): > + assert (out !=3D ""), "No output" > + > + def _run_crypto_perf(self, **kwargs): > + """ Runs Crypto Performance test. > + Args: > + **kwargs: > + expected: send_expect match prompt > + trim_whitespace: trime whitespace from command output > + Returns: > + None > + """ > + expected =3D kwargs.get("expected", "#") > + trim_whitespace =3D kwargs.get("trim_whitespace", True) > if cc.is_test_skip(self): > return "skip" > > @@ -222,13 +477,14 @@ class TestCryptoPerfCryptodevPerf(TestCase): > return "skip" > > eal_opt_str =3D cc.get_eal_opt_str(self, devices) > - crypto_perf_opt_str =3D self._get_crypto_perf_opt_str() > + crypto_perf_opt_str =3D self._get_crypto_perf_opt_str(**kwargs) > > cmd_str =3D cc.get_dpdk_app_cmd_str( > self._app_path, eal_opt_str, crypto_perf_opt_str > ) > try: > - out =3D self.dut.send_expect(cmd_str, "#", 600) > + out =3D self.dut.send_expect(cmd_str, expected, 600, > + trim_whitespace=3Dtrim_whitespace= ) > except Exception as ex: > self.logger.error(ex) > raise ex > @@ -237,25 +493,44 @@ class TestCryptoPerfCryptodevPerf(TestCase): > > return results > > - def _get_crypto_perf_opt_str(self, override_crypto_perf_opts=3D{}): > + def _get_crypto_perf_opt_str(self, **kwargs): > + """get crypto perf app option string > + args: > + **kwargs: > + override_crypto_perf_opts- Suite/Case specfic perf > + app config to overwrite defaults > + Returns: > + crypto perf option string > + """ > + override_crypto_perf_opts =3D > kwargs.get("override_crypto_perf_opts", {}) > return cc.get_opt_str( > self, self._default_crypto_perf_opts, > override_crypto_perf_opts > ) > > def _parse_output(self, output): > try: > + dtype =3D self.get_case_cfg().get('devtype') > + match_str =3D r" lcore id|#lcore id" > lines =3D output.split("\r\n") > line_nb =3D len(lines) > self.logger.debug("Total output lines: " + str(line_nb)) > > for line_index in range(line_nb): > - if lines[line_index].startswith(" lcore id"): > + if re.match(match_str, lines[line_index]): > self.logger.debug("data output line from: " + > str(line_index)) > break > - data_line =3D line_index - 1 > + if dtype =3D=3D 'crypto_cn10k': > + data_line =3D line_index + 2 > + else: > + data_line =3D line_index - 1 > + > + if len(lines[data_line].split(","))>1: > + pattern =3D re.compile(r',') > + else: > + pattern =3D re.compile(r'\s+') > > results =3D [] > - pattern =3D re.compile(r"\s+") > + > for line in lines[data_line:-1]: > print(line) > result =3D {} > @@ -334,9 +609,15 @@ class TestCryptoPerfCryptodevPerf(TestCase): > cpu_info[key] =3D value.strip() > core, thread =3D 0, 0 > lcores =3D self.get_case_cfg()["l"].split(",") > + if 'Core(s) per cluster' in out: > + cl_soc1 =3D 'Core(s) per cluster' > + cl_soc2 =3D 'Cluster(s)' > + else: > + cl_soc1 =3D 'Core(s) per socket' > + cl_soc2 =3D 'Socket(s)' > for lcore in lcores[1:]: > - if int(lcore.strip()) < int(cpu_info["Core(s) per socket"]) = * > int( > - cpu_info["Socket(s)"] > + if int(lcore.strip()) < int(cpu_info[cl_soc1]) * int( > + cpu_info[cl_soc2] > ): > core +=3D 1 > thread +=3D 1 > @@ -362,6 +643,11 @@ class TestCryptoPerfCryptodevPerf(TestCase): > dev =3D "crypto_snow3g" > elif self.get_case_cfg()["devtype"] =3D=3D "crypto_zuc": > dev =3D "crypto_zuc" > + elif self.get_case_cfg()["devtype"] =3D=3D "crypto_cn10k": > + dev =3D "crypto_cn10k" > + vf =3D cc.get_qat_devices(self, cpm_num=3D1, num=3Dnum) > + device["a"] =3D ' -a '.join(vf) > + device["vdev"] =3D None > elif self.get_case_cfg()["devtype"] =3D=3D "crypto_scheduler": > dev =3D "crypto_scheduler" > w =3D cc.get_qat_devices(self, cpm_num=3D3, num=3Dnum * 3) > @@ -388,8 +674,8 @@ class TestCryptoPerfCryptodevPerf(TestCase): > > return device > > - def _run_crypto_perf_throughput(self): > - results =3D self._run_crypto_perf() > + def _run_crypto_perf_throughput(self, **kwargs): > + results =3D self._run_crypto_perf(**kwargs) > if results =3D=3D "skip": > return > self.verify(results, "test results is none, Test Failed") > diff --git a/tests/cryptodev_common.py b/tests/cryptodev_common.py > index b550b468..91067b05 100644 > --- a/tests/cryptodev_common.py > +++ b/tests/cryptodev_common.py > @@ -8,7 +8,9 @@ from nics.net_device import GetNicObj > conf =3D SuiteConf("cryptodev_sample") > > > -def bind_qat_device(test_case, driver=3D"igb_uio"): > +def bind_qat_device(test_case, driver=3D"igb_uio", generate_vfs=3DFalse, > + vf_count=3D2, drvr_type=3D'generic'): > + > if driver =3D=3D "vfio-pci": > test_case.dut.send_expect("modprobe vfio", "#", 10) > test_case.dut.send_expect("modprobe vfio-pci", "#", 10) > @@ -38,6 +40,8 @@ def bind_qat_device(test_case, driver=3D"igb_uio"): > devfun_id =3D addr_array[2] > pf_port =3D GetNicObj(test_case.dut, domain_id, bus_id, devfun_i= d) > > + if generate_vfs: > + pf_port.generate_sriov_vfs_linux(domain_id, bus_id, > devfun_id, vf_count, drvr_type) > Is this different from calling generate_sriov_vfs(), which I assume is the "correct" behavior. There appears to be a common practice in legacy DTS of templating out function names to call instead of using inheritance, so you will have a base function like bind_port(), and then that templates out calls to bind_port_linux(). bind_port_freebsd(), bind_port_windows() etc. It's a little strange but it is what it is and we should probably stick with the existing system if we are going to make additions. But, if there is a practical reason why you did it this way, then okay. :) > sriov_vfs_pci =3D pf_port.get_sriov_vfs_pci() > if not sriov_vfs_pci: > raise Exception("can not get vf pci") > @@ -51,6 +55,11 @@ def bind_qat_device(test_case, driver=3D"igb_uio"): > > test_case.dev =3D dev > > +def bind_mrvl_devices(test_case, driver=3D'vfio-pci', **kwargs): > + pci_list =3D kwargs.get("pci_list").split() > + for pci in pci_list: > + test_case.dut.bind_eventdev_port(driver, pci) > + return pci_list > > def get_qat_devices(test_case, cpm_num=3DNone, num=3D1): > if not cpm_num: > -- > 2.25.1 > > --000000000000bce4530625cd2e92 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gnanesh, thanks for sending this. My name is Patri= ck Robb, and I'm a CI Testing Lab manager at the DPDK Community Lab hos= ted=C2=A0at UNH, and a maintainer for the "new" DTS framework whi= ch exists within the DPDK repo and should be replacing the legacy DTS proje= ct in the long term(what this patch is for). We do have a Marvell CN10K boa= rd at the lab, and I would love to begin running some crypto testing from t= hat if possible (so, thanks again for this series).=C2=A0

So, most likely we will want to provide a review from UNH and test = this, so that it can be merged to DTS (technically I was granted the author= ity to apply patches to the legacy repo).

I am add= ing Cody to this thread as I think he can assist me on this. Cody I am goin= g to provide some comments inline as an initial review for this series, and= then we should=C2=A0apply this series locally on the=C2=A0traffic generato= r/test engine=C2=A0for the CN10K (Intel-1 in our lab), dry run the test whi= ch Gnanesh has added, and report back to him. If all goes well, it should b= e possible to merge.=C2=A0

Long term, we will want= to circle back and add this test to the new DTS framework, but it is not r= eady for this test yet, as currently new DTS is testpmd only - there is not= cryptodev support. Although, adding such support to new DTS is something I= would love to work with you on in the next year if you have time available= for development towards=C2=A0DPDK testing! Anyways, comments inline:
=
On Wed= , Oct 30, 2024 at 12:44=E2=80=AFPM Gnanesh <gpalanethra@marvell.com> wrote:
=C2=A0 =C2=A0 Changes included in thi= s patch:
=C2=A0 =C2=A0 -- New TestCases are added for Cn10K CPT Hardware crypto acce= lerator.
=C2=A0 =C2=A0 -- when Testing newly added Testcases it is found Necessary t= o make Below Changes
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1> tests/cryptodev_common.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> bind_qat_devi= ce function is updated to generate VFs for the given crypto_dev_id
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> added New fun= ction bind_mrvl_devices to accept list of PCI Ids and bind it to vfio_pci d= river.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2> framework/crb.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> updated pci_d= evices_information_uncached_linux Method to handle additional Nic Speeds fo= r Cavium,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0as it = was restricting only to 1 GIG NIC speed

Thanks, I also made this=C2=A0change on our local DTS project for cn10k, b= ut the patch was not submitted to the "legacy DTS" mailing list h= ere as it was unmaintained (and still is, to David's point). But, if we= can do a review=C2=A0it is good to get these things into mainline. Maybe I= can rebase our local patch on yours if there were any other changes, and g= et feedback for cn10k specific questions.

I have a= hard time understanding how this 10G NIC speed requirement got added in th= e first place as it was quite peculiar and confused me for a time as it was= dropping the ports list! I'm sure you had a similar experience... :)
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 3> framework/settings.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> Changed the d= efault Cavium NIC driver to rvu_nicpf.

= Thanks, we are also running from this change at the Community Lab. But, I t= hought you said above you are creating VFs from the bind_qat_device functio= n. So, does rvu_nicvf need to be added as well?
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4> nics/net_device.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> added Missing= expect object
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 5> conf/crypto_perf_cryptodev_perf.cf= g
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> added Marvell= Cn10K configs for crypto_perf_cryptodev_perf
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 6> framework/ssh_pexpect.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--> output.replac= e command's output is not set before returning from get_output_all meth= od
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0hence = Unnecessarily returning Prompt along with the output
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 7> tests/TestSuite_crypto_perf_crypto= dev_perf.py
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-->=C2=A0 added M= arvell CN10K Testcases

Again we will ap= ply these, give them a run, and report back.
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Updated Below Private funct= ions
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 6.1> _run_crypto= _perf() --> receives additional KW arguments
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 6.2> _parse_outp= ut()=C2=A0 ---> Updated to handle Marvell Cn10K app command output
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 6.3> _run_crypto= _perf_throughput() --> receives additional KW arguments
=


I don't see any modifications for th= e build process. Is there a need to include "-Dplatform=3Dcn10k" = when setting up the build from meson, or is the default build fine?

=C2=A0


Signed-off-by: Gnanesh <gpalanethra@marvell.com>
---
=C2=A0conf/crypto_perf_cryptodev_perf.cfg=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0| 849 ++++++++++++++++++
=C2=A0framework/crb.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +-
=C2=A0framework/settings.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 +-
=C2=A0framework/ssh_pexpect.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0nics/net_device.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A03 +
=C2=A0tests/TestSuite_crypto_perf_cryptodev_perf.py | 322 ++++++-
=C2=A0tests/cryptodev_common.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 11 +-
=C2=A07 files changed, 1172 insertions(+), 25 deletions(-)

diff --git a/framework/crb.py b/framework/crb.py
index 9e3b0a58..2fe9d147 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -374,15 +374,15 @@ class Crb(object):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pass

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for i in range(len(match)):
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # check if device is cavium and = check its linkspeed, append only if it is 10G
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # for cavium supported link spee= d specfied under linkspeeds
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if "177d:" in mat= ch[i][1]:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 linkspeed =3D &quo= t;10000"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 linkspeeds =3D [&q= uot;40000", "10000", "25000", "50000", &= quot;100000"]

Honestly I don't= understand why we have this condition at all. Other devices in DTS do not = have this check where the portlinks can be dropped in crbs.py. What do you = think about updating the accepted linkspeeds vs just removing this step ent= irely? Can we expect additional linkspeeds=C2=A0to be added for 177d in the= future, and have this problem crop up again for a new linkspeed, or is thi= s list of speeds "final" for 177d?
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0nic_linkspeed= =3D self.send_expect(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0"cat /sys/bus/pci/devices/%s/net/*/speed" % match[i][0],
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0"# ",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0alt_session=3DTrue,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if nic_linkspeed.s= plit()[0] =3D=3D linkspeed:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if nic_linkspeed.s= plit()[0] in=C2=A0 linkspeeds:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0self.pci_devices_info.append((match[i][0], match[i][1]))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.pci_devi= ces_info.append((match[i][0], match[i][1]))
diff --git a/framework/settings.py b/framework/settings.py
index 1a561dda..b2c371f8 100644
--- a/framework/settings.py
+++ b/framework/settings.py
@@ -166,8 +166,8 @@ DRIVERS =3D {
=C2=A0 =C2=A0 =C2=A0"cavium_a034": "thunder-nicvf",
=C2=A0 =C2=A0 =C2=A0"cavium_0011": "thunder-nicvf",
=C2=A0 =C2=A0 =C2=A0"IXGBE_10G-X550EM_X_SFP": "ixgbe",<= br> -=C2=A0 =C2=A0 "cavium_a063": "octeontx2-nicpf",
-=C2=A0 =C2=A0 "cavium_a064": "octeontx2-nicvf",
+=C2=A0 =C2=A0 "cavium_a063": "rvu_nicpf",
+=C2=A0 =C2=A0 "cavium_a064": "rvu_nicvf",

Okay disregard my comment from above about nicvf, I= see you've added it. Please do update the commit message to reflect th= at this is included. And, while you're at it, you can update the commit= message to accord with the style guidelines for submitting DPDK patches as= seen here on sections 9.6 and 9.7 https://doc.dpdk.org/guides/contributing/patches.= html
=C2=A0
:)

=C2=A0 =C2=A0 =C2=A0"ICE_100G-E810C_QSFP": "ice",
=C2=A0 =C2=A0 =C2=A0"ICE_25G-E810C_SFP": "ice",
=C2=A0 =C2=A0 =C2=A0"ICE_25G-E823C_QSFP": "ice",
diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
index 2132c066..a96087d2 100644
--- a/framework/ssh_pexpect.py
+++ b/framework/ssh_pexpect.py
@@ -186,7 +186,7 @@ class SSHPexpect:

=C2=A0 =C2=A0 =C2=A0def get_output_all(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0output =3D self.session.before
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 output.replace("[PEXPECT]", "&q= uot;)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 output =3D output.replace("[PEXPECT]#&quo= t;, "")

So, this is just remo= ving the leading "#" from the output? I'm not sure we should = be making styling changes for a "deprecated" repository. If I loo= k at this example output, from one of the CI runs of this testsuite on a qu= ickassist card:=C2=A0

# Device 1 on lcore 40
# total operations: 30000000
# Buffer size: 1024
# Burst size: 32# =C2=A0 =C2=A0 Number of bursts: 937500
#
# =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Total =C2=A0 Average =C2=A0 Maximum = =C2=A0 Minimum
# =C2=A0enqueued =C2=A0 =C2=A030000000 =C2=A0 =C2=A0 = =C2=A0 =C2=A032 =C2=A0 =C2=A0 =C2=A0 =C2=A032 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 32
# =C2=A0dequeued =C2=A0 =C2=A030000000 =C2=A0 =C2=A0 =C2=A0 =C2=A03= 2 =C2=A0 =C2=A0 =C2=A0 =C2=A032 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1
# =C2=A0= =C2=A0cycles 91892876610 =C2=A0 =C2=A0 =C2=A03063 =C2=A0 =C2=A0304625 = =C2=A0 =C2=A0 =C2=A0 485
# time [us] =C2=A03675715064 =C2=A0 122.520 = 12185.000 =C2=A0 =C2=A019.400

I imagine the DTS m= aintainers were aware of this and thought it was the most clear way to prin= t the logs. I don't think we need to override that decision now.
<= div>=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return output

=C2=A0 =C2=A0 =C2=A0def close(self, force=3DFalse):
diff --git a/nics/net_device.py b/nics/net_device.py
index 0f9c1af4..dd0d0e92 100644
--- a/nics/net_device.py
+++ b/nics/net_device.py
@@ -43,6 +43,7 @@ class NetDevice(object):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if not isinstance(crb, Crb):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0raise Exception("=C2= =A0 Please input the instance of Crb!!!")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.crb =3D crb
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.__send_expect =3D self.crb.send_expect =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.domain_id =3D domain_id
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.bus_id =3D bus_id
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.devfun_id =3D devfun_id
@@ -727,6 +728,8 @@ class NetDevice(object):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"/sys/bus/pci/devices/= %s:%s:%s" % (domain_id, bus_id, devfun_id),
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vf_reg_file,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.__send_expect("echo 0 > %s" = %
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(vf_reg_path), "# ")

So, the pre-existing VFs need to be destroyed before a new = set of VFs can be created? Do you know if this is Marvell specific, or a un= iversal behavior?=C2=A0
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.__send_expect("echo %d > %s&= quot; % (int(vf_num), vf_reg_path), "# ")

=C2=A0 =C2=A0 =C2=A0def generate_sriov_vfs_linux_igb_uio(self, domain_id, b= us_id, devfun_id, vf_num):
diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py b/tests/TestSuit= e_crypto_perf_cryptodev_perf.py
index a3f48eee..b435cefa 100644
--- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
+++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
@@ -59,14 +59,74 @@ class TestCryptoPerfCryptodevPerf(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"# "= ;,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A05,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 cc.bind_qat_device(self, "vfio-pci")=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if self.nic =3D=3D "cavium_a063": +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 count =3D len(self.get_suite_cfg= ().get('l').split(",")) - 1
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cc.bind_qat_device(self, "v= fio-pci", generate_vfs=3DTrue, vf_count=3Dcount)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cc.bind_qat_device(self, "v= fio-pci")

If we are going to use t= his function for non-QAT devices, can we please update the function name to= prevent confusion? It looks like it's a short list:

probb@d121003:~/repos/dts> grep -r "bind_qat_d" .
./= tests/TestSuite_compressdev_qat_pmd.py: =C2=A0 =C2=A0 =C2=A0 =C2=A0cc.bind_= qat_device(self, self.drivername)
./tests/TestSuite_crypto_perf_cryptode= v_perf.py: =C2=A0 =C2=A0 =C2=A0 =C2=A0cc.bind_qat_device(self, "vfio-p= ci")
./tests/TestSuite_fips_cryptodev.py: =C2=A0 =C2=A0 =C2=A0 =C2= =A0cc.bind_qat_device(self, "vfio-pci")
./tests/TestSuite_ipse= c_gw_cryptodev_func.py: =C2=A0 =C2=A0 =C2=A0 =C2=A0cc.bind_qat_device(self,= self.drivername)
./tests/TestSuite_l2fwd_cryptodev_func.py: =C2=A0 =C2= =A0 =C2=A0 =C2=A0cc.bind_qat_device(self, self.drivername)
./tests/TestS= uite_virtio_ipsec_cryptodev_func.py: =C2=A0 =C2=A0 =C2=A0 =C2=A0cc.bind_qat= _device(self, self.drivername)
./tests/TestSuite_virtio_perf_cryptodev_f= unc.py: =C2=A0 =C2=A0 =C2=A0 =C2=A0cc.bind_qat_device(self, self.drivername= )
./tests/TestSuite_virtio_unit_cryptodev_func.py: =C2=A0 =C2=A0 =C2=A0 = =C2=A0cc.bind_qat_device(self, self.drivername)
./tests/compress_common.= py:def bind_qat_device(test_case, driver=3D"igb_uio"):
./tests= /cryptodev_common.py:def bind_qat_device(test_case, driver=3D"igb_uio&= quot;):
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0src_files =3D ["dep/test_aes_cbc.dat= a", "dep/test_aes_gcm.data"]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut_file_dir =3D "/tmp" =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for file in src_files:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.session.copy_file_= to(file, self.dut_file_dir)

=C2=A0 =C2=A0 =C2=A0def tear_down_all(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if self.nic =3D=3D "cavium_a063": +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cc.bind_qat_device(self, "v= fio-pci", generate_vfs=3DTrue,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vf_count=3D2)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 import pandas as pd

I don't have a problem with this, but I'm j= ust wondering why this is imported here as opposed to the top of the file?<= /div>
=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tuples =3D [('TestCase',= ), ('performance', 'failed_enq'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('performance', 'failed_deq'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('performance', 'throughput_mops'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('performance', 'cycle_buf'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('performance', 'throughput', 'value'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('performance', 'throughput', 'delta'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('parameters', 'core_num/thread_num'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('parameters', 'frame_size'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('parameters', 'burst_size'),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ('parameters', 'total_ops'), ('status',)]
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mindex =3D pd.MultiIndex.from_tu= ples(tuples)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 index =3D 0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 df =3D pd.DataFrame([], columns= =3Dmindex)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for tname, data in self._perf_re= sult.items():
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for dt in data: +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for = key, value in dt.items():
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 df.loc[index, 'TestCase'] =3D tname
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 if key =3D=3D 'status':
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 df.loc[index, (key)] =3D value
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 continue
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 for item in value:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 if item['name'] =3D=3D 'throughput'= ;:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 df.loc[index, (key, item['name&#= 39;], 'value')] =3D item['value']
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 df.loc[index, (key, item['name&#= 39;], 'delta')] =3D item['delta']
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 df.loc[index, (key, item['name&#= 39;])] =3D item['value']
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 inde= x +=3D 1
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 perf_xl =3D self.logger.log_path= + "/" + "perf_cryptodev_result.xls"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 writer =3D pd.ExcelWriter(perf_x= l, engine=3D'xlsxwriter')
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 wb=C2=A0 =3D writer.book
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 df.to_excel(writer, sheet_name= =3D'Sheet1')
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws =3D writer.sheets["Sheet= 1"]
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 merge_format =3D wb.add_format({= "bold": 1,"border": 1,"align": "center&q= uot;,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &= quot;valign": "vcenter"})
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('B1:B3', = "TestCase", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('C2:C3', = "failed_enq", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('D2:D3', = "failed_deq", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('E2:E3', = "throughput_mops", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('F2:F3', = "throughput_mops", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('I2:I3', = "core_num/thread_num", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('J2:J3', = "frame_size", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('K2:K3', = "burst_size", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('L2:L3', = "total_ops", merge_format)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.merge_range('M1:M3', = "status", merge_format)
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 format1 =3D wb.add_format({"= ;bg_color": "#C6EFCE", "font_color": "#006100= ", "border": 1})
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 format2 =3D wb.add_format({"= ;bg_color": "#FFC7CE", "font_color": "#9C0006= "})
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.conditional_format("B1:M= 3", {"type": "cell", "criteria": "&= gt;=3D", "value": 0 , 'format': format2})
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 condition =3D 'B5:M%s'%(= 5+len(df)-1)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.conditional_format(condition,= {'type': 'no_blanks', 'format':format1})
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ws.autofit()
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 wb.close()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if self._perf_result:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0with open(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.logger.l= og_path + "/" + "perf_cryptodev_result.json", "a&q= uot;
@@ -175,12 +235,197 @@ class TestCryptoPerfCryptodevPerf(TestCase):
=C2=A0 =C2=A0 =C2=A0def test_scheduler_zuc(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self._run_crypto_perf_throughput()

+=C2=A0 =C2=A0 # Marvell CN10K Testcases
+=C2=A0 =C2=A0 def _crypto_func_cn10k(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Functional tests Helper
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0None
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._run_crypto_func()
+
+=C2=A0 =C2=A0 def _crypto_perf_cn10k(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Perf tests Helper function +=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0None
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._run_crypto_perf_throughput(expected=3D&q= uot;# ",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tr= im_whitespace=3DFalse)
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_cbc(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_gcm_encrypt(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_cbc_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_sha2_256_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_zuc_eea3_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_zuc_eia3_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_gmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_null_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uea2_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_kasumi_f8_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k() #F
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uia2_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_kasumi_f9_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha1_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha1_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_snow_3g_uia2_cipher_then_auth(sel= f):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_cmac_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_3des_cbc_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha1_hmac_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_224_hmac_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_256_hmac_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_384_hmac_cipher_then_auth(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_snow_3g_uia2_cipher_then_auth(sel= f):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_zuc_eia3_cipher_then_auth(self):<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_aes_cmac_cipher_then_auth(self):<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_zuc_eea3_snow3g_uia2_cipher_then_auth(sel= f):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_zuc_eea3_zuc_eia3_cipher_then_auth(self):=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_zuc_eea3_aes_cmac_cipher_then_auth(self):=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uea2_snow3g_uia2_cipher_then_auth(= self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uea2_zuc_eia3_cipher_then_auth(sel= f):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uea2_aes_cmac_cipher_then_auth(sel= f):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_md5_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_ctr_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_3des_cbc_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_224_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_256_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_384_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_512_hmac_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_aes_xts__cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_des_cbc_cipher_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_md5_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha512_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha384_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha256_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha224_auth_only(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_snow3g_uea2_snow3g_uia2(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha1_hmac_armv8(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_perf_mrvl_sha2_hmac_armv8(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_perf_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_ptest(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_burst(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_devtype(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_crypto_sha1_hmac_armv8(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_chacha20_poly1305_aead(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_crypto_sha2_hmac_armv8(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
+=C2=A0 =C2=A0 def test_mrvl_buffer(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self._crypto_func_cn10k()
+
=C2=A0 =C2=A0 =C2=A0# Private functions
=C2=A0 =C2=A0 =C2=A0def _run_crypto_func(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """ Runs Crypto functional test= .
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 None
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if cc.is_test_skip(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 cores =3D ",".join(self.dut.get_core= _list("1S/2C/1T"))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 core_list =3D self.get_suite_cfg().get('co= re_list',"1S/2C/1T")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cores =3D ",".join(self.dut.get_core= _list(core_list))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0config =3D {"l": cores}
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0devices =3D self._get_crypto_device(1) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if not devices:
@@ -206,12 +451,22 @@ class TestCryptoPerfCryptodevPerf(TestCase):

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0out =3D self.dut.send_command(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"cat %s/%s.txt" %= (self.dut_file_dir, self.running_case), 30
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 )
-
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 ).strip()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.verify("Error" not in out,= "Test function failed")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.verify("failed" not in out= , "Test function failed")
-
-=C2=A0 =C2=A0 def _run_crypto_perf(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 assert (out !=3D ""), "No outpu= t"
+
+=C2=A0 =C2=A0 def _run_crypto_perf(self, **kwargs):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """ Runs Crypto Performance tes= t.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Args:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 **kwargs:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 expected: send_expect mat= ch prompt
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 trim_whitespace: trime wh= itespace from command output
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 None
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 expected =3D kwargs.get("expected", = "#")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 trim_whitespace =3D kwargs.get("trim_whit= espace", True)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if cc.is_test_skip(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return "skip"

@@ -222,13 +477,14 @@ class TestCryptoPerfCryptodevPerf(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return "skip"

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0eal_opt_str =3D cc.get_eal_opt_str(self, = devices)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 crypto_perf_opt_str =3D self._get_crypto_perf_= opt_str()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 crypto_perf_opt_str =3D self._get_crypto_perf_= opt_str(**kwargs)

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cmd_str =3D cc.get_dpdk_app_cmd_str(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self._app_path, eal_opt_str= , crypto_perf_opt_str
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0try:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 out =3D self.dut.send_expect(cmd= _str, "#", 600)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 out =3D self.dut.send_expect(cmd= _str, expected, 600,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0trim_whit= espace=3Dtrim_whitespace)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0except Exception as ex:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.logger.error(ex)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0raise ex
@@ -237,25 +493,44 @@ class TestCryptoPerfCryptodevPerf(TestCase):

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return results

-=C2=A0 =C2=A0 def _get_crypto_perf_opt_str(self, override_crypto_perf_opts= =3D{}):
+=C2=A0 =C2=A0 def _get_crypto_perf_opt_str(self, **kwargs):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """get crypto perf app option s= tring
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 args:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 **kwargs:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 override_crypto_pe= rf_opts- Suite/Case specfic perf
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 app config to over= write defaults
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 crypto perf option string
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 override_crypto_perf_opts =3D kwargs.get("= ;override_crypto_perf_opts", {})
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return cc.get_opt_str(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self, self._default_crypto_= perf_opts, override_crypto_perf_opts
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)

=C2=A0 =C2=A0 =C2=A0def _parse_output(self, output):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0try:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dtype =3D self.get_case_cfg().ge= t('devtype')
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 match_str =3D r"=C2=A0 =C2= =A0 lcore id|#lcore id"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lines =3D output.split(&quo= t;\r\n")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0line_nb =3D len(lines)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.logger.debug("Tot= al output lines: " + str(line_nb))

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for line_index in range(lin= e_nb):
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if lines[line_inde= x].startswith("=C2=A0 =C2=A0 lcore id"):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if re.match(match_= str, lines[line_index]):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0self.logger.debug("data output line from: " + str(line_index))=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0break
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data_line =3D line_index - 1
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if dtype =3D=3D 'crypto_cn10= k':
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data_line =3D line= _index + 2
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data_line =3D line= _index - 1
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if len(lines[data_line].split(&q= uot;,"))>1:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pattern =3D re.com= pile(r',')
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pattern =3D re.com= pile(r'\s+')

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0results =3D []
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pattern =3D re.compile(r"\s= +")
+
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for line in lines[data_line= :-1]:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0print(line) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D {}=
@@ -334,9 +609,15 @@ class TestCryptoPerfCryptodevPerf(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cpu_info[key] =3D value.str= ip()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0core, thread =3D 0, 0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lcores =3D self.get_case_cfg()["l&qu= ot;].split(",")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if 'Core(s) per cluster' in out:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cl_soc1 =3D 'Core(s) per clu= ster'
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cl_soc2 =3D 'Cluster(s)'=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cl_soc1 =3D 'Core(s) per soc= ket'
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cl_soc2 =3D 'Socket(s)'<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for lcore in lcores[1:]:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if int(lcore.strip()) < int(c= pu_info["Core(s) per socket"]) * int(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpu_info["Soc= ket(s)"]
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if int(lcore.strip()) < int(c= pu_info[cl_soc1]) * int(
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpu_info[cl_soc2]<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0core +=3D 1 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0thread +=3D 1=
@@ -362,6 +643,11 @@ class TestCryptoPerfCryptodevPerf(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "crypto_snow3g= "
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0elif self.get_case_cfg()["devtype&qu= ot;] =3D=3D "crypto_zuc":
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "crypto_zuc&qu= ot;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 elif self.get_case_cfg()["devtype"] = =3D=3D "crypto_cn10k":
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dev =3D "crypto_cn10k"=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vf =3D cc.get_qat_devices(self, = cpm_num=3D1, num=3Dnum)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 device["a"] =3D ' = -a '.join(vf)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 device["vdev"] =3D Non= e
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0elif self.get_case_cfg()["devtype&qu= ot;] =3D=3D "crypto_scheduler":
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "crypto_schedu= ler"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0w =3D cc.get_qat_devices(se= lf, cpm_num=3D3, num=3Dnum * 3)
@@ -388,8 +674,8 @@ class TestCryptoPerfCryptodevPerf(TestCase):

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return device

-=C2=A0 =C2=A0 def _run_crypto_perf_throughput(self):
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 results =3D self._run_crypto_perf()
+=C2=A0 =C2=A0 def _run_crypto_perf_throughput(self, **kwargs):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 results =3D self._run_crypto_perf(**kwargs) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if results =3D=3D "skip":
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.verify(results, "test results i= s none, Test Failed")
diff --git a/tests/cryptodev_common.py b/tests/cryptodev_common.py
index b550b468..91067b05 100644
--- a/tests/cryptodev_common.py
+++ b/tests/cryptodev_common.py
@@ -8,7 +8,9 @@ from nics.net_device import GetNicObj
=C2=A0conf =3D SuiteConf("cryptodev_sample")


-def bind_qat_device(test_case, driver=3D"igb_uio"):
+def bind_qat_device(test_case, driver=3D"igb_uio", generate_vfs= =3DFalse,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vf_c= ount=3D2, drvr_type=3D'generic'):
+
=C2=A0 =C2=A0 =C2=A0if driver =3D=3D "vfio-pci":
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0test_case.dut.send_expect("modprobe = vfio", "#", 10)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0test_case.dut.send_expect("modprobe = vfio-pci", "#", 10)
@@ -38,6 +40,8 @@ def bind_qat_device(test_case, driver=3D"igb_uio&quo= t;):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0devfun_id =3D addr_array[2]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pf_port =3D GetNicObj(test_case.dut, doma= in_id, bus_id, devfun_id)

+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if generate_vfs:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pf_port.generate_sriov_vfs_linux= (domain_id, bus_id, devfun_id, vf_count, drvr_type)
Is this different from calling generate_sriov_vfs(), which I a= ssume is the "correct" behavior. There appears to be a common pra= ctice in legacy DTS of templating out function names to call instead of usi= ng inheritance, so you will have a base function like bind_port(), and then= that templates out calls to bind_port_linux(). bind_port_freebsd(), bind_p= ort_windows() etc. It's a little strange but it is what it is and we sh= ould probably stick with the existing system if we are going to make additi= ons. But, if there is a practical reason why you did it this way, then okay= . :)
=C2=A0
test_case.dev =3D dev

+def bind_mrvl_devices(test_case, driver=3D'vfio-pci', **kwargs): +=C2=A0 =C2=A0 pci_list =3D kwargs.get("pci_list").split()
+=C2=A0 =C2=A0 for pci in pci_list:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 test_case.dut.bind_eventdev_port(driver, pci)<= br> +=C2=A0 =C2=A0 return pci_list

=C2=A0def get_qat_devices(test_case, cpm_num=3DNone, num=3D1):
=C2=A0 =C2=A0 =C2=A0if not cpm_num:
--
2.25.1

--000000000000bce4530625cd2e92--