From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id B9F5B1B1A3 for ; Wed, 3 Jan 2018 10:03:05 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id g130so19360049wme.0 for ; Wed, 03 Jan 2018 01:03:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=D+G62+q41SsgRCe+lPADbpkEjdJ0v8GFwMX+cTwcrjM=; b=e8doj50MorVOdEa/NqHiXRNVHPBnViRS1enobpxrUBwEF+uM2X7FjGVHz6QAdGAgtA ehKlrDFQLuT0kOIu2lNf5ixRHec+0bEn/UUE8G3KKe6jlhNyitroc2PBLTmgfHtKWCKW Bf9kS2Pb9fq3+SvCuIe5ZnFaLBmk6bLYc1aig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=D+G62+q41SsgRCe+lPADbpkEjdJ0v8GFwMX+cTwcrjM=; b=SzZe5V+HDiOMH+MN1yU1ZPWy6Rct2gUuKJ0Tu5ERrIdDtqZyUSElHDb5KUiameVA+V 4YaVqoEd97iVmd1sVRGvmR5aGoMR48Wet8JtKY3dB3/BNZIy5CqQQaM8TQvuMpaiaqP1 p4eL9aPXN2qmxqjW8fYgw152h+6FDLq4wjltIzNM9ythv6SyeK+M5ScWM/2J2DYlXiOQ ReK9FQMPwFnRZ0zaA0uv5CERj+K2ksYXp0s1/QLqaib57w2TJvkZsb+wJ2Rhb/CELfH2 74aWNlR33BQwvUv40dXgJEAcX6Qzr8U2vDBw7Y5bc4hchROwqiyZYemCs5wTE0Fu8IRr /I1w== X-Gm-Message-State: AKGB3mLu0BZY4UkfV2xBapV93XYYpLxpaa9JAEeIQhGs6IFkYxFrqDPm FUUwl8LkjQnaCjr3rfqMRbLc/osRmG5DH0lQTSiF6pH3 X-Google-Smtp-Source: ACJfBouW79jEZwaMtbYRY8bWPQZRnYvoge/hM2uHLjbK7reGOod1SdztKD8Gh9XYIhiIt03FS1sIrXrvd+Qi3u5LEZM= X-Received: by 10.80.137.154 with SMTP id g26mr1703629edg.146.1514970184770; Wed, 03 Jan 2018 01:03:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.174.101 with HTTP; Wed, 3 Jan 2018 01:03:04 -0800 (PST) In-Reply-To: <1510799982-14113-1-git-send-email-jianbo.liu@linaro.org> References: <1510799982-14113-1-git-send-email-jianbo.liu@linaro.org> From: Jianbo Liu Date: Wed, 3 Jan 2018 17:03:04 +0800 Message-ID: To: dts@dpdk.org, "Liu, Yong" Cc: Jianbo Liu Content-Type: text/plain; charset="UTF-8" Subject: Re: [dts] [PATCH] tests/unit_tests_eal: unbind all the ports before running X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 09:03:05 -0000 Hi Yong, Should I need more changes for this patch? Thanks! Jianbo On 16 November 2017 at 10:39, Jianbo Liu wrote: > From: Jianbo Liu > > Unbinding all the ports to avoid system panic, because there are many cases > running as secondary processes in this tests. > > Signed-off-by: Jianbo Liu > --- > tests/TestSuite_unit_tests_eal.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py > index b619572..e513739 100644 > --- a/tests/TestSuite_unit_tests_eal.py > +++ b/tests/TestSuite_unit_tests_eal.py > @@ -7,6 +7,7 @@ EAL autotest. > > """ > > +import copy > import utils > > > @@ -30,6 +31,11 @@ class TestUnitTestsEal(TestCase): > """ > Run at the start of each test suite. > """ > + self.dut_ports = self.dut.get_ports(self.nic) > + self.unbind_ports = copy.deepcopy(self.dut_ports) > + if len(self.unbind_ports) > 0: > + self.dut.unbind_interfaces_linux(self.unbind_ports) > + > # icc compilation cost long long time. > [arch, machine, self.env, toolchain] = self.target.split('-') > self.start_test_time = 60 > @@ -397,4 +403,5 @@ class TestUnitTestsEal(TestCase): > """ > Run after each test suite. > """ > - pass > + if len(self.unbind_ports) > 0: > + self.dut.bind_interfaces_linux(nics_to_bind=self.unbind_ports) > -- > 1.9.1 >