From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com [209.85.161.181]) by dpdk.org (Postfix) with ESMTP id 4CE5B7CA9 for ; Fri, 18 Aug 2017 03:55:32 +0200 (CEST) Received: by mail-yw0-f181.google.com with SMTP id u207so51382793ywc.3 for ; Thu, 17 Aug 2017 18:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+usGttou5aV94Rl44yPsJdFypdhxSvMKs1tQdGwVnL0=; b=BHCFjA6wx1QlyzJRtAwvunRJKVtikRSREXCVweopvj6tcftl88kxy255nWkE0CY69I rEX1msJIrILrijaBh2C+L6dmwIbMAImdnPGtPyQKps+xgf836aJhdxWyep1I6HhqiuCc +K2HbIFIhMwhFNUCS1UHMqWpHUlenalQfWZVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+usGttou5aV94Rl44yPsJdFypdhxSvMKs1tQdGwVnL0=; b=MtfA++dm59vzcupK5USluX5QbLEpE2zwKKFowhQMs6Kqv2pYjcC5VP4qMD/wvto2lD HcOp/PZxpSHcwY58r7XwzeO12wtpSeXypQvtwP1rpylUBRAF08xi2hvzS+PbsZ63jqN6 2YzyEAL02nGR5V4ducm1ZlHFJ7pEApibihIiwN7cSOzF1Wo12KGHwku6GJ7wJmYlQAQ2 hMsJBrY9tZyerOVaiapnvDW7JzbxnZBW5nnZ6u09HIAPP6EuuzoPkC417SmYx+joD2Zi 5OervE9Bjw/U5SbG/atFBfR0zPWM9hSarwWTnGJHX+tgBsvw8jFp82X0qp+Ux802fJhm mBTg== X-Gm-Message-State: AHYfb5hA86CPh33rPGl2gd8SfaV8F3gxZZ8PNIkKDr4EIE6PnqqUw3Iw GucrCeDJU0hp659Zix9T7dRpMKKOvj55 X-Received: by 10.37.115.136 with SMTP id o130mr334851ybc.229.1503021331402; Thu, 17 Aug 2017 18:55:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.210.74 with HTTP; Thu, 17 Aug 2017 18:55:30 -0700 (PDT) In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62E555B2@SHSMSX103.ccr.corp.intel.com> References: <1502947351-14446-1-git-send-email-jianbo.liu@linaro.org> <86228AFD5BCD8E4EBFD2B90117B5E81E62E555B2@SHSMSX103.ccr.corp.intel.com> From: Jianbo Liu Date: Fri, 18 Aug 2017 09:55:30 +0800 Message-ID: To: "Liu, Yong" Cc: "dts@dpdk.org" , "herbert.guan@arm.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dts] [PATCH] tests/kni: fix failures for kni X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2017 01:55:32 -0000 Hi Marvin, On 17 August 2017 at 20:40, Liu, Yong wrote: > Hi Jianbo, > Is there any particular reason for not chose hyper-threading cores? > There're some performance cases are depending on hyper-threading cores. > If hyper-threading is not enabled on the platform, those cases won't be able to run. > Could you please clear the reason? > I think my patch only changed the function testing cases, not performance ones. Besides, there is no hyper-threading for the arm64 server. Thanks! Jianbo > Thanks, > Marvin > >> -----Original Message----- >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu >> Sent: Thursday, August 17, 2017 1:23 PM >> To: dts@dpdk.org; herbert.guan@arm.com >> Cc: Jianbo Liu >> Subject: [dts] [PATCH] tests/kni: fix failures for kni >> >> The tests need to enable KNI ethtool, and recomple DPDK. >> Also bind to thread 0 of each core for function tests. >> >> Signed-off-by: Jianbo Liu >> --- >> tests/TestSuite_kni.py | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py >> index acd6230..93203f5 100644 >> --- a/tests/TestSuite_kni.py >> +++ b/tests/TestSuite_kni.py >> @@ -52,8 +52,8 @@ packet_sizes_routing = [64, 256] >> >> ports_cores_template = >> '\(P([0123]),(C\{\d.\d.\d\}),(C\{\d.\d.\d\}),(C\{\d.\d.\d\}),?(C\{\d.\d.\d >> \})?\),?' >> >> -default_1_port_cores_config = '(P0,C{1.0.0},C{1.1.0},C{1.0.1})' >> -default_2_port_cores_config = >> '(P0,C{1.0.0},C{1.1.0},C{1.0.1}),(P1,C{1.2.0},C{1.3.0},C{1.2.1})' >> +default_1_port_cores_config = '(P0,C{1.0.0},C{1.1.0},C{1.2.0})' >> +default_2_port_cores_config = >> '(P0,C{1.0.0},C{1.1.0},C{1.2.0}),(P1,C{1.3.0},C{1.4.0},C{1.5.0})' >> >> stress_test_iterations = 50 >> stress_test_random_iterations = 50 >> @@ -258,6 +258,9 @@ class TestKni(TestCase): >> self.verify('no brctl' not in out, >> "The linux tool brctl is needed to run this test >> suite") >> >> + self.dut.send_expect("sed -i -e >> 's/KNI_KMOD_ETHTOOL=n$/KNI_KMOD_ETHTOOL=y/' config/common_base", "# ", 30) >> + self.dut.build_install_dpdk(self.target) >> + >> out = self.dut.send_expect("make -C ./examples/kni/", "# ", 5) >> self.verify('Error' not in out, "Compilation failed") >> >> @@ -1207,5 +1210,9 @@ class TestKni(TestCase): >> """ >> Run after each test suite. >> """ >> + >> + self.dut.send_expect("sed -i -e >> 's/KNI_KMOD_ETHTOOL=y$/KNI_KMOD_ETHTOOL=n/' config/common_base", "# ", 30) >> + self.dut.build_install_dpdk(self.target) >> + >> self.dut.kill_all() >> self.dut.send_expect("rmmod rte_kni", "# ", 10) >> -- >> 1.9.1 >