From: Jianbo Liu <jianbo.liu@linaro.org>
To: Herbert Guan <herbert.guan@arm.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] Domain value is required because the PCI domain values are expected in ports.cfg.
Date: Wed, 5 Jul 2017 17:48:08 +0800 [thread overview]
Message-ID: <CAP4Qi3-Wgz_1p=2VNcjfj1JtxwzJmoUx8XjqmGqzS0V=Ri9xqA@mail.gmail.com> (raw)
In-Reply-To: <1499243520-20873-1-git-send-email-herbert.guan@arm.com>
On 5 July 2017 at 16:32, Herbert Guan <herbert.guan@arm.com> wrote:
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
> tools/setup.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/setup.py b/tools/setup.py
> index cc51ec5..9fcd70e 100755
> --- a/tools/setup.py
> +++ b/tools/setup.py
> @@ -402,7 +402,7 @@ def config_ports():
> global dut_ports
> dut_ports = []
> add_more = True
> - pci_regex = "([\da-f]{2}:[\da-f]{2}.\d{1})$"
> + pci_regex = "([\da-f]{4}:[\da-f]{2}:[\da-f]{2}.\d{1})$"
> ixia_regex = r'(\d).(\d)'
>
> print ('============================================================')
> @@ -414,13 +414,13 @@ def config_ports():
> while add_more:
> pci_option = {'prompt': 'DUT port pci address',
> 'type': 'string',
> - 'help': 'Please input DUT pci address xx:xx.x',
> + 'help': 'Please input DUT pci address xxxx:xx:xx.x',
> 'default': ''}
> opt = Option(**pci_option)
> dut_addr = opt.parse_input()
> m = re.match(pci_regex, dut_addr)
> if not m:
> - print RED("Pci address should follow BDF format!!!")
> + print RED("Pci address should follow Domain+BDF format!!!")
> continue
>
> if ixia and ixia != '':
> @@ -436,13 +436,13 @@ def config_ports():
> else:
> pci_option = {'prompt': 'Tester port pci address',
> 'type': 'string',
> - 'help': 'Please input tester pci address xx:xx.x',
> + 'help': 'Please input tester pci address xxxx:xx:xx.x',
> 'default': ''}
> opt = Option(**pci_option)
> test_addr = opt.parse_input()
> m = re.match(pci_regex, test_addr)
> if not m:
> - print RED("Pci address should follow BDF format!!!")
> + print RED("Pci address should follow Domain+BDF format!!!")
> continue
>
> dut_port = {}
> --
> 1.8.3.1
>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
next prev parent reply other threads:[~2017-07-05 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 8:32 Herbert Guan
2017-07-05 9:48 ` Jianbo Liu [this message]
2017-07-06 13:30 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP4Qi3-Wgz_1p=2VNcjfj1JtxwzJmoUx8XjqmGqzS0V=Ri9xqA@mail.gmail.com' \
--to=jianbo.liu@linaro.org \
--cc=dts@dpdk.org \
--cc=herbert.guan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).