From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f170.google.com (mail-yb0-f170.google.com [209.85.213.170]) by dpdk.org (Postfix) with ESMTP id 15B2B377E for ; Wed, 5 Jul 2017 11:48:09 +0200 (CEST) Received: by mail-yb0-f170.google.com with SMTP id 84so70426740ybe.0 for ; Wed, 05 Jul 2017 02:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8GEXE+PebFkGbRjqer26kLcr3YMHvfSpRJF0AkIK1DQ=; b=M0I3E1GOZE5r8SDrMohlZY1hGCNV59DGrio+nZdORbCYZh0op0Pqk47TI4Xw6ymtj+ qDzCzonuyyJlaRmkeaihhNV/hFbfrumsnbMkKE+ZquP8RazzPe206ZBMp93zWuKaAgF0 fYKa/KXP7/uE6RCIDUwPlB4P7chKdSHLuH2bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8GEXE+PebFkGbRjqer26kLcr3YMHvfSpRJF0AkIK1DQ=; b=UuedxltDi9B5hv7rP+ATsAHWc3PxoUdI3gzBxuDPHLdpupi7WK6RUViof8oz9GtMch ctvAGJkAwcns1w3RnqCElpYMXkmsGmFuuV7ZSGt9dIZrO2lBwE02btQEVlvYHWLWxHEP WsvH+qj+76JyP/kC23+doNEA6NXF9/Mpfye1Hof7x304IqM0+rBwFykWv97RdVAdWDY8 oyIqzBNxdu3M4lADggj6T7G2YKwc02NNy0kcyRCBGyyLhJ7+Mz/svrrK3D9wZOm/JqAv L//bhyXzhKpQY8I55yv5ug3cVNNj49maAo00XYu7OdISS3WDs3I+igW5BmwbE8inEs30 TDaA== X-Gm-Message-State: AIVw1121Mw6MNWhmCeivjSR1ZgVbNpH0KKDtqvjh9mErVe5D8h0xDuiP QQvTnSNiq6PXGtxEoVPzDhTkswbNTJ/y X-Received: by 10.37.201.193 with SMTP id z184mr4953858ybf.158.1499248088486; Wed, 05 Jul 2017 02:48:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.171.73 with HTTP; Wed, 5 Jul 2017 02:48:08 -0700 (PDT) In-Reply-To: <1499243520-20873-1-git-send-email-herbert.guan@arm.com> References: <1499243520-20873-1-git-send-email-herbert.guan@arm.com> From: Jianbo Liu Date: Wed, 5 Jul 2017 17:48:08 +0800 Message-ID: To: Herbert Guan Cc: dts@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dts] [PATCH] Domain value is required because the PCI domain values are expected in ports.cfg. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 09:48:09 -0000 On 5 July 2017 at 16:32, Herbert Guan wrote: > Signed-off-by: Herbert Guan > --- > tools/setup.py | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/setup.py b/tools/setup.py > index cc51ec5..9fcd70e 100755 > --- a/tools/setup.py > +++ b/tools/setup.py > @@ -402,7 +402,7 @@ def config_ports(): > global dut_ports > dut_ports = [] > add_more = True > - pci_regex = "([\da-f]{2}:[\da-f]{2}.\d{1})$" > + pci_regex = "([\da-f]{4}:[\da-f]{2}:[\da-f]{2}.\d{1})$" > ixia_regex = r'(\d).(\d)' > > print ('============================================================') > @@ -414,13 +414,13 @@ def config_ports(): > while add_more: > pci_option = {'prompt': 'DUT port pci address', > 'type': 'string', > - 'help': 'Please input DUT pci address xx:xx.x', > + 'help': 'Please input DUT pci address xxxx:xx:xx.x', > 'default': ''} > opt = Option(**pci_option) > dut_addr = opt.parse_input() > m = re.match(pci_regex, dut_addr) > if not m: > - print RED("Pci address should follow BDF format!!!") > + print RED("Pci address should follow Domain+BDF format!!!") > continue > > if ixia and ixia != '': > @@ -436,13 +436,13 @@ def config_ports(): > else: > pci_option = {'prompt': 'Tester port pci address', > 'type': 'string', > - 'help': 'Please input tester pci address xx:xx.x', > + 'help': 'Please input tester pci address xxxx:xx:xx.x', > 'default': ''} > opt = Option(**pci_option) > test_addr = opt.parse_input() > m = re.match(pci_regex, test_addr) > if not m: > - print RED("Pci address should follow BDF format!!!") > + print RED("Pci address should follow Domain+BDF format!!!") > continue > > dut_port = {} > -- > 1.8.3.1 > Acked-by: Jianbo Liu