test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] Domain value is required because the PCI domain values are expected in ports.cfg.
@ 2017-07-05  8:32 Herbert Guan
  2017-07-05  9:48 ` Jianbo Liu
  2017-07-06 13:30 ` Liu, Yong
  0 siblings, 2 replies; 3+ messages in thread
From: Herbert Guan @ 2017-07-05  8:32 UTC (permalink / raw)
  To: dts; +Cc: Herbert Guan

Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
 tools/setup.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/setup.py b/tools/setup.py
index cc51ec5..9fcd70e 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -402,7 +402,7 @@ def config_ports():
     global dut_ports
     dut_ports = []
     add_more = True
-    pci_regex = "([\da-f]{2}:[\da-f]{2}.\d{1})$"
+    pci_regex = "([\da-f]{4}:[\da-f]{2}:[\da-f]{2}.\d{1})$"
     ixia_regex = r'(\d).(\d)'
 
     print ('============================================================')
@@ -414,13 +414,13 @@ def config_ports():
     while add_more:
         pci_option = {'prompt': 'DUT port pci address',
                       'type': 'string',
-                      'help': 'Please input DUT pci address xx:xx.x',
+                      'help': 'Please input DUT pci address xxxx:xx:xx.x',
                       'default': ''}
         opt = Option(**pci_option)
         dut_addr = opt.parse_input()
         m = re.match(pci_regex, dut_addr)
         if not m:
-            print RED("Pci address should follow BDF format!!!")
+            print RED("Pci address should follow Domain+BDF format!!!")
             continue
 
         if ixia and ixia != '':
@@ -436,13 +436,13 @@ def config_ports():
         else:
             pci_option = {'prompt': 'Tester port pci address',
                           'type': 'string',
-                          'help': 'Please input tester pci address xx:xx.x',
+                          'help': 'Please input tester pci address xxxx:xx:xx.x',
                           'default': ''}
             opt = Option(**pci_option)
             test_addr = opt.parse_input()
             m = re.match(pci_regex, test_addr)
             if not m:
-                print RED("Pci address should follow BDF format!!!")
+                print RED("Pci address should follow Domain+BDF format!!!")
                 continue
 
         dut_port = {}
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-06  4:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05  8:32 [dts] [PATCH] Domain value is required because the PCI domain values are expected in ports.cfg Herbert Guan
2017-07-05  9:48 ` Jianbo Liu
2017-07-06 13:30 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).