From: Jianbo Liu <jianbo.liu@linaro.org>
To: Phil Yang <phil.yang@arm.com>
Cc: dts@dpdk.org, nd@arm.com, Jianbo Liu <Jianbo.Liu@arm.com>,
Herbert Guan <Herbert.Guan@arm.com>,
"xu,huilong" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH] tests/hotplug: fix some failure cases
Date: Tue, 17 Oct 2017 15:44:03 +0800 [thread overview]
Message-ID: <CAP4Qi3-XhXt94fh_g-u70d7dt5S6D3XnUJW0N7JEEZ1M3kvZsQ@mail.gmail.com> (raw)
In-Reply-To: <1508149361-7628-1-git-send-email-phil.yang@arm.com>
On 16 October 2017 at 18:22, Phil Yang <phil.yang@arm.com> wrote:
> 1. Updated testpmd path for multiarch.
> 2. Fix port binding timeout in tear-down process.
> 3. Modified acceptance criteria to avoid test errors caused by
> broadcast packets.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
> tests/TestSuite_hotplug.py | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
> index 7704253..99d3f3b 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -69,8 +69,8 @@ class TestPortHotPlug(TestCase):
> """
> attach port
> """
> - # dpdk hotplug discern NIC by pci bus not include domid
> - self.dut.send_expect("port attach %s" % self.dut.ports_info[port]['pci'][len("0000:"):],"is attached",60)
> + # dpdk hotplug discern NIC by pci bus and include domid
> + self.dut.send_expect("port attach %s" % self.dut.ports_info[port]['pci'],"is attached",60)
> self.dut.send_expect("port start %s" % port,"Configuring Port",120)
> # sleep 10 seconds for fortville update link stats
> time.sleep(10)
> @@ -90,7 +90,7 @@ class TestPortHotPlug(TestCase):
> """
> first run testpmd after attach port
> """
> - cmd = "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s -- -i" % (self.coremask,self.dut.get_memory_channels())
> + cmd = "./%s/app/testpmd -c %s -n %s -- -i" % (self.target,self.coremask,self.dut.get_memory_channels())
> self.dut.send_expect(cmd,"testpmd>",60)
> session_secondary = self.dut.new_session()
> session_secondary.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60)
> @@ -104,11 +104,12 @@ class TestPortHotPlug(TestCase):
>
> self.dut.send_expect("start","testpmd>",60)
> self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> + self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
> packet = re.search("RX-packets:\s*(\d*)",out)
> sum_packet = packet.group(1)
> - self.verify(int(sum_packet) == 1, "Insufficient the received package")
> + self.verify(int(sum_packet) > 0, "Insufficient the received package")
Maybe it's environment issue, you should still check the packet number == 1.
> self.dut.send_expect("quit","#",60)
>
> def send_packet(self, port):
> @@ -129,17 +130,19 @@ class TestPortHotPlug(TestCase):
> session_secondary = self.dut.new_session()
> session_secondary.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60)
> self.dut.close_session(session_secondary)
> - cmd = "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s -- -i" % (self.coremask,self.dut.get_memory_channels())
> + cmd = "./%s/app/testpmd -c %s -n %s -- -i" % (self.target,self.coremask,self.dut.get_memory_channels())
> self.dut.send_expect(cmd,"testpmd>",60)
> self.detach(self.port)
> self.attach(self.port)
> +
> self.dut.send_expect("start","testpmd>",60)
> self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
> + self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
> packet = re.search("RX-packets:\s*(\d*)",out)
> sum_packet = packet.group(1)
> - self.verify(int(sum_packet) == 1, "Insufficient the received package")
> + self.verify(int(sum_packet) > 0, "Insufficient the received package")
> self.dut.send_expect("quit","#",60)
>
>
> @@ -147,8 +150,8 @@ class TestPortHotPlug(TestCase):
> """
> Run after each test case.
> """
> - self.dut.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'],"#",60)
> self.dut.kill_all()
> + self.dut.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'],"#",60)
I think you should consider vfio-pci as well.
> time.sleep(2)
>
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-10-17 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 10:22 Phil Yang
2017-10-17 7:44 ` Jianbo Liu [this message]
2017-10-18 8:41 ` [dts] [PATCH v2] " Phil Yang
2017-10-19 10:12 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP4Qi3-XhXt94fh_g-u70d7dt5S6D3XnUJW0N7JEEZ1M3kvZsQ@mail.gmail.com \
--to=jianbo.liu@linaro.org \
--cc=Herbert.Guan@arm.com \
--cc=Jianbo.Liu@arm.com \
--cc=dts@dpdk.org \
--cc=huilongx.xu@intel.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).