From: Jianbo Liu <jianbo.liu@linaro.org>
To: Herbert Guan <herbert.guan@arm.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used
Date: Wed, 5 Jul 2017 17:02:40 +0800 [thread overview]
Message-ID: <CAP4Qi39B4m-77_YxiLcrpSDvP5LQ0FX-WOeiFOPA0tbdpZMdnA@mail.gmail.com> (raw)
In-Reply-To: <1499243044-20817-1-git-send-email-herbert.guan@arm.com>
On 5 July 2017 at 16:24, Herbert Guan <herbert.guan@arm.com> wrote:
> It's necessary to allow user selecting the nic and target options after reading out the default execution templates.
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
> tools/setup.py | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/tools/setup.py b/tools/setup.py
> index 090dda9..cc51ec5 100755
> --- a/tools/setup.py
> +++ b/tools/setup.py
> @@ -259,23 +259,23 @@ def config_execution():
> opt = Option(**suites_option)
> suites = opt.parse_input()
>
> - nics = ['cfg']
> - nics += NICS.keys()
> - nic_option = {'prompt': 'Choose one of nics',
> - 'type': 'choice',
> - 'help': 'Choose one of dpdk support NIC',
> - 'options': nics,
> - 'default': '0'}
> - opt = Option(**nic_option)
> - nic_type = opt.parse_input()
> -
> - target_option = {'prompt': 'Choose target for execution',
> - 'type': 'choice',
> - 'help': 'Choose one of dpdk targets',
> - 'options': targets,
> - 'default': '0'}
> - opt = Option(**target_option)
> - target = opt.parse_input()
> + nics = ['cfg']
> + nics += NICS.keys()
> + nic_option = {'prompt': 'Choose one of nics',
> + 'type': 'choice',
> + 'help': 'Choose one of dpdk support NIC',
> + 'options': nics,
> + 'default': '0'}
> + opt = Option(**nic_option)
> + nic_type = opt.parse_input()
> +
> + target_option = {'prompt': 'Choose target for execution',
> + 'type': 'choice',
> + 'help': 'Choose one of dpdk targets',
> + 'options': targets,
> + 'default': '0'}
> + opt = Option(**target_option)
> + target = opt.parse_input()
>
> driver_option = {'prompt': 'Choose one of them',
> 'type': 'choice',
> --
> 1.8.3.1
>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
next prev parent reply other threads:[~2017-07-05 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 8:24 Herbert Guan
2017-07-05 9:02 ` Jianbo Liu [this message]
2017-07-06 13:28 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP4Qi39B4m-77_YxiLcrpSDvP5LQ0FX-WOeiFOPA0tbdpZMdnA@mail.gmail.com \
--to=jianbo.liu@linaro.org \
--cc=dts@dpdk.org \
--cc=herbert.guan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).