From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.161.170]) by dpdk.org (Postfix) with ESMTP id A1FB32B96 for ; Wed, 5 Jul 2017 11:02:41 +0200 (CEST) Received: by mail-yw0-f170.google.com with SMTP id a12so41694305ywh.3 for ; Wed, 05 Jul 2017 02:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kFxIsUXkIbhol1fRNWjCu2OU5+P1pSX8WOBDShuojiA=; b=Aj2e4Rv992xQnOXQR0hWrVEDLK414VrR3xZRrziL0iJoqK9dHTca80BdP50rPxJuDW EztVvOiSx1F/fk5OYH2WEfEtQduR8Jfm4ztoN2l59TZ/mGRwDquJY3tyKHTu2g6WRwKQ 98tl9ujYmGJD9vsJDMbj/my8ZpIt02sGbWFxc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kFxIsUXkIbhol1fRNWjCu2OU5+P1pSX8WOBDShuojiA=; b=NYw3zzMYqG/fn/4q87jd9E2E4ZozySKTTYi+md0PRdwoPOus7bD3kJ0ySjQqmsbxNq 1nazMffSDPlMb6cv/ujzZAjCoxv11rWFXlCzp87QseZSrk9l34XPooEt9nB70GMPRkqq 1f9TwYTVLt3fcEwSVppbSAW0OvtGN1dwoLG/BPW+FPUqfL9ucHZSA4MTY3lCRBlsjTLW SIvoAS5r0bX+Jt8MANFQqXsegCBv6LCQGu9A/qlby6zGEoTZ5YZTmD4OLrYLEmLbrUdL l8T+RfCqYCvntedSUOKOsnYSh1baDpdHJaayD6zJU5Hf+GEYu1CbEak4P42dIVrviM6h wMAg== X-Gm-Message-State: AIVw1114EG9pYOvpVPymiqFtdAi+Ql76YGjE/14HdlDthzAcg1fDI9ky xs2MEZnBK96iUhzmiXPLJ0ZaVrCD0JJw X-Received: by 10.13.245.65 with SMTP id e62mr14910024ywf.114.1499245360859; Wed, 05 Jul 2017 02:02:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.171.73 with HTTP; Wed, 5 Jul 2017 02:02:40 -0700 (PDT) In-Reply-To: <1499243044-20817-1-git-send-email-herbert.guan@arm.com> References: <1499243044-20817-1-git-send-email-herbert.guan@arm.com> From: Jianbo Liu Date: Wed, 5 Jul 2017 17:02:40 +0800 Message-ID: To: Herbert Guan Cc: dts@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 09:02:42 -0000 On 5 July 2017 at 16:24, Herbert Guan wrote: > It's necessary to allow user selecting the nic and target options after reading out the default execution templates. > Signed-off-by: Herbert Guan > --- > tools/setup.py | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/tools/setup.py b/tools/setup.py > index 090dda9..cc51ec5 100755 > --- a/tools/setup.py > +++ b/tools/setup.py > @@ -259,23 +259,23 @@ def config_execution(): > opt = Option(**suites_option) > suites = opt.parse_input() > > - nics = ['cfg'] > - nics += NICS.keys() > - nic_option = {'prompt': 'Choose one of nics', > - 'type': 'choice', > - 'help': 'Choose one of dpdk support NIC', > - 'options': nics, > - 'default': '0'} > - opt = Option(**nic_option) > - nic_type = opt.parse_input() > - > - target_option = {'prompt': 'Choose target for execution', > - 'type': 'choice', > - 'help': 'Choose one of dpdk targets', > - 'options': targets, > - 'default': '0'} > - opt = Option(**target_option) > - target = opt.parse_input() > + nics = ['cfg'] > + nics += NICS.keys() > + nic_option = {'prompt': 'Choose one of nics', > + 'type': 'choice', > + 'help': 'Choose one of dpdk support NIC', > + 'options': nics, > + 'default': '0'} > + opt = Option(**nic_option) > + nic_type = opt.parse_input() > + > + target_option = {'prompt': 'Choose target for execution', > + 'type': 'choice', > + 'help': 'Choose one of dpdk targets', > + 'options': targets, > + 'default': '0'} > + opt = Option(**target_option) > + target = opt.parse_input() > > driver_option = {'prompt': 'Choose one of them', > 'type': 'choice', > -- > 1.8.3.1 > Acked-by: Jianbo Liu