test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jianbo Liu <jianbo.liu@linaro.org>
To: Phil Yang <phil.yang@arm.com>
Cc: dts@dpdk.org, nd@arm.com
Subject: Re: [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready.
Date: Thu, 14 Sep 2017 14:15:09 +0800	[thread overview]
Message-ID: <CAP4Qi39Z8JqG-jV=mt5VM=XtzuQomVtbLeSu62dZO89Pqi=2gg@mail.gmail.com> (raw)
In-Reply-To: <1505265525-15502-1-git-send-email-phil.yang@arm.com>

On 13 September 2017 at 09:18, Phil Yang <phil.yang@arm.com> wrote:
> Sometime tests/skeleton will fail in capturing packets of the target
> RJ45 port while the connection is establishing.
> Add a delay to waiting for the connection ready.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
>  tests/TestSuite_skeleton.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_skeleton.py b/tests/TestSuite_skeleton.py
> index a5cc591..77f95e1 100644
> --- a/tests/TestSuite_skeleton.py
> +++ b/tests/TestSuite_skeleton.py
> @@ -75,6 +75,8 @@ class TestSkeleton(TestCase):
>          cmd = self.path + " -c %s -n %d " % (self.coremask,self.dut.get_memory_channels())
>          self.dut.send_expect(cmd,"forwarding packets",60)
>
> +        time.sleep(5)
> +
>          self.iface_port0 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
>          self.iface_port1 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
>
> --
> 2.7.4
>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

  reply	other threads:[~2017-09-14  6:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13  1:18 Phil Yang
2017-09-14  6:15 ` Jianbo Liu [this message]
2017-09-14 15:02   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP4Qi39Z8JqG-jV=mt5VM=XtzuQomVtbLeSu62dZO89Pqi=2gg@mail.gmail.com' \
    --to=jianbo.liu@linaro.org \
    --cc=dts@dpdk.org \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).