test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jianbo Liu <jianbo.liu@linaro.org>
To: "xu,huilong" <huilongx.xu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] disable ASLR for mutli process test
Date: Thu, 17 Nov 2016 13:20:31 +0800	[thread overview]
Message-ID: <CAP4Qi3_Y46vS-K0rVSTO-d=DacQcu6vk4Ur92p3dA5oK=W=P9Q@mail.gmail.com> (raw)
In-Reply-To: <1479193255-23326-1-git-send-email-huilongx.xu@intel.com>

On 15 November 2016 at 15:00, xu,huilong <huilongx.xu@intel.com> wrote:
> if not disable ASLR, mutli process test case maybe failed.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_multiprocess.py   | 7 ++++++-
>  tests/TestSuite_unit_tests_eal.py | 6 ++++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
> index b305437..f49ecb8 100644
> --- a/tests/TestSuite_multiprocess.py
> +++ b/tests/TestSuite_multiprocess.py
> @@ -57,7 +57,12 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>
>          self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough Cores")
>          self.tester.extend_external_packet_generator(TestMultiprocess, self)
> -
> +        try:
> +            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
> +            if aslr_flage:
> +                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
> +        except:
> +            print "This machine not support disable ASLR, maybe multi process will failed"
>          out = self.dut.build_dpdk_apps("./examples/multi_process/")
>          self.verify('Error' not in out, "Compilation failed")
>
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 8fea148..a8419ce 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -332,6 +332,12 @@ class TestUnitTestsEal(TestCase):
>          """
>          Run multiprocess autotest.
>          """
> +        try:
> +            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
> +            if aslr_flage:
> +                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
> +        except:
> +            print "This machine not support disable ASLR, maybe multi process will failed"
>
>          self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time)
>          out = self.dut.send_expect("multiprocess_autotest", "RTE>>", self.run_cmd_time)
> --
> 1.9.3
>

It is better to set the original value back after multiprocess test
and unit test.

  reply	other threads:[~2016-11-17  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  7:00 xu,huilong
2016-11-17  5:20 ` Jianbo Liu [this message]
2016-11-18  3:20   ` Xu, HuilongX
2016-11-18  3:20   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP4Qi3_Y46vS-K0rVSTO-d=DacQcu6vk4Ur92p3dA5oK=W=P9Q@mail.gmail.com' \
    --to=jianbo.liu@linaro.org \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).