[dts] [PATCH V1] disable ASLR for mutli process test

[dts] [PATCH V1] disable ASLR for mutli process test

[xu,huilong]

if not disable ASLR, mutli process test case maybe failed.

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_multiprocess.py   | 7 ++++++-
 tests/TestSuite_unit_tests_eal.py | 6 ++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
index b305437..f49ecb8 100644
--- a/tests/TestSuite_multiprocess.py
+++ b/tests/TestSuite_multiprocess.py
@@ -57,7 +57,12 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
 
         self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough Cores")
         self.tester.extend_external_packet_generator(TestMultiprocess, self)
-
+        try:
+            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
+            if aslr_flage:
+                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
+        except:
+            print "This machine not support disable ASLR, maybe multi process will failed" 
         out = self.dut.build_dpdk_apps("./examples/multi_process/")
         self.verify('Error' not in out, "Compilation failed")
 
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 8fea148..a8419ce 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -332,6 +332,12 @@ class TestUnitTestsEal(TestCase):
         """
         Run multiprocess autotest.
         """
+        try:
+            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
+            if aslr_flage:
+                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
+        except:
+            print "This machine not support disable ASLR, maybe multi process will failed"
 
         self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("multiprocess_autotest", "RTE>>", self.run_cmd_time)
-- 
1.9.3

Re: [dts] [PATCH V1] disable ASLR for mutli process test

[Jianbo Liu]

On 15 November 2016 at 15:00, xu,huilong <huilongx.xu@intel.com> wrote:
> if not disable ASLR, mutli process test case maybe failed.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_multiprocess.py   | 7 ++++++-
>  tests/TestSuite_unit_tests_eal.py | 6 ++++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
> index b305437..f49ecb8 100644
> --- a/tests/TestSuite_multiprocess.py
> +++ b/tests/TestSuite_multiprocess.py
> @@ -57,7 +57,12 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>
>          self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough Cores")
>          self.tester.extend_external_packet_generator(TestMultiprocess, self)
> -
> +        try:
> +            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
> +            if aslr_flage:
> +                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
> +        except:
> +            print "This machine not support disable ASLR, maybe multi process will failed"
>          out = self.dut.build_dpdk_apps("./examples/multi_process/")
>          self.verify('Error' not in out, "Compilation failed")
>
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 8fea148..a8419ce 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -332,6 +332,12 @@ class TestUnitTestsEal(TestCase):
>          """
>          Run multiprocess autotest.
>          """
> +        try:
> +            aslr_flage = int(self.dut.send_expect("cat /proc/sys/kernel/randomize_va_space", "# "))
> +            if aslr_flage:
> +                self.dut.send_expect("echo 0 > /proc/sys/kernel/randomize_va_space", "# ")
> +        except:
> +            print "This machine not support disable ASLR, maybe multi process will failed"
>
>          self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time)
>          out = self.dut.send_expect("multiprocess_autotest", "RTE>>", self.run_cmd_time)
> --
> 1.9.3
>

It is better to set the original value back after multiprocess test
and unit test.

Re: [dts] [PATCH V1] disable ASLR for mutli process test

[Xu, HuilongX]

Hi jianbo,
We should not changed test environment, when we finish a test.
I will submit a new version for  restore ASLR.
Thanks a  lot

> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@linaro.org]
> Sent: Thursday, November 17, 2016 1:21 PM
> To: Xu, HuilongX
> Cc: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] disable ASLR for mutli process test
> 
> On 15 November 2016 at 15:00, xu,huilong <huilongx.xu@intel.com> wrote:
> > if not disable ASLR, mutli process test case maybe failed.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  tests/TestSuite_multiprocess.py   | 7 ++++++-
> >  tests/TestSuite_unit_tests_eal.py | 6 ++++++
> >  2 files changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_multiprocess.py
> b/tests/TestSuite_multiprocess.py
> > index b305437..f49ecb8 100644
> > --- a/tests/TestSuite_multiprocess.py
> > +++ b/tests/TestSuite_multiprocess.py
> > @@ -57,7 +57,12 @@ class TestMultiprocess(TestCase,
> IxiaPacketGenerator):
> >
> >          self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough
> Cores")
> >          self.tester.extend_external_packet_generator(TestMultiprocess,
> self)
> > -
> > +        try:
> > +            aslr_flage = int(self.dut.send_expect("cat
> /proc/sys/kernel/randomize_va_space", "# "))
> > +            if aslr_flage:
> > +                self.dut.send_expect("echo 0 >
> /proc/sys/kernel/randomize_va_space", "# ")
> > +        except:
> > +            print "This machine not support disable ASLR, maybe multi
> process will failed"
> >          out = self.dut.build_dpdk_apps("./examples/multi_process/")
> >          self.verify('Error' not in out, "Compilation failed")
> >
> > diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> > index 8fea148..a8419ce 100644
> > --- a/tests/TestSuite_unit_tests_eal.py
> > +++ b/tests/TestSuite_unit_tests_eal.py
> > @@ -332,6 +332,12 @@ class TestUnitTestsEal(TestCase):
> >          """
> >          Run multiprocess autotest.
> >          """
> > +        try:
> > +            aslr_flage = int(self.dut.send_expect("cat
> /proc/sys/kernel/randomize_va_space", "# "))
> > +            if aslr_flage:
> > +                self.dut.send_expect("echo 0 >
> /proc/sys/kernel/randomize_va_space", "# ")
> > +        except:
> > +            print "This machine not support disable ASLR, maybe multi
> process will failed"
> >
> >          self.dut.send_expect(self.test_app_cmdline + ' -m 64',
> "R.*T.*E.*>.*>", self.start_test_time)
> >          out = self.dut.send_expect("multiprocess_autotest", "RTE>>",
> self.run_cmd_time)
> > --
> > 1.9.3
> >
> 
> It is better to set the original value back after multiprocess test
> and unit test.

Re: [dts] [PATCH V1] disable ASLR for mutli process test

[Liu, Yong]

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
> Sent: Thursday, November 17, 2016 1:21 PM
> To: Xu, HuilongX
> Cc: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] disable ASLR for mutli process test
> 
> On 15 November 2016 at 15:00, xu,huilong <huilongx.xu@intel.com> wrote:
> > if not disable ASLR, mutli process test case maybe failed.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > --
> > 1.9.3
> >
> 
> It is better to set the original value back after multiprocess test
> and unit test.

+1.