From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 711E31B740 for ; Tue, 17 Oct 2017 08:26:53 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id b189so1488085wmd.4 for ; Mon, 16 Oct 2017 23:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tAW8m6isBnHfsHiMAJHMr4Au8KfeR/NczmECcCmFHuI=; b=ddXjS/vE3l8TOoOCTyqCaSS9cDjWYb+34d39dc3gGgSw9Ug8tXCqC2tBQ4VqG3G3WX S9o7s7GrxGJIh7bFuwEYf3tCmG3wJjYC8edj/ySjHNG70yPYVZnKUFO7hO/vLWO+//AC e5qxlbzrO5hRU0I4F9FEOv2XbAgagFpOIS6C4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tAW8m6isBnHfsHiMAJHMr4Au8KfeR/NczmECcCmFHuI=; b=iNwES2GEU/yjrPz6WUqAvEsmlzOqI25rLo0daMckNaorXIswgVg52de/5QXenYAp5c ZtNATrJxLEugQdanMLzE77vTVJw4cgqP/rPnh07DNogiENBJ70/VtpeimrVdlTQjIR2/ lIE916aF5DPxxjedUvv9j7BOE0tK9CSjtvGOEaOzasgsC99L6Uo6a5fqtXWadlYqMDWo dTF0m0Ef/vMDnNmR0ol7XfFncapa1mVdyAcK3W5pprwpXp6BN8ODenEmNP5a2/36ACmL QFOMtUNvi+uXYuqr7SehOZA52ejNGAmlE/LWLfJ5ygSOTqG+is3kaU8U7k+mucfZG35L iHxQ== X-Gm-Message-State: AMCzsaWO8zVLe7lwfWrf7GeH9YqwR+zJe0OsXjSQfqROW113Kno9xUdt OR81/ChVEG0yPRyAcGOLIG36M+t22miHyyLjotjpDQ== X-Google-Smtp-Source: AOwi7QAmEpGhD9//vthWdwZrC8F4KUOyXi9XwHaCERZzY/A90bCQTnWkVe1DM7PAdtldATsCbyB/d8QEyHH6QylsqWs= X-Received: by 10.80.148.217 with SMTP id t25mr15657725eda.146.1508221613146; Mon, 16 Oct 2017 23:26:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.159.238 with HTTP; Mon, 16 Oct 2017 23:26:52 -0700 (PDT) In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62EF6A1F@SHSMSX103.ccr.corp.intel.com> References: <1504685144-5381-1-git-send-email-peipeix.lu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62EF6A1F@SHSMSX103.ccr.corp.intel.com> From: Jianbo Liu Date: Tue, 17 Oct 2017 14:26:52 +0800 Message-ID: To: "Liu, Yong" Cc: "Lu, PeipeiX" , "dts@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: Add the size of the judgment hugepage X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 06:26:53 -0000 Hi Yong, Can you tell me what the failed cases are? I don't think it need 8G memory. Thanks! Jianbo On 16 October 2017 at 15:53, Liu, Yong wrote: > Jianbo, > Only lpm unit test required for so much memory. If there's not enough res= ource for some cases, this kind of cases should be taken as failed. The err= or reason has been included in the message, so user can choose either enlar= ge DUT resource and rerun or just ignore it > > Thanks, > Marvin > >> -----Original Message----- >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu >> Sent: Wednesday, October 11, 2017 3:23 PM >> To: Lu, PeipeiX >> Cc: dts@dpdk.org >> Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: Add the size of the >> judgment hugepage >> >> Hi Peipei, >> >> Is there any requirement that the total hugepages should be larger than = 8G? >> Besides, self.verify will exit this test, not raise one warning as you >> declared. Could it be wrong? >> >> Thanks! >> Jianbo >> >> On 6 September 2017 at 16:05, lu,peipei wrote: >> > Check whether host hugepage fulfill the requirement.If host setup can'= t >> run this case, just raise one warning >> > >> > Signed-off-by: lu,peipei >> > --- >> > tests/TestSuite_unit_tests_lpm.py | 15 ++++++--------- >> > 1 file changed, 6 insertions(+), 9 deletions(-) >> > >> > diff --git a/tests/TestSuite_unit_tests_lpm.py >> b/tests/TestSuite_unit_tests_lpm.py >> > index e8149ff..f9a2bf7 100644 >> > --- a/tests/TestSuite_unit_tests_lpm.py >> > +++ b/tests/TestSuite_unit_tests_lpm.py >> > @@ -81,21 +81,18 @@ class TestUnitTestsLpmIpv6(TestCase): >> > """ >> > [arch, machine, env, toolchain] =3D self.target.split('-') >> > self.verify(arch in ["x86_64", "arm64"], "lpm6 request huge >> memory") >> > - if env =3D=3D 'bsdapp': >> > + hugepages_size =3D int(self.dut.send_expect("awk '/Hugepagesi= ze/ >> {print $2}' /proc/meminfo", "# ")) >> > + hugepage_ori =3D self.dut.get_total_huge_pages() >> > + if env =3D=3D 'bsdapp': >> > pass >> > else: >> > - hugepage_ori =3D self.dut.get_total_huge_pages() >> > - self.dut.set_huge_pages(4096) >> > - hugepage_num =3D self.dut.get_total_huge_pages() >> > - self.verify(hugepage_num >=3D 4096, "failed to request hu= ge >> memory") >> > + hugepage_8G =3D 8 * 1024 * 1024 >> > + total_hugepage =3D hugepages_size * hugepage_ori >> > + self.verify(total_hugepage >=3D hugepage_8G,"have no enou= gh >> hugepage") >> > >> > self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target, >> "R.*T.*E.*>.*>", 60) >> > out =3D self.dut.send_expect("lpm6_autotest", "RTE>>", 3600) >> > self.dut.send_expect("quit", "# ") >> > - if env =3D=3D 'bsdapp': >> > - pass >> > - else: >> > - self.dut.set_huge_pages(hugepage_ori) >> > self.verify("Test OK" in out, "Test failed") >> > >> > def tear_down(self): >> > -- >> > 1.9.3 >> >