Re: [dts] [PATCH] tests mac_filter: use scapy to send packets

[Jianbo Liu <jianbo.liu@linaro.org>]

Hi Marvin,

On 2 December 2016 at 11:27, Liu, Yong <yong.liu@intel.com> wrote:
> Hi Jianbo,
> Packet module is one abstract layer based on scapy. We abstracted this layer for monitoring scapy process and integrating sniff/configuration function.
> It should work the same as scapy command. I'm interesting in why your intended to use scapy replace of Packet module.
>
I assume dts can be run on a different machine from tester. Am I right?
But I got the following error, as the module sends packets through its
local port, not the tester's port, but they are different if dts is
not run on tester machine.

               ERROR: Test Case test_add_remove_mac_address Result
ERROR: Traceback (most recent call last):
  File "/home/liujb/work/src/dts/framework/test_case.py", line 282, in
_execute_test_case
    case_obj()
  File "/home/liujb/work/src/dts/tests/TestSuite_mac_filter.py", line
109, in test_add_remove_mac_address
    self.whitelist_send_packet(portid, self.dest)
  File "/home/liujb/work/src/dts/tests/TestSuite_mac_filter.py", line
91, in whitelist_send_packet
    pkt.send_pkt(tx_port=itf)
  File "/home/liujb/work/src/dts/framework/packet.py", line 464, in send_pkt
    self.pktgen.send_pkt(intf=self.tx_port)
  File "/home/liujb/work/src/dts/framework/packet.py", line 348, in send_pkt
    self.pkt.getlayer(0).src = get_if_hwaddr(intf)
  File "/usr/lib/python2.7/dist-packages/scapy/arch/__init__.py", line
39, in get_if_hwaddr
    addrfamily, mac = get_if_raw_hwaddr(iff)
  File "/usr/lib/python2.7/dist-packages/scapy/arch/linux.py", line
82, in get_if_raw_hwaddr
    return struct.unpack("16xh6s8x",get_if(iff,SIOCGIFHWADDR))
  File "/usr/lib/python2.7/dist-packages/scapy/arch/linux.py", line
269, in get_if
    ifreq = ioctl(s, cmd, struct.pack("16s16x",iff))
IOError: [Errno 19] No such device



> Thanks,
> Marvin
>
>> -----Original Message-----
>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
>> Sent: Friday, December 02, 2016 10:46 AM
>> To: dts@dpdk.org
>> Cc: Jianbo Liu
>> Subject: [dts] [PATCH] tests mac_filter: use scapy to send packets
>>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>> ---
>>  tests/TestSuite_mac_filter.py | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
>> index 1c58b87..a06b812 100644
>> --- a/tests/TestSuite_mac_filter.py
>> +++ b/tests/TestSuite_mac_filter.py
>> @@ -86,9 +86,10 @@ class TestWhitelist(TestCase):
>>          Send 1 packet to portid.
>>          """
>>          itf =
>> self.tester.get_interface(self.tester.get_local_port(portid))
>> -        pkt = Packet(pkt_type='UDP')
>> -        pkt.config_layer('ether', {'src': '52:00:00:00:00:00', 'dst':
>> destMac})
>> -        pkt.send_pkt(tx_port=itf)
>> +        pkt = 'Ether(dst="%s",
>> src="52:00:00:00:00:00")/IP()/UDP()/("X"*46)' % destMac
>> +        self.tester.send_expect("scapy", ">>> ")
>> +        self.tester.scapy_append('sendp([%s], iface="%s")' % (pkt, itf))
>> +        self.tester.scapy_execute()
>>
>>      def test_add_remove_mac_address(self):
>>          """
>> --
>> 1.9.1
>