From: "Xiao, QimaiX" <qimaix.xiao@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]framework/ssh_connection: fix output might be int
Date: Wed, 26 Aug 2020 11:04:34 +0000 [thread overview]
Message-ID: <CY4PR1101MB224704F3F1A24470C51AEF02FB540@CY4PR1101MB2247.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200826015319.106866-1-qimaix.xiao@intel.com>
Tested-by: Xiao Qimai <qimaix.xiao@intel.com>
Regards,
Xiao Qimai
> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Wednesday, August 26, 2020 9:53 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]framework/ssh_connection: fix output might be int
>
> *. when verify is True in send_expect, the output might be type int.
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> framework/ssh_connection.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
> index e096a9e..c9886b2 100644
> --- a/framework/ssh_connection.py
> +++ b/framework/ssh_connection.py
> @@ -62,7 +62,8 @@ class SSHConnection(object):
> def send_expect(self, cmds, expected, timeout=15, verify=False):
> self.logger.info(cmds)
> out = self.session.send_expect(cmds, expected, timeout, verify)
> - self.logger.debug(out.replace(cmds, ''))
> + if isinstance(out, str):
> + self.logger.debug(out.replace(cmds, ''))
> if type(self.history) is list:
> self.history.append({"command": cmds, "name": self.name, "output":
> out})
> return out
> --
> 2.25.1
next prev parent reply other threads:[~2020-08-26 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 1:53 Xiao Qimai
2020-08-26 11:04 ` Xiao, QimaiX [this message]
2020-08-27 2:57 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB224704F3F1A24470C51AEF02FB540@CY4PR1101MB2247.namprd11.prod.outlook.com \
--to=qimaix.xiao@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).