test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2]fix Rx bytes statistics.
@ 2021-01-18  7:09 Xie wei
  2021-01-18  7:09 ` [dts] [PATCH V1 1/2] tests/vf_jumboframe: fix " Xie wei
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2021-01-18  7:09 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

According to dpdk commit e8326d3, fix Rx bytes statistics for i40e.

Xie wei (2):
  tests/vf_jumboframe: fix Rx bytes statistics
  tests/veb_switch: fix Rx bytes statistics

 tests/TestSuite_veb_switch.py    | 10 +---------
 tests/TestSuite_vf_jumboframe.py | 15 +--------------
 2 files changed, 2 insertions(+), 23 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 1/2] tests/vf_jumboframe: fix Rx bytes statistics
  2021-01-18  7:09 [dts] [PATCH V1 0/2]fix Rx bytes statistics Xie wei
@ 2021-01-18  7:09 ` Xie wei
  2021-01-18  7:09 ` [dts] [PATCH V1 2/2] tests/veb_switch: " Xie wei
  2021-01-18  7:35 ` [dts] [PATCH V1 0/2]fix " Xie, WeiX
  2 siblings, 0 replies; 5+ messages in thread
From: Xie wei @ 2021-01-18  7:09 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

According to dpdk commit e8326d3, fix Rx bytes statistics.
After testing, found that:
when send a packet which length is 1513 bytes.
for i40e nic; the statistic from "show port stats 0" is: RX-bytes: 1513,
but before that it show "RX-bytes: 1517".

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index cb77cf31..75480f1f 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -192,11 +192,6 @@ class TestVfJumboFrame(TestCase):
         else:
             return None
 
-    def check_vf_driver(self):
-        output = self.vm_testpmd.execute_cmd("show port info 0")
-        vf0_driver = re.findall("Driver\s*name:\s*(\w+)", output)
-        return vf0_driver[0]
-
     def jumboframes_send_packet(self, pktsize, received=True):
         """
         Send 1 packet to portid
@@ -221,19 +216,11 @@ class TestVfJumboFrame(TestCase):
         rx_bytes -= rx_bytes_ori
         rx_err -= rx_err_ori
 
-        vf_driver = self.check_vf_driver()
-
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
-            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
+            if self.kdriver in ["ixgbe", "ice", "i40e"]:
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-            else:
-                if self.kdriver == "i40e":
-                    if vf_driver == "net_iavf":
-                        self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-                    else:
-                        self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
 
             if self.kdriver == "igb":
                 self.verify(tx_bytes == pktsize, "Tx packet size should be packet size")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 2/2] tests/veb_switch: fix Rx bytes statistics
  2021-01-18  7:09 [dts] [PATCH V1 0/2]fix Rx bytes statistics Xie wei
  2021-01-18  7:09 ` [dts] [PATCH V1 1/2] tests/vf_jumboframe: fix " Xie wei
@ 2021-01-18  7:09 ` Xie wei
  2021-01-18  7:35 ` [dts] [PATCH V1 0/2]fix " Xie, WeiX
  2 siblings, 0 replies; 5+ messages in thread
From: Xie wei @ 2021-01-18  7:09 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

According to dpdk commit e8326d3, fix Rx bytes statistics.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_veb_switch.py | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index cdd2b3c4..915296ff 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -283,18 +283,10 @@ class TestVEBSwitching(TestCase):
 
         self.dut.send_expect("stop", "testpmd>", 2)
         self.session_secondary.send_expect("stop", "testpmd>", 2)
-        out = self.session_secondary.send_expect("show port info 0", "testpmd>")
-        vf1_driver = re.findall("Driver\s*name:\s*(\w+)", out)[0]
 
         vf0_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         vf1_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
-        if self.kdriver == 'ice':
-            vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
-        if self.kdriver == 'i40e':
-            if vf1_driver == 'net_iavf':
-                vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
-            else:
-                vf1_rx_stats[-1] = vf1_rx_stats[-1]
+        vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
         self.verify(vf0_tx_stats[0] != 0, "no packet was sent by VF0")
         self.verify(vf0_tx_stats == vf1_rx_stats, "VF1 failed to receive packets from VF0")
     
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/2]fix Rx bytes statistics.
  2021-01-18  7:09 [dts] [PATCH V1 0/2]fix Rx bytes statistics Xie wei
  2021-01-18  7:09 ` [dts] [PATCH V1 1/2] tests/vf_jumboframe: fix " Xie wei
  2021-01-18  7:09 ` [dts] [PATCH V1 2/2] tests/veb_switch: " Xie wei
@ 2021-01-18  7:35 ` Xie, WeiX
  2021-01-19  9:02   ` Zhao, HaiyangX
  2 siblings, 1 reply; 5+ messages in thread
From: Xie, WeiX @ 2021-01-18  7:35 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Monday, January 18, 2021 3:09 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 0/2]fix Rx bytes statistics.

[-- Attachment #2: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 1958427 bytes --]

[-- Attachment #3: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 53100 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/2]fix Rx bytes statistics.
  2021-01-18  7:35 ` [dts] [PATCH V1 0/2]fix " Xie, WeiX
@ 2021-01-19  9:02   ` Zhao, HaiyangX
  0 siblings, 0 replies; 5+ messages in thread
From: Zhao, HaiyangX @ 2021-01-19  9:02 UTC (permalink / raw)
  To: Xie, WeiX, dts

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie, WeiX
> Sent: Monday, January 18, 2021 15:36
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1 0/2]fix Rx bytes statistics.
> 
> Tested-by:  Xie,WeiX < weix.xie@intel.com>
> 
> Regards,
> Xie Wei
> 
> 
> > -----Original Message-----
> > From: Xie wei [mailto:weix.xie@intel.com]
> > Sent: Monday, January 18, 2021 3:09 PM
> > To: dts@dpdk.org
> > Cc: Xie, WeiX <weix.xie@intel.com>
> > Subject: [dts][PATCH V1 0/2]fix Rx bytes statistics.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-19  9:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18  7:09 [dts] [PATCH V1 0/2]fix Rx bytes statistics Xie wei
2021-01-18  7:09 ` [dts] [PATCH V1 1/2] tests/vf_jumboframe: fix " Xie wei
2021-01-18  7:09 ` [dts] [PATCH V1 2/2] tests/veb_switch: " Xie wei
2021-01-18  7:35 ` [dts] [PATCH V1 0/2]fix " Xie, WeiX
2021-01-19  9:02   ` Zhao, HaiyangX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git