From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19C9DA0508; Wed, 18 May 2022 01:02:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E7844068B; Wed, 18 May 2022 01:02:09 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80080.outbound.protection.outlook.com [40.107.8.80]) by mails.dpdk.org (Postfix) with ESMTP id 3F36840041 for ; Wed, 18 May 2022 01:02:08 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DbdazGYFufOc4wxu3kxLtQKC1BM0ZzVN1CrCpTwAgW4bp+v2UhrOMax1f/ULP/0O1qrUGtOx/6US8vwZKDxNi7H6Ou1GgfTE0iTKL0d/rEAa19dDbe62dJiHgkX8cR4R0q9rczODzzw4iRBTLb9Ladx1G9NmoP71fZVDblw2otnRR6evmS5qTaKXnTE57k/+ZsWoAQmgTwfGZAwtpmcnbbQWPFHYtGQpmEaG5fokwxtR3i86Vpnf/Yxj2P0QDULj8he6KMg53NP6/hmKWciAK0yWX+qShlbdMa7kYOk6yMri8Ea/o3l16fVeT65xXQvV6pMgdDCEiKmJLXUsZXZgYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrTVAx5duw0uZ0wtLY4RZqByLPTjldSIaQQwD7cUjXI=; b=Id5nN1ZrRDmNTmv7IcfVHDIdWVnM+b90BYDCIb6yIKIAUdUyI1FXRb8iB/qoztavhKuVLIvLYeQaMqD6gVmup+9sPmkQbTbbhokNYZ79T5KO2IeZXJcLj6IeqhV2w/2Qqs9UIW2fN7gbtl7mYf0vO4v9e33jQ+nVOLUHsZizRIKT6qRoslyg7S2Z04C3kq0RE99xCUFJyqNbdAi0dspzesXMWi3EdT4joivGYLNdHOkYJPGhvawyAJ36iaFGU2qFfN1eQxC9s62hQn36/wKjYqcnPdLKrrDFqNfflQVN6pieDwB6zSpdc4cbiZyY4Zprthc98MZ9u2JrYyYnHMYO9A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BrTVAx5duw0uZ0wtLY4RZqByLPTjldSIaQQwD7cUjXI=; b=ss38/tnE+Jdpg2liyVqPxk+4gAmh1FBJh4oMHazqNGG1BSKYVf7uxJRwdDdLHEJ/z2b9zC7654guA+bzgDfAbAHUFJdoAz7qa5L3KpiQrZXaRakOF91TVoGrZifBO8AIfaBmyx2hXUzjIQ1ehnK3PQMR7nZX1HSZThkP3MQdeso= Received: from AM6P192CA0036.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::49) by AM4PR0802MB2148.eurprd08.prod.outlook.com (2603:10a6:200:5c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 23:02:06 +0000 Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::80) by AM6P192CA0036.outlook.office365.com (2603:10a6:209:83::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14 via Frontend Transport; Tue, 17 May 2022 23:02:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 23:02:06 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Tue, 17 May 2022 23:02:06 +0000 X-CR-MTA-TID: 64aa7808 Received: from eff973e4750e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A00256B-E138-4583-994B-00245D0F6ABE.1; Tue, 17 May 2022 23:02:00 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eff973e4750e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 23:02:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXo199MW2RtHq1IKtJHFeE+AD0UWcDwEO4K0vqDvqFUF5wqgcX/rtwzSt+PbVF+5Ixizm/oBtaAMLVfEOLfqhFRfU09SNCoSyrX28k3nZGhYZkxROOYCy0fVQ0WfHm9E/bOeQ90bEk2nM3Tl9VfsNgYpzmphqGfLwwwvgT4Rs+7l/fFafYUeRHSVxYnd7yQP/f/5rlmYhHm9xELPcU/I+PHfQb9dNL4nA3kxot9HqgVIZMooAW1G0oKfE6ME+6tocy2YtKwG1rY2uP7TClhMsJPQK4QMI7j3dP4hJHX15s4owYKkFX1oogp+izvvf4oci5U9XNtuk/Tex+APb/ajgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrTVAx5duw0uZ0wtLY4RZqByLPTjldSIaQQwD7cUjXI=; b=L4AXPaL6vB/0zA7VF96b/gW2JTCocvLkEi9aL5JUSNJj+Qk5Gtp3jWxDvUojYlA+w1VcQZlDDn4igZ8O2injUKqwDO+HjYk5uak9cJNKI3SLj6Qm0hDOozxPJUJM5rUMdX1izTgK+rpgNK+u0TEVws+/nxGkcsmHWBcTBMWir3AJksVrjTLAJ2hqyACYkUET47Gelrq2yOZYlZrGuR8gwISfFKa+zPjQY5K6lswPMzYul8Xp45WljhnmbVtPIWpU6l8JNrDbY6fT6GvJhZEHMklJrW04c4Sqck95ksWoSG+5Fh6sKl2EG+6EX/cFwLnOyN+yXVy/Opu+YZHXA7nRmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BrTVAx5duw0uZ0wtLY4RZqByLPTjldSIaQQwD7cUjXI=; b=ss38/tnE+Jdpg2liyVqPxk+4gAmh1FBJh4oMHazqNGG1BSKYVf7uxJRwdDdLHEJ/z2b9zC7654guA+bzgDfAbAHUFJdoAz7qa5L3KpiQrZXaRakOF91TVoGrZifBO8AIfaBmyx2hXUzjIQ1ehnK3PQMR7nZX1HSZThkP3MQdeso= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AM6PR08MB3895.eurprd08.prod.outlook.com (2603:10a6:20b:81::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 23:01:58 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f99f:a9c3:fe71:368a]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f99f:a9c3:fe71:368a%5]) with mapi id 15.20.5250.018; Tue, 17 May 2022 23:01:58 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , =?iso-8859-2?Q?Juraj_Linke=B9?= , "lijuan.tu@intel.com" , "ohilyard@iol.unh.edu" CC: "dts@dpdk.org" , David Marchand , nd , "bruce.richardson@intel.com" Subject: RE: [PATCH v1] cleanup: rename base classes Thread-Topic: [PATCH v1] cleanup: rename base classes Thread-Index: AQHYaZOCRbuCY86o2k+H58LSxE6UWK0iWJmggABIkICAAQ5hoA== Date: Tue, 17 May 2022 23:01:57 +0000 Message-ID: References: <20220516133340.1056427-1-juraj.linkes@pantheon.tech> <16365457.Ash8RoxBsO@thomas> In-Reply-To: <16365457.Ash8RoxBsO@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8943E0197D18F940A09748783A14E71A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 423988a5-8816-43ba-2530-08da3859438e x-ms-traffictypediagnostic: AM6PR08MB3895:EE_|AM5EUR03FT021:EE_|AM4PR0802MB2148:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FAQLzDRFgNe7w/15JEEySJSzptCjfxhnsMWGjia9hRhvXxQeCcwFDG7cRq+g3tkoxRN8SErjYpyT+IOegqe3f5oZsSPn5YPVsHKYMTwAblF9YE1cmnlr2NUFzHw9S2FavrRTPd8DwzIoboULsTfikBqqq2M9FRVdlUZv78LSNxHE9SvX+1hi4CHCitkdGmdiy9rrnqPUj2biYwdum7kihitEcfdewHY5sd/Hqd06KBtW7+PCSZDhHID0NrzmsF3d9Kh82sCx2ahon8VWLgOIlsizturUO2iBF0VKcmlnBhwCFNXm0cADyfH7Ll4NsTcTsMvZLpWE9nhMj2clq4MaUtrpzMjKzhaqMlZYro1gs0ZzSOfoV63q8G/rS2GBz2CfGyvqri9lWiv5PZNOUy6/jAOQgcogmkfqpYctdsgDTsbVQiUDi2aqWOrlN5bo1OJWeLipowkGjLIWcKzl3bjWsRP28a0q7KxX1rTFdTFl/QOH9/vgqGH5twdbExleSmcscOckGweLnkJ1nvIIsOH2A67VrXMdGCJ8Ze3TNXiaA8zX6BF3eKOXWV9CY+y3EzS02HNm4VsG+QHDydZ1B5PDSK97hNF5Im8TPthGLWLd8q2Yzin+Uh1M3ytDekSn4lmn6AmnwGCX7XdfbV2D/Wr7yhjK6vcVgRrtUMz7hq7Y+k8AdnzQ0kUBz+RS5w2cWLEp89OPtD1OTwzq0x90SNHH5g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55016003)(52536014)(33656002)(38070700005)(8676002)(66476007)(66946007)(54906003)(110136005)(2906002)(4326008)(64756008)(66446008)(66556008)(86362001)(38100700002)(26005)(9686003)(7696005)(186003)(6506007)(508600001)(8936002)(122000001)(76116006)(71200400001)(316002)(5660300002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3895 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 92ba94fd-56f8-4cca-7365-08da38593e9c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nHM6OsipSzFy/E7Qb0CecDaTky6IciIjPU1YpmGMyPkKB+1ZmSyv9iMzJE53n/Me8+5/TXcoBh5ArJUInXdk6jg9tGZL+nu8y/Yj/s6KT70Gg7bwWo3rgABDa49a1fqYLp5ON8LjAMnvwOQ9fLy2kQDt0QwpT/MCDH33ffopjnRrgc2iqJ5O1ogeBR+biZGj8E9i93zahc2jRiTEZ0HExu6D3ZpduQlgGsTzCMThoYEzw4MnfUg+52rAmQ7eeU3EnmXTv87trUs04qBBoA4ybt3tMNoHHQKhQmLpTmqNMU6ddOBoh9vfJ+1awxnvvYBnmWCr+Bf4GHcRt2bcrQ6c3SCAF0cN0t8iggRIc1aDMWpOpbCF3c1utjWiN/PSBZcxJf2Ft9/n48UEHGOmLnNPII/Mp4xyS95NnzexINDW3eLIfZVIvWo2V+xCQCn2Ks33ztDaXMsYRfBX37UWUp6ARfcPIdm8dUm3B7ii3Wiv4uog6+GtAEu9IBK8nSYkcz6my5DxoOP9EQVXVQokdOeLs4Z98vAEI6CcR6MnEiLtcdFXJYoR7kyMz3nvzY1WoLM3U9KNSvDiksr6Fnymp8VDeRj/oCd45NQ1fRPuV6oAr4jMseqNTOc9QQSMjNkN/Q2Qnwu4UXiXezqNcu8RvwaTrIB179VKSFhC8SKs96yCy6jg8iLfRpqcOi6JMVBpXhzR X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(52536014)(70206006)(8936002)(70586007)(5660300002)(508600001)(8676002)(107886003)(33656002)(4326008)(40460700003)(7696005)(54906003)(26005)(55016003)(6506007)(86362001)(356005)(336012)(47076005)(81166007)(2906002)(36860700001)(82310400005)(186003)(110136005)(316002)(9686003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 23:02:06.2346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 423988a5-8816-43ba-2530-08da3859438e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2148 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org >=20 > > > The current naming of the base elements DTS works with is a bit > > > confusing, which this patch attemps to ameliorate. The basic > > > elements could be divided into and described in short as follows: > > > * A node: a broad term encompassing a host where any of the DTS > > > elements are present. This could be a physical or virtualized server > > > or a container. >=20 > OK >=20 > > > * The control node: the host where DTS runs >=20 > OK >=20 > > > * An SUT (system under test) node: This is where DPDK along with the > > > tested hardware resides. The system comprises DPDK and the hardware. >=20 > Is there any difference between a SUT and a "tested node"? >=20 > > > * A traffic generator node: The node where the traffic generator is > > > present, such as Trex, Scapy or a hardware traffic generator (e.g. > > > IXIA) >=20 > OK >=20 > > > All references to DUT were removed. This is because it was used to > > > mean both the server where DPDK/NIC are present and the DUT (device > > > under test, i.e. the NIC) in different contexts. Where applicable, > > > DUT was replaced with NIC and the rest were replaced with SUT. With > > > this change, it's clear what's meant and the abbreviations are very > > > different, which removes that layer of confusion. >=20 > "NIC" does not mean it is a device under test. > Also we could have other kind of devices under test, like crypto cards. May be for other cards, we could use "XxxAccelerator"? We could leave "NIC"= as is. >=20 > > > Rename the following classes: > > > Crb -> Node > > > Dut -> SutNode > > > Tester -> TrafficGeneratorNode > > > DPDKdut -> DpdkSut > > > DPDKtester -> DpdkTrafficGenerator > > > VirtDut -> VirtSut > > > CrbsConf -> TopologyConf > > > PktgenConf -> PacketGeneratorConf >=20 > I think you need to choose between "TrafficGenerator" and > "PacketGenerator". +1 for a single term >=20