test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side
@ 2015-10-23  4:59 haifeng
  2015-10-23  5:14 ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: haifeng @ 2015-10-23  4:59 UTC (permalink / raw)
  To: dts

Signed-off-by: haifeng <haifengx.tang@intel.com>
---
 tests/TestSuite_fdir.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
index 1372674..f186eb2 100644
--- a/tests/TestSuite_fdir.py
+++ b/tests/TestSuite_fdir.py
@@ -99,7 +99,8 @@ class TestFdir(TestCase, IxiaPacketGenerator):
         self.dut.send_expect("start", "testpmd>")
         self.tester.scapy_execute()
         time.sleep(.5)
-        out = self.dut.send_expect("stop", "testpmd>")
+        out = self.dut.session.get_session_before()
+        self.dut.send_expect("stop", "testpmd>")
 
         if(self.nic in ["kawela", "niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"]):
             if ("fwd" == self.fdir_type):
-- 
1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side
  2015-10-23  4:59 [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side haifeng
@ 2015-10-23  5:14 ` Liu, Yong
  2015-10-23  5:27   ` Tang, HaifengX
  0 siblings, 1 reply; 5+ messages in thread
From: Liu, Yong @ 2015-10-23  5:14 UTC (permalink / raw)
  To: haifeng, dts

Haifeng,
There's one function get_session_output defined in crb.py can match the 
requirement. Please do not call low level APIs directly.

On 10/23/2015 12:59 PM, haifeng wrote:
> Signed-off-by: haifeng <haifengx.tang@intel.com>
> ---
>   tests/TestSuite_fdir.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
> index 1372674..f186eb2 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -99,7 +99,8 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>           self.dut.send_expect("start", "testpmd>")
>           self.tester.scapy_execute()
>           time.sleep(.5)
> -        out = self.dut.send_expect("stop", "testpmd>")
> +        out = self.dut.session.get_session_before()
> +        self.dut.send_expect("stop", "testpmd>")
>   
>           if(self.nic in ["kawela", "niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"]):
>               if ("fwd" == self.fdir_type):

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side
  2015-10-23  5:14 ` Liu, Yong
@ 2015-10-23  5:27   ` Tang, HaifengX
  0 siblings, 0 replies; 5+ messages in thread
From: Tang, HaifengX @ 2015-10-23  5:27 UTC (permalink / raw)
  To: Liu, Yong, dts

Ok, I will change the code, and submit it again.


thanks

-----Original Message-----
From: Liu, Yong 
Sent: Friday, October 23, 2015 1:14 PM
To: Tang, HaifengX; dts@dpdk.org
Subject: Re: [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side

Haifeng,
There's one function get_session_output defined in crb.py can match the requirement. Please do not call low level APIs directly.

On 10/23/2015 12:59 PM, haifeng wrote:
> Signed-off-by: haifeng <haifengx.tang@intel.com>
> ---
>   tests/TestSuite_fdir.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index 
> 1372674..f186eb2 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -99,7 +99,8 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>           self.dut.send_expect("start", "testpmd>")
>           self.tester.scapy_execute()
>           time.sleep(.5)
> -        out = self.dut.send_expect("stop", "testpmd>")
> +        out = self.dut.session.get_session_before()
> +        self.dut.send_expect("stop", "testpmd>")
>   
>           if(self.nic in ["kawela", "niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"]):
>               if ("fwd" == self.fdir_type):

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side
  2015-10-23  5:22 haifeng
@ 2015-10-23  5:29 ` Liu, Yong
  0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2015-10-23  5:29 UTC (permalink / raw)
  To: Tang, HaifengX, dts

Haifeng, please remove your debug code.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of haifeng
> Sent: Friday, October 23, 2015 1:22 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] fix test script get the output from the pmd driver
> correctly if the command inputs aren't from tester side
> 
> Signed-off-by: haifeng <haifengx.tang@intel.com>
> ---
>  tests/TestSuite_fdir.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
> index f186eb2..8c2f6fd 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -99,7 +99,8 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          self.dut.send_expect("start", "testpmd>")
>          self.tester.scapy_execute()
>          time.sleep(.5)
> -        out = self.dut.session.get_session_before()
> +        out = self.dut.get_session_output()
> +        print out
>          self.dut.send_expect("stop", "testpmd>")
> 
>          if(self.nic in ["kawela", "niantic", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single"]):
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side
@ 2015-10-23  5:22 haifeng
  2015-10-23  5:29 ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: haifeng @ 2015-10-23  5:22 UTC (permalink / raw)
  To: dts

Signed-off-by: haifeng <haifengx.tang@intel.com>
---
 tests/TestSuite_fdir.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
index f186eb2..8c2f6fd 100644
--- a/tests/TestSuite_fdir.py
+++ b/tests/TestSuite_fdir.py
@@ -99,7 +99,8 @@ class TestFdir(TestCase, IxiaPacketGenerator):
         self.dut.send_expect("start", "testpmd>")
         self.tester.scapy_execute()
         time.sleep(.5)
-        out = self.dut.session.get_session_before()
+        out = self.dut.get_session_output()
+        print out
         self.dut.send_expect("stop", "testpmd>")
 
         if(self.nic in ["kawela", "niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"]):
-- 
1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-23  5:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-23  4:59 [dts] [PATCH] fix test script get the output from the pmd driver correctly if the command inputs aren't from tester side haifeng
2015-10-23  5:14 ` Liu, Yong
2015-10-23  5:27   ` Tang, HaifengX
2015-10-23  5:22 haifeng
2015-10-23  5:29 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).