From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1B047C3BE for ; Thu, 26 Nov 2015 11:29:49 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 26 Nov 2015 02:29:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,346,1444719600"; d="scan'208";a="859803104" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 26 Nov 2015 02:29:48 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 Nov 2015 02:29:48 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 Nov 2015 02:29:47 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by shsmsx102.ccr.corp.intel.com ([169.254.2.42]) with mapi id 14.03.0248.002; Thu, 26 Nov 2015 18:29:46 +0800 From: "Tang, HaifengX" To: "Liu, Yong" , "Van Haaren, Harry" , "dts@dpdk.org" Thread-Topic: [dts] [DTS][PATCH] fix tx crc issue Thread-Index: AQHRJ1dlmYsQlDFi1Eylzrj5KfNqDJ6r8XIAgAAd5oCAAO6/gIABHc2g Date: Thu, 26 Nov 2015 10:29:45 +0000 Message-ID: References: <1448438158-3657-1-git-send-email-haifengx.tang@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10F6E931@SHSMSX103.ccr.corp.intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10F6F296@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E10F6F296@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [DTS][PATCH] fix tx crc issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 10:29:50 -0000 Yeah, I will check the nic again. thanks -----Original Message----- From: Liu, Yong=20 Sent: Thursday, November 26, 2015 9:26 AM To: Van Haaren, Harry; Tang, HaifengX; dts@dpdk.org Subject: RE: [dts] [DTS][PATCH] fix tx crc issue Thanks for clear the message, Harry. Haifeng, please take care packet lengt= h of kawela_4. If it's different from other NICs, please submit one work re= quest for it. > -----Original Message----- > From: Van Haaren, Harry > Sent: Wednesday, November 25, 2015 7:12 PM > To: Liu, Yong; Tang, HaifengX; dts@dpdk.org > Subject: RE: [dts] [DTS][PATCH] fix tx crc issue >=20 > Hi All, >=20 > Recently I've removed all CRC bytes from the byte counter statistics. >=20 > This means when --crc-strip is enabled, or disabled, the byte counters=20 > should remain the same. >=20 > These changes apply to igb, ixgbe, i40e, while fmk10k already strips=20 > CRC bytes from its counters. >=20 > These patches were merged into dpdk.org master recently, commits > 156c5a8 e1000/igb > c03fcee ixgbe > 0834d15 i40e >=20 >=20 > Note that VLAN stripping will still affect byte stats, same as before. >=20 >=20 > If there are any questions regarding testing the byte statistics, feel=20 > free to ask. >=20 > -Harry >=20 >=20 >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong > > Sent: Wednesday, November 25, 2015 9:25 AM > > To: Tang, HaifengX ; dts@dpdk.org > > Subject: Re: [dts] [DTS][PATCH] fix tx crc issue > > > > Some comments below, thanks. > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of haifeng > > > Sent: Wednesday, November 25, 2015 3:56 PM > > > To: dts@dpdk.org > > > Subject: [dts] [DTS][PATCH] fix tx crc issue > > > > > > Signed-off-by: haifeng > > > --- > > > tests/TestSuite_shutdown_api.py | 27 ++++++++------------------- > > > 1 file changed, 8 insertions(+), 19 deletions(-) > > > > > > diff --git a/tests/TestSuite_shutdown_api.py=20 > > > b/tests/TestSuite_shutdown_api.py index 23888f4..411e4bf 100644 > > > --- a/tests/TestSuite_shutdown_api.py > > > +++ b/tests/TestSuite_shutdown_api.py > > > @@ -82,7 +82,7 @@ class TestShutdownApi(TestCase): > > > stats =3D output.get_pmd_stats(portid) > > > return stats > > > > > > - def check_forwarding(self, ports=3DNone, pktSize=3D68, received= =3DTrue, > > > vlan=3DFalse, promisc=3DFalse, crcStrip=3DFalse): > > > + def check_forwarding(self, ports=3DNone, pktSize=3D68,=20 > > > + received=3DTrue, > > > vlan=3DFalse, promisc=3DFalse, crcStrip=3DTrue): > > > > The parameter "crcStrip" here is mean enable crc strip feature on port. > > Please do not change the default for most case not enable crc strip. > > > > If packet length not include crc all the time, this parameter will=20 > > be > useless. > > Please remove it from function parameters. > > > > > if ports is None: > > > ports =3D self.ports > > > if len(ports) =3D=3D 1: > > > @@ -146,25 +146,14 @@ class TestShutdownApi(TestCase): > > > # RRC will always strip rx/tx vlan > > > rx_bytes_exp -=3D 4 > > > tx_bytes_exp -=3D 4 > > > - elif self.nic in ["fortville_eagle", "fortville_spirit", > > > - "fortville_spirit_single", "bartonhills"]: > > > - # some NIC will always strip tx crc > > > - tx_bytes_exp -=3D 4 > > > - if vlan is True: > > > - # vlan strip default is on > > > - tx_bytes_exp -=3D 4 > > > - elif self.nic in ["springville", "powerville"]: > > > - if vlan is True: > > > - # vlan strip default is on > > > - tx_bytes_exp -=3D 4 > > > else: > > > - # some NIC will always include tx crc > > > - if crcStrip is True: > > > - rx_bytes_exp -=3D 4 > > > - if vlan is True: > > > - # vlan strip default is on > > > - tx_bytes_exp -=3D 4 > > > - > > > > Here maybe one bug for all packet length should be the same between NIC= s. > > > > > + if self.nic not in ['kawela_4']: > > > + tx_bytes_exp -=3D 4 > > > + if crcStrip is True: > > > + rx_bytes_exp -=3D 4 > > > + if vlan is True: > > > + tx_bytes_exp -=3D 4 > > > + > > > if received: > > > self.verify(p0tx_pkts =3D=3D p1rx_pkts, "Wrong TX pkts > p0_tx=3D%d, > > > p1_rx=3D%d" % (p0tx_pkts, p1rx_pkts)) > > > self.verify(p1rx_bytes =3D=3D rx_bytes_exp, "Wrong Rx=20 > > > bytes p1_rx=3D%d, expect=3D%d" % (p1rx_bytes, rx_bytes_exp)) > > > -- > > > 1.9.3