From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AF00D255 for ; Wed, 28 Jan 2015 07:29:59 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 27 Jan 2015 22:29:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,479,1418112000"; d="scan'208";a="677172088" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2015 22:29:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 28 Jan 2015 14:29:54 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.231]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0195.001; Wed, 28 Jan 2015 14:29:53 +0800 From: "Xu, HuilongX" To: "Qiu, Michael" , "dts@dpdk.org" Thread-Topic: [dts] [ PATCH V2] update framework for support fortville NIC test. Thread-Index: AQHQOfwvAVMpUhLZ2kiDEZTW/Fi6JJzVEtDw Date: Wed, 28 Jan 2015 06:29:51 +0000 Message-ID: References: <1422338041-14532-1-git-send-email-huilongx.xu@intel.com> <533710CFB86FA344BFBF2D6802E60286CBAAD6@SHSMSX101.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E60286CBAC40@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CBAC40@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [ PATCH V2] update framework for support fortville NIC test. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 06:30:00 -0000 Hi Michael, I will remove the code " if not os.path.exists("/sys/bus/pci/drivers/i40e/"= +"0000:"+pci_bus):" in v3 patch, The code " self.send_expect("echo 0000:%s > /sys/bus/pci/drivers/i40e/bind"= % pci_bus, "# ")" for dut and tester NIC restore default kernel driver, wh= en finish test. Thanks a lot. -----Original Message----- From: Qiu, Michael=20 Sent: Tuesday, January 27, 2015 4:46 PM To: Xu, HuilongX; dts@dpdk.org Subject: Re: [dts] [ PATCH V2] update framework for support fortville NIC t= est. On 1/27/2015 2:53 PM, Xu, HuilongX wrote: > Hi Michael, > Thanks a lot for your comments. > You can check my V2 patch. > >> + elif pci_id in ('8086:1583','8086:1584','8086:1572'): >> + if not os.path.exists("/sys/bus/pci/drivers/i40e/"+= "0000:"+pci_bus): > This code is only support check the driver in tester, can't check dut, so= it's a bug for check the driver status. > Maybe we can send a new patch for fix check driver stats. It need includ= e all driver eg, ixgeb, igb,i40e,e1000... > > Thanks a lot > > -----Original Message----- > From: Qiu, Michael=20 > Sent: Tuesday, January 27, 2015 2:41 PM > To: Xu, HuilongX; dts@dpdk.org > Subject: Re: [dts] [ PATCH V2] update framework for support fortville NIC= test. > > Hi, huilong > > Have you seen my comments with your v1 patch? > > Also you'd better to make update patch within the original thread. > > Thanks, > Michael > On 1/27/2015 1:54 PM, huilongx.xu wrote: >> execution_fortville.cfg is the test case list for fortville NIC >> >> crb.py, add fortville NIC kernel driver(i40e) in dts >> >> settings.py, add fortville NIC info in dts >> >> test_case.py, insmod and used i40e for fortvill NIC >> >> Signed-off-by: huilongx.xu >> --- >> execution_fortville.cfg | 21 +++++++++++++++++++++ >> framework/crb.py | 9 ++++++++- >> framework/settings.py | 6 ++++++ >> framework/test_case.py | 4 ++++ >> 4 files changed, 39 insertions(+), 1 deletions(-) >> create mode 100644 execution_fortville.cfg >> >> diff --git a/execution_fortville.cfg b/execution_fortville.cfg >> new file mode 100644 >> index 0000000..15f2ccf >> --- /dev/null >> +++ b/execution_fortville.cfg >> @@ -0,0 +1,21 @@ >> +[Execution1] >> +crbs=3D >> +drivername=3D >> +test_suites=3D >> + cmdline, >> + hello_world, >> + multiprocess, >> + blacklist >> +targets=3D >> + x86_64-native-linuxapp-gcc >> +parameters=3Dnic_type=3Dfortville_eagle:func=3Dtrue >> + >> +[Execution2] >> +crbs=3D >> +drivername=3D >> +test_suites=3D >> + l2fwd, >> + l3fwd >> +targets=3D >> + x86_64-native-linuxapp-gcc >> +parameters=3Dnic_type=3Dfortville_eagle:perf=3Dtrue >> diff --git a/framework/crb.py b/framework/crb.py >> index d41f51b..efd23b2 100644 >> --- a/framework/crb.py >> +++ b/framework/crb.py >> @@ -150,7 +150,11 @@ class Crb(object): >> self.send_expect("modprobe e1000e", "# ", 20) >> self.send_expect("modprobe e1000", "# ", 20) >> self.send_expect("modprobe virtio_net", "# ", 20) >> - >> +=20 >> + self.send_expect("modprobe i40e", "# ", 60) >> + out =3D self.send_expect("lsmod |grep i40e", "# ", 30) >> + if "i40e" not in out: >> + self.logger.error("please check the os install i40e driver a= lready."); >> try: >> for (pci_bus, pci_id) in self.pci_devices_info: >> """ >> @@ -173,6 +177,9 @@ class Crb(object): >> self.send_expect("echo -n 0000:%s > /sys/bus/pc= i/drivers/e1000/bind" % pci_bus, "# ") >> elif pci_id in ('1af4:1000'): >> self.send_expect("echo 0000%s > /sys/bus/pci/driver= s/virtio-pci/bind" % pci_bus, "# ") >> + elif pci_id in ('8086:1583','8086:1584','8086:1572'): >> + if not os.path.exists("/sys/bus/pci/drivers/i40e/"+= "0000:"+pci_bus): You need to remove this line I think, not acceptable, as you=20 os.path.exists, then why need self.send_expect() ? Actually, all these lines will be removed later. Thanks, Michael >> + self.send_expect("echo 0000:%s > /sys/bus/pci/d= rivers/i40e/bind" % pci_bus, "# ") >> else: >> continue >> =20 >> diff --git a/framework/settings.py b/framework/settings.py >> index 2ef8db8..40b81fb 100644 >> --- a/framework/settings.py >> +++ b/framework/settings.py >> @@ -55,6 +55,9 @@ NICS =3D { >> 'I217LM': '8086:153a', >> 'I218V': '8086:1559', >> 'I218LM': '8086:155a', >> + 'fortville_eagle': '8086:1572', >> + 'fortville_spirit': '8086:1583', >> + 'fortville_spirit_single': '8086:1584', >> } >> =20 >> DRIVERS =3D { >> @@ -80,6 +83,9 @@ DRIVERS =3D { >> 'I217LM': 'igb', >> 'I218V': 'igb', >> 'I218LM': 'igb', >> + 'fortville_eagle': 'i40e', >> + 'fortville_spirit': 'i40e', >> + 'fortville_spirit_single':'i40e' >> } >> =20 >> """ >> diff --git a/framework/test_case.py b/framework/test_case.py >> index 706003f..07fdc36 100644 >> --- a/framework/test_case.py >> +++ b/framework/test_case.py >> @@ -76,5 +76,9 @@ class TestCase(object): >> bitrate *=3D 10 # 10 Gb NICs >> elif self.nic =3D=3D "avoton2c5": >> bitrate *=3D 2.5 # 2.5 Gb NICs >> + elif self.nic in ["fortville_spirit", "fortville_spirit_single"= ]: >> + bitrate *=3D 40 >> + elif self.nic =3D=3D 'fortville_eagle': >> + bitrate *=3D 10 >> =20 >> return bitrate * num_ports / 8 / (frame_size + 20) >