From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7C27837AA for ; Thu, 28 May 2015 07:47:34 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 27 May 2015 22:47:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,511,1427785200"; d="scan'208";a="578018125" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga003.jf.intel.com with ESMTP; 27 May 2015 22:47:31 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 28 May 2015 13:44:48 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0224.002; Thu, 28 May 2015 13:44:35 +0800 From: "Xu, HuilongX" To: "Fu, JingguoX" , "dts@dpdk.org" Thread-Topic: [DTS][PATCH 1/2] scatter: add scatter test suite Thread-Index: AQHQmQU+82ZeD3gC5EKajN3TMGWaB52Q3tqg Date: Thu, 28 May 2015 05:44:35 +0000 Message-ID: References: <1432790077-26182-1-git-send-email-jingguox.fu@intel.com> In-Reply-To: <1432790077-26182-1-git-send-email-jingguox.fu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-hashedpuzzle: CL7y C9go DcF/ DsYC EZvb FFqZ Gb1s Hhho HnyQ IMLg JOM1 JSTA JVfT K12n K9Vu LXws; 1; ZAB0AHMAQABkAHAAZABrAC4AbwByAGcA; Sosha1_v1; 7; {E67361BC-CE5E-44DA-9925-64C1E386FE87}; aAB1AGkAbABvAG4AZwB4AC4AeAB1AEAAaQBuAHQAZQBsAC4AYwBvAG0A; Thu, 28 May 2015 05:44:30 GMT; UgBFADoAIABbAEQAVABTAF0AWwBQAEEAVABDAEgAIAAxAC8AMgBdACAAcwBjAGEAdAB0AGUAcgA6ACAAYQBkAGQAIABzAGMAYQB0AHQAZQByACAAdABlAHMAdAAgAHMAdQBpAHQAZQA= x-cr-puzzleid: {E67361BC-CE5E-44DA-9925-64C1E386FE87} x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [DTS][PATCH 1/2] scatter: add scatter test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 05:47:35 -0000 Hi jinguo, Pls see my comments as blow. Thanks a lot > -----Original Message----- > From: Fu, JingguoX > Sent: Thursday, May 28, 2015 1:15 PM > To: dts@dpdk.org > Cc: Xu, HuilongX; Tang, HaifengX; Fu, JingguoX > Subject: [DTS][PATCH 1/2] scatter: add scatter test suite >=20 > Signed-off-by: Jingguo Fu > --- > tests/TestSuite_scatter.py | 140 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 140 insertions(+) > create mode 100644 tests/TestSuite_scatter.py >=20 > diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py > new file mode 100644 > index 0000000..643fe4a > --- /dev/null > +++ b/tests/TestSuite_scatter.py > @@ -0,0 +1,140 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +""" > +DPDK Test suite. > +Test Scattered Packets. > +""" > +import dts > +from test_case import TestCase > +from pmd_output import PmdOutput > +# > +# > +# Test class. > +# > +class TestScatter(TestCase): > + # > + # > + # > + # Test cases. > + # > + def set_up_all(self): > + """ > + Run at the start of each test suite. > + Scatter Prerequistites > + """ > + dutPorts =3D self.dut.get_ports(self.nic) > + # Verify that enough ports are available > + self.verify(len(dutPorts) >=3D 2, "Insufficient ports") > + self.pmdout =3D PmdOutput(self.dut) > + > + def scatter_pktgen_send_packet(self, sPortid, rPortid, pktsize, > num=3D1): > + """ > + Functional test for scatter packets. > + """ > + sport =3D self.tester.get_local_port(sPortid) > + sintf =3D self.tester.get_interface(sport) > + smac =3D self.dut.get_mac_address(sPortid) > + rport =3D self.tester.get_local_port(rPortid) > + rintf =3D self.tester.get_interface(rport) > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#") > + self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#") > + > + self.tester.scapy_background() > + self.tester.scapy_append( > + 'p =3D sniff(filter=3D"ip",iface=3D"%s", count=3D%d)' % (rin= tf, num)) > + self.tester.scapy_append('RESULT =3D str(p)') > + The number 18 and 20 , I think 18 means ethtype head + crc size= , 20 means IP head. If yes, would you used the define from setting? > + pktlen =3D pktsize - 18 > + padding =3D pktlen - 20 > + > + self.tester.scapy_foreground() > + self.tester.scapy_append( > + 'sendp([Ether(dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s)= ], > iface=3D"%s")' % (smac, pktlen, padding, sintf)) > + self.tester.scapy_execute() > + res =3D self.tester.scapy_get_result() > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#") > + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#") > + return res > + > + def set_up(self): > + """ > + Run before each test case. > + """ > + pass > + > + def test_scatter_mbuf_2048(self): > + """ > + Scatter 2048 mbuf > + """ Who will use coreMask, if not any need use, I think you can dele= te this code > + cores =3D self.dut.get_core_list('1S/2C/2T') > + coreMask =3D dts.create_mask(cores) > + dutPorts =3D self.dut.get_ports(self.nic) > + portMask =3D dts.create_mask(dutPorts[:2]) > + > + # set the mbuf size to 1024 > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: Would you usd "Default" replace "1S/2C/2T" > + out =3D self.pmdout.start_testpmd( > + "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D2048 --portma= sk=3D%s > --max-pkt-len=3D9000" % portMask) > + else: > + out =3D self.pmdout.start_testpmd( > + "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D1024 -- > portmask=3D%s" % portMask) > + self.verify("Error" not in out, "launch error 1") > + > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + self.dut.send_expect("set fwd mac", "testpmd> ", 120) > + self.dut.send_expect("start", "testpmd> ") > + > + for offset in [-1, 0, 1, 4, 5]: > + if self.nic in ["niantic", "fortville_eagle", > "fortville_spirit", "fortville_spirit_single"]: > + ret =3D self.scatter_pktgen_send_packet( > + dutPorts[0], dutPorts[1], 2048 + offset) > + else: > + ret =3D self.scatter_pktgen_send_packet( > + dutPorts[0], dutPorts[1], 1024 + offset) > + self.verify("load=3D'P" in ret, "packet receive error") > + > + self.dut.send_expect("stop", "testpmd> ") > + self.dut.send_expect("quit", "# ", 30) > + > + def tear_down(self): > + """ > + Run after each test case. > + """ > + pass > + > + def tear_down_all(self): > + """ > + Run after each test suite. > + """ > + pass > -- > 2.1.0