From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A3A0A8E94 for ; Wed, 25 Nov 2015 11:36:32 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 25 Nov 2015 02:36:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,342,1444719600"; d="scan'208";a="859403119" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 25 Nov 2015 02:36:31 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 25 Nov 2015 02:36:30 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 25 Nov 2015 02:36:30 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.88]) with mapi id 14.03.0248.002; Wed, 25 Nov 2015 18:36:29 +0800 From: "Xu, HuilongX" To: "Tang, HaifengX" , "dts@dpdk.org" Thread-Topic: [dts] [DTS][PATCH] fix tx crc issue Thread-Index: AQHRJ1d6yLCj+d8wIEy1i95NhO7cAZ6sisCg Date: Wed, 25 Nov 2015 10:36:28 +0000 Message-ID: References: <1448438158-3657-1-git-send-email-haifengx.tang@intel.com> In-Reply-To: <1448438158-3657-1-git-send-email-haifengx.tang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [DTS][PATCH] fix tx crc issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2015 10:36:33 -0000 Hi haifeng, As we know, crc strip always enable, and it not need to test. Maybe we can = remove count crc size when we check package size, We can add comments in our test plan and code. Thanks a lot=20 > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of haifeng > Sent: Wednesday, November 25, 2015 3:56 PM > To: dts@dpdk.org > Subject: [dts] [DTS][PATCH] fix tx crc issue >=20 > Signed-off-by: haifeng > --- > tests/TestSuite_shutdown_api.py | 27 ++++++++------------------- > 1 file changed, 8 insertions(+), 19 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py > index 23888f4..411e4bf 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -82,7 +82,7 @@ class TestShutdownApi(TestCase): > stats =3D output.get_pmd_stats(portid) > return stats >=20 > - def check_forwarding(self, ports=3DNone, pktSize=3D68, received=3DTr= ue, > vlan=3DFalse, promisc=3DFalse, crcStrip=3DFalse): > + def check_forwarding(self, ports=3DNone, pktSize=3D68, received=3DTr= ue, > vlan=3DFalse, promisc=3DFalse, crcStrip=3DTrue): > if ports is None: > ports =3D self.ports > if len(ports) =3D=3D 1: > @@ -146,25 +146,14 @@ class TestShutdownApi(TestCase): > # RRC will always strip rx/tx vlan > rx_bytes_exp -=3D 4 > tx_bytes_exp -=3D 4 > - elif self.nic in ["fortville_eagle", "fortville_spirit", > - "fortville_spirit_single", "bartonhills"]: > - # some NIC will always strip tx crc > - tx_bytes_exp -=3D 4 > - if vlan is True: > - # vlan strip default is on > - tx_bytes_exp -=3D 4 > - elif self.nic in ["springville", "powerville"]: > - if vlan is True: > - # vlan strip default is on > - tx_bytes_exp -=3D 4 > else: > - # some NIC will always include tx crc > - if crcStrip is True: > - rx_bytes_exp -=3D 4 > - if vlan is True: > - # vlan strip default is on > - tx_bytes_exp -=3D 4 > - > + if self.nic not in ['kawela_4']: > + tx_bytes_exp -=3D 4 > + if crcStrip is True: > + rx_bytes_exp -=3D 4 > + if vlan is True: > + tx_bytes_exp -=3D 4 > + > if received: > self.verify(p0tx_pkts =3D=3D p1rx_pkts, "Wrong TX pkts p0_tx= =3D%d, > p1_rx=3D%d" % (p0tx_pkts, p1rx_pkts)) > self.verify(p1rx_bytes =3D=3D rx_bytes_exp, "Wrong Rx bytes > p1_rx=3D%d, expect=3D%d" % (p1rx_bytes, rx_bytes_exp)) > -- > 1.9.3