test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH]tests multiprocess: fix commands send to wrong session
Date: Wed, 25 Nov 2015 10:41:05 +0000	[thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A4637AB16D9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1448441476-4352-1-git-send-email-lijuanx.a.tu@intel.com>

Hi lijuan,
Could you used kill_all function for kill dpdk app process,
It in crb.py, you can check this function.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Wednesday, November 25, 2015 4:51 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH]tests multiprocess: fix commands send to wrong
> session
> 
> if alt_session is running app simple_mp
> kill_all send shell-cmd to alt_session
> so exception happened
> 
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>  tests/TestSuite_multiprocess.py | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/TestSuite_multiprocess.py
> b/tests/TestSuite_multiprocess.py
> index 7bc005d..7cce1f4 100644
> --- a/tests/TestSuite_multiprocess.py
> +++ b/tests/TestSuite_multiprocess.py
> @@ -73,17 +73,33 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>          """
>          Run before each test case.
>          """
> -        pass
> +        self.kill_mp()
> +
> +    def kill_mp(self):
> +        """
> +        Kill all simple_mp applications
> +        """
> +        self.alt_session = False
> +        try:
> +            out = self.dut.send_expect("ps -a |grep simple_mp |awk
> '{print $1}'", "# ")
> +        except:
> +            self.alt_session = True
> +            out = self.dut.alt_session.send_expect("ps -a |grep simple_mp
> |awk '{print $1}'", "# ")
> +        if len(out):
> +            pids = out.split('\r\n')
> +            for pid in pids:
> +                self.dut.send_expect('kill -9 %s' % pid, '# ',
> alt_session=self.alt_session )
> +                self.dut.get_session_output(timeout=2)
> 
>      def test_multiprocess_simple_mpbasicoperation(self):
>          """
>          Basic operation.
>          """
> +
>          # Send message from secondary to primary
> 
> self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simp
> le_mp -n 1 -c 3 --proc-type=primary" % self.target, "Finished Process
> Init", 100)
>          time.sleep(20)
> 
> self.dut.alt_session.send_expect("./examples/multi_process/simple_mp/simpl
> e_mp/%s/simple_mp -n 1 -c C --proc-type=secondary" % self.target,
> "Finished Process Init", 100)
> -
>          self.dut.alt_session.send_expect("send hello_primary", ">")
>          out = self.dut.get_session_output()
>          self.dut.alt_session.send_expect("quit", "# ")
> @@ -106,9 +122,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>          Load test of Simple MP application.
>          """
> 
> -        self.dut.kill_all()
> -        self.dut.send_expect("fg", "# ")
> -
> 
> self.dut.alt_session.send_expect("./examples/multi_process/simple_mp/simpl
> e_mp/%s/simple_mp -n 1 -c 3 --proc-type=primary" % self.target, "Finished
> Process Init", 100)
>          time.sleep(20)
> 
> self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simp
> le_mp -n 1 -c C --proc-type=secondary" % self.target, "Finished Process
> Init", 100)
> @@ -129,8 +142,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>          Test use of Auto for Application Startup.
>          """
> 
> -        self.dut.kill_all()
> -
>          # Send message from secondary to primary (auto process type)
>          out =
> self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simp
> le_mp -n 1 -c 3 --proc-type=auto " % self.target, "Finished Process Init",
> 100)
>          self.verify("EAL: Auto-detected process type: PRIMARY" in out,
> "The type of process (PRIMARY) was not detected properly")
> @@ -163,8 +174,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>          """
>          Multiple processes without "--proc-type" flag.
>          """
> -
> -        self.dut.kill_all()
> 
> self.dut.alt_session.send_expect("./examples/multi_process/simple_mp/simpl
> e_mp/%s/simple_mp -n 1 -c 3 -m 64" % self.target, "Finished Process Init",
> 100)
>          out =
> self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simp
> le_mp -n 1 -c C" % self.target, "# ", 100)
> 
> @@ -257,6 +266,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>          """
>          Run after each test suite.
>          """
> -        self.dut.kill_all()
> +        self.kill_mp()
> 
>          pass
> --
> 1.9.1

  reply	other threads:[~2015-11-25 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25  8:51 Lijuan Tu
2015-11-25 10:41 ` Xu, HuilongX [this message]
2015-11-26  0:18   ` Tu, LijuanX A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF2A19295B96364286FEB7F3DDA27A4637AB16D9@SHSMSX101.ccr.corp.intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).